)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"5d22fd22885dfa799d85f5690d283e232e576729","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix trust chain tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since redelegation of trust is only allowed using impersonation."},{"line_number":10,"context_line":"Test under class TestTrustChain need to test redelegation with"},{"line_number":11,"context_line":"impersonation set true."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifba25568e2b55df895377a3b1c9626844b735a7c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dae33548_f14f8f68","line":10,"updated":"2016-02-18 15:09:58.000000000","message":"nit: replace period with comma","commit_id":"4e4618b035c9dc0ee3a89fc8be7dbd20bb52560f"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"50a3f63321f665fd64e1a56361bda14592717408","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix trust chain tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since redelegation of trust is only allowed using impersonation."},{"line_number":10,"context_line":"Test under class TestTrustChain need to test redelegation with"},{"line_number":11,"context_line":"impersonation set true."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifba25568e2b55df895377a3b1c9626844b735a7c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bae84128_77de3940","line":10,"in_reply_to":"dae33548_f14f8f68","updated":"2016-02-22 19:01:15.000000000","message":"Done","commit_id":"4e4618b035c9dc0ee3a89fc8be7dbd20bb52560f"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"5d22fd22885dfa799d85f5690d283e232e576729","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Since redelegation of trust is only allowed using impersonation."},{"line_number":10,"context_line":"Test under class TestTrustChain need to test redelegation with"},{"line_number":11,"context_line":"impersonation set true."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifba25568e2b55df895377a3b1c9626844b735a7c"},{"line_number":14,"context_line":"Partial-Bug: 1538626"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dae33548_91b3a34c","line":12,"updated":"2016-02-18 15:09:58.000000000","message":"Is there any test confirming redelegation not working with impersonation\u003dFalse?","commit_id":"4e4618b035c9dc0ee3a89fc8be7dbd20bb52560f"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"50a3f63321f665fd64e1a56361bda14592717408","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Since redelegation of trust is only allowed using impersonation."},{"line_number":10,"context_line":"Test under class TestTrustChain need to test redelegation with"},{"line_number":11,"context_line":"impersonation set true."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifba25568e2b55df895377a3b1c9626844b735a7c"},{"line_number":14,"context_line":"Partial-Bug: 1538626"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bae84128_1209bbdd","line":12,"in_reply_to":"dae33548_91b3a34c","updated":"2016-02-22 19:01:15.000000000","message":"Base on your previous comments, there is no way to test redelegation with impersonation to false. If trust A is created with redelegation set true and impersonation set to false and a user attempts to create a redelegated trust B with trust A scope token. Then that would just mean that the user would just be creating a regular trust. Maybe initial trust should not be allowed to be created with redelegation set to true and impersonation set to false. Please correct me if I\u0027m wrong.","commit_id":"4e4618b035c9dc0ee3a89fc8be7dbd20bb52560f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8d657f2383664a5d21141d3f89896158371c63b9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since redelegation of trust is only allowed using impersonation,"},{"line_number":10,"context_line":"test under class TestTrustChain need to test redelegation with"},{"line_number":11,"context_line":"impersonation set true."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifba25568e2b55df895377a3b1c9626844b735a7c"},{"line_number":14,"context_line":"Partial-Bug: 1538626"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bae84128_db92444b","line":11,"updated":"2016-02-24 20:55:27.000000000","message":"Does this mean you must allow redelegation in order to impersonate, or you must allow impersonation in order to redelegate?","commit_id":"a7fef0c4eb93e4910970d269ae01b5d04f510f9f"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"b0114bf8cf5272bc7c7c9bb01c43f2bfa7f30e39","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since redelegation of trust is only allowed using impersonation,"},{"line_number":10,"context_line":"test under class TestTrustChain need to test redelegation with"},{"line_number":11,"context_line":"impersonation set true."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifba25568e2b55df895377a3b1c9626844b735a7c"},{"line_number":14,"context_line":"Partial-Bug: 1538626"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9aed3d3a_2237d0e4","line":11,"in_reply_to":"bae84128_db92444b","updated":"2016-02-25 17:04:12.000000000","message":"You must allow impersonation in order to redelegate a trust.","commit_id":"a7fef0c4eb93e4910970d269ae01b5d04f510f9f"}],"keystone/tests/unit/core.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"94f73d163215a0bad967ca28357ae9190871c2df","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                  impersonation\u003dNone, expires\u003dNone, role_ids\u003dNone,"},{"line_number":439,"context_line":"                  role_names\u003dNone, remaining_uses\u003dNone,"},{"line_number":440,"context_line":"                  allow_redelegation\u003dFalse, redelegation_count\u003dNone,"},{"line_number":441,"context_line":"                  redelegated_trust_id\u003dNone, **kwargs):"},{"line_number":442,"context_line":"    ref \u003d {"},{"line_number":443,"context_line":"        \u0027id\u0027: uuid.uuid4().hex,"},{"line_number":444,"context_line":"        \u0027trustor_user_id\u0027: trustor_user_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_5cda234d","side":"PARENT","line":441,"range":{"start_line":441,"start_character":18,"end_line":441,"end_character":44},"updated":"2016-02-23 07:06:55.000000000","message":"i\u0027m not clear on why this had to change?","commit_id":"66fef6491e4be7ab3fb017023fb3c79fc6f285a3"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"701fdbb839e36f67698b8f3fcd750d5a7dde9eaf","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                  impersonation\u003dNone, expires\u003dNone, role_ids\u003dNone,"},{"line_number":439,"context_line":"                  role_names\u003dNone, remaining_uses\u003dNone,"},{"line_number":440,"context_line":"                  allow_redelegation\u003dFalse, redelegation_count\u003dNone,"},{"line_number":441,"context_line":"                  redelegated_trust_id\u003dNone, **kwargs):"},{"line_number":442,"context_line":"    ref \u003d {"},{"line_number":443,"context_line":"        \u0027id\u0027: uuid.uuid4().hex,"},{"line_number":444,"context_line":"        \u0027trustor_user_id\u0027: trustor_user_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_9f281a88","side":"PARENT","line":441,"range":{"start_line":441,"start_character":18,"end_line":441,"end_character":44},"in_reply_to":"bae84128_5cda234d","updated":"2016-02-23 08:52:33.000000000","message":"redelegated_trust_id is a read only attribute that is set by the api. Newly created trust should not populate this attribute.","commit_id":"66fef6491e4be7ab3fb017023fb3c79fc6f285a3"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a7a8717a795d09bc6e9cc701adde87e544112695","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                  impersonation\u003dNone, expires\u003dNone, role_ids\u003dNone,"},{"line_number":439,"context_line":"                  role_names\u003dNone, remaining_uses\u003dNone,"},{"line_number":440,"context_line":"                  allow_redelegation\u003dFalse, redelegation_count\u003dNone,"},{"line_number":441,"context_line":"                  redelegated_trust_id\u003dNone, **kwargs):"},{"line_number":442,"context_line":"    ref \u003d {"},{"line_number":443,"context_line":"        \u0027id\u0027: uuid.uuid4().hex,"},{"line_number":444,"context_line":"        \u0027trustor_user_id\u0027: trustor_user_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_203a1fe8","side":"PARENT","line":441,"in_reply_to":"bae84128_9f281a88","updated":"2016-02-24 20:47:51.000000000","message":"The redelegated_trust_id is only set because the API determines it from the  authentication context when the trust is created. \n\nhttps://github.com/openstack/keystone/blob/d37af165d0850b9e56576a9b524e59ee6b9eb462/keystone/trust/controllers.py#L125-L133\n\nSo - if you create a trust with a trust-scoped token, the trust API should detect that and set redelegated_trust_id for you. We shouldn\u0027t be passing redelegated_trust_id in the actually body of the POST trust reference.","commit_id":"66fef6491e4be7ab3fb017023fb3c79fc6f285a3"}],"keystone/tests/unit/test_v3_auth.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"323b1776d1bc214d0e5b0167708ed338a7a69b93","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from keystone.tests.unit import ksfixtures"},{"line_number":39,"context_line":"from keystone.tests.unit import test_v3"},{"line_number":40,"context_line":"from keystone.tests.unit import utils as test_utils"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_7caf167d","line":41,"updated":"2016-02-12 21:45:59.000000000","message":"extra newline here?","commit_id":"2dcf46ccdcd4622baeba4dc7251e728fa2f0dd7e"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"59ece766e42ae752b62b2d6deda54303d7757e11","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from keystone.tests.unit import ksfixtures"},{"line_number":39,"context_line":"from keystone.tests.unit import test_v3"},{"line_number":40,"context_line":"from keystone.tests.unit import utils as test_utils"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_0b00b733","line":41,"in_reply_to":"3a57f1b5_7caf167d","updated":"2016-02-15 19:01:27.000000000","message":"That is the way it should be.","commit_id":"2dcf46ccdcd4622baeba4dc7251e728fa2f0dd7e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"323b1776d1bc214d0e5b0167708ed338a7a69b93","unresolved":false,"context_lines":[{"line_number":3415,"context_line":"                  token\u003dtrust_token,"},{"line_number":3416,"context_line":"                  expected_status\u003dhttp_client.FORBIDDEN)"},{"line_number":3417,"context_line":""},{"line_number":3418,"context_line":"    @test_utils.wip(\u0027Cannot redelegate with impersonation\u003dFalse\u0027)"},{"line_number":3419,"context_line":"    def test_redelegation_without_impersonation(self):"},{"line_number":3420,"context_line":"        # Update trust to not allow impersonation"},{"line_number":3421,"context_line":"        self.redelegated_trust_ref[\u0027impersonation\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_1c44e2b4","line":3418,"updated":"2016-02-12 21:45:59.000000000","message":"Is this documented in a bug? If so, we should add it to the wip message.\n\n     @test_utils.wip(\u0027Cannot redelegate with impersonation\u003dFalse, see bug # for more info\u0027) \n\nor something of that nature.","commit_id":"2dcf46ccdcd4622baeba4dc7251e728fa2f0dd7e"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"7206b4ecacc165ef49e069ed902febe0f7b4bc70","unresolved":false,"context_lines":[{"line_number":3456,"context_line":"                         body\u003d{\u0027trust\u0027: trust_ref_2},"},{"line_number":3457,"context_line":"                         token\u003dtrust_token,"},{"line_number":3458,"context_line":"                         expected_status\u003dhttp_client.CREATED)"},{"line_number":3459,"context_line":"        trust_2 \u003d self.assertValidTrustResponse(resp)"},{"line_number":3460,"context_line":""},{"line_number":3461,"context_line":"        # Get trusted token"},{"line_number":3462,"context_line":"        auth_data \u003d self.build_authentication_request("}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_1adc7fe3","line":3459,"updated":"2016-02-15 18:33:43.000000000","message":"This is not a second trust in the chain - it\u0027s just one more regular trust: it doesn\u0027t transfer the scope from the initial trustor down the chain, it creates a trust, that delegates scope assigned to the 1st trustee.","commit_id":"2dcf46ccdcd4622baeba4dc7251e728fa2f0dd7e"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"59ece766e42ae752b62b2d6deda54303d7757e11","unresolved":false,"context_lines":[{"line_number":3456,"context_line":"                         body\u003d{\u0027trust\u0027: trust_ref_2},"},{"line_number":3457,"context_line":"                         token\u003dtrust_token,"},{"line_number":3458,"context_line":"                         expected_status\u003dhttp_client.CREATED)"},{"line_number":3459,"context_line":"        trust_2 \u003d self.assertValidTrustResponse(resp)"},{"line_number":3460,"context_line":""},{"line_number":3461,"context_line":"        # Get trusted token"},{"line_number":3462,"context_line":"        auth_data \u003d self.build_authentication_request("}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_85f31073","line":3459,"in_reply_to":"dae33548_1adc7fe3","updated":"2016-02-15 19:01:27.000000000","message":"Ok, so should we even allow creating a trust that sets allow_redelegation\u003dTrue and impersonation\u003dFalse?","commit_id":"2dcf46ccdcd4622baeba4dc7251e728fa2f0dd7e"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"49818fe82c6cbecf4040645f716adb552993081d","unresolved":false,"context_lines":[{"line_number":3457,"context_line":"            trustor_user_id\u003dself.user_id,"},{"line_number":3458,"context_line":"            trustee_user_id\u003dtrustee[\u0027id\u0027],"},{"line_number":3459,"context_line":"            project_id\u003dself.project_id,"},{"line_number":3460,"context_line":"            impersonation\u003dTrue,"},{"line_number":3461,"context_line":"            expires\u003ddict(minutes\u003d1),"},{"line_number":3462,"context_line":"            role_ids\u003d[self.role_id],"},{"line_number":3463,"context_line":"            allow_redelegation\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_cf85c0cf","line":3460,"updated":"2016-02-17 16:45:28.000000000","message":"Current master has impersonation\u003dTrue here.\n\nPlease rebase your changes.","commit_id":"4e4618b035c9dc0ee3a89fc8be7dbd20bb52560f"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"50a3f63321f665fd64e1a56361bda14592717408","unresolved":false,"context_lines":[{"line_number":3457,"context_line":"            trustor_user_id\u003dself.user_id,"},{"line_number":3458,"context_line":"            trustee_user_id\u003dtrustee[\u0027id\u0027],"},{"line_number":3459,"context_line":"            project_id\u003dself.project_id,"},{"line_number":3460,"context_line":"            impersonation\u003dTrue,"},{"line_number":3461,"context_line":"            expires\u003ddict(minutes\u003d1),"},{"line_number":3462,"context_line":"            role_ids\u003d[self.role_id],"},{"line_number":3463,"context_line":"            allow_redelegation\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_b721e14f","line":3460,"in_reply_to":"dae33548_cf85c0cf","updated":"2016-02-22 19:01:15.000000000","message":"This was a mistake by my part. I assumed that redelegation was possible without impersonation. Following patch changed this code.\nPatch: https://review.openstack.org/#/c/269824/\nThis will revert that change.","commit_id":"4e4618b035c9dc0ee3a89fc8be7dbd20bb52560f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"94f73d163215a0bad967ca28357ae9190871c2df","unresolved":false,"context_lines":[{"line_number":3511,"context_line":"                impersonation\u003dFalse,"},{"line_number":3512,"context_line":"                role_ids\u003d[self.role_id],"},{"line_number":3513,"context_line":"                allow_redelegation\u003dTrue,"},{"line_number":3514,"context_line":"                redelegated_trust_id\u003dredelegated_trust_id)"},{"line_number":3515,"context_line":"            r \u003d self.post(\u0027/OS-TRUST/trusts\u0027,"},{"line_number":3516,"context_line":"                          body\u003d{\u0027trust\u0027: trust_ref},"},{"line_number":3517,"context_line":"                          token\u003dtrust_token)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_3cf0ffc8","side":"PARENT","line":3514,"range":{"start_line":3514,"start_character":16,"end_line":3514,"end_character":57},"updated":"2016-02-23 07:06:55.000000000","message":"removing this line should mean you didn\u0027t have to make the change in core.py","commit_id":"66fef6491e4be7ab3fb017023fb3c79fc6f285a3"}]}