)]}'
{"keystone/cmd/cli.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4e0819feb651bd9041d9d6c9d51df834fc270594","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        all configuration files - and that sounds too dangerous as a"},{"line_number":673,"context_line":"        default. So we use it in a slightly unconventional way, where all"},{"line_number":674,"context_line":"        parameters are optional, but you must specify at least one."},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"        \"\"\""},{"line_number":677,"context_line":"        if (CONF.command.all is False and"},{"line_number":678,"context_line":"                CONF.command.domain_name is None):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_48cdd664","side":"PARENT","line":675,"updated":"2016-04-01 16:22:38.000000000","message":"Should we take this opportunity to add actual docstrings to this method to be consistent with other methods in the module? \n\n    :returns: a boolean indicating if the options provided are valid","commit_id":"c0d405653ea54669513ab52034cf0d3a57a5f12f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"1328813c27d92440889856419f17f56c4164e606","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        all configuration files - and that sounds too dangerous as a"},{"line_number":673,"context_line":"        default. So we use it in a slightly unconventional way, where all"},{"line_number":674,"context_line":"        parameters are optional, but you must specify at least one."},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"        \"\"\""},{"line_number":677,"context_line":"        if (CONF.command.all is False and"},{"line_number":678,"context_line":"                CONF.command.domain_name is None):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_9436c7e5","side":"PARENT","line":675,"in_reply_to":"ba0121b8_48cdd664","updated":"2016-04-03 01:06:09.000000000","message":"Could be done in a follow up as well, but should be proposed before this merges.","commit_id":"c0d405653ea54669513ab52034cf0d3a57a5f12f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4e0819feb651bd9041d9d6c9d51df834fc270594","unresolved":false,"context_lines":[{"line_number":775,"context_line":"        command option will have been set. It is either set to the name of an"},{"line_number":776,"context_line":"        explicit domain, or it\u0027s None to indicate that we want all domain"},{"line_number":777,"context_line":"        config files."},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"        \"\"\""},{"line_number":780,"context_line":"        domain_name \u003d CONF.command.domain_name"},{"line_number":781,"context_line":"        conf_dir \u003d CONF.identity.domain_config_dir"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_c87ba6f3","side":"PARENT","line":778,"updated":"2016-04-01 16:22:38.000000000","message":"Same comment here about the returns docstrings.","commit_id":"c0d405653ea54669513ab52034cf0d3a57a5f12f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4e0819feb651bd9041d9d6c9d51df834fc270594","unresolved":false,"context_lines":[{"line_number":800,"context_line":"        except Exception:"},{"line_number":801,"context_line":"            # It is likely that there is some SQL or other backend error"},{"line_number":802,"context_line":"            # related to set up"},{"line_number":803,"context_line":"            print(_(\u0027Unable to access the keystone database, please check it \u0027"},{"line_number":804,"context_line":"                    \u0027is configured correctly.\u0027))"},{"line_number":805,"context_line":"            raise"},{"line_number":806,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_28d982f3","side":"PARENT","line":803,"updated":"2016-04-01 16:22:38.000000000","message":"In addition to printing this, should this be logged?","commit_id":"c0d405653ea54669513ab52034cf0d3a57a5f12f"}]}