)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"95c8e0f0e1004cce006802dd01d437609e61bced","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Adam Young \u003cayoung@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-15 12:14:07 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Re-enable and undepreate admin-token"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partial-Bug: 1545761"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_511ef2ba","line":7,"updated":"2016-02-15 17:21:37.000000000","message":"s/undepreate/undeprecate/","commit_id":"ededb4ddda697a266dc5afa5d8b6aa289726326e"}],"etc/keystone-paste.ini":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"f0b19b8045081a43f284fe3d5cb7b25dd692b619","unresolved":false,"context_lines":[{"line_number":54,"context_line":"[pipeline:public_api]"},{"line_number":55,"context_line":"# The last item in this pipeline must be public_service or an equivalent"},{"line_number":56,"context_line":"# application. It cannot be a filter."},{"line_number":57,"context_line":"pipeline \u003d cors sizelimit url_normalize request_id build_auth_context token_authadmin_token_auth json_body ec2_extension public_service"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[pipeline:admin_api]"},{"line_number":60,"context_line":"# The last item in this pipeline must be admin_service or an equivalent"}],"source_content_type":"text/x-properties","patch_set":1,"id":"dae33548_91651a47","line":57,"updated":"2016-02-15 17:22:21.000000000","message":"Missing a space unless I\u0027m mistaken, same for the pipelines below","commit_id":"ededb4ddda697a266dc5afa5d8b6aa289726326e"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"07d38dd3dfeefba45bec4b02cdc0091dc3bf2a1b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"[pipeline:public_api]"},{"line_number":55,"context_line":"# The last item in this pipeline must be public_service or an equivalent"},{"line_number":56,"context_line":"# application. It cannot be a filter."},{"line_number":57,"context_line":"pipeline \u003d cors sizelimit url_normalize request_id build_auth_context token_authadmin_token_auth json_body ec2_extension public_service"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[pipeline:admin_api]"},{"line_number":60,"context_line":"# The last item in this pipeline must be admin_service or an equivalent"}],"source_content_type":"text/x-properties","patch_set":1,"id":"dae33548_b1a13eac","line":57,"updated":"2016-02-15 17:23:51.000000000","message":"missing a space here and the other 2 lines.","commit_id":"ededb4ddda697a266dc5afa5d8b6aa289726326e"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"e8574a384c6489d6d2bac84ca383e9b08bf20f79","unresolved":false,"context_lines":[{"line_number":54,"context_line":"[pipeline:public_api]"},{"line_number":55,"context_line":"# The last item in this pipeline must be public_service or an equivalent"},{"line_number":56,"context_line":"# application. It cannot be a filter."},{"line_number":57,"context_line":"pipeline \u003d cors sizelimit url_normalize request_id build_auth_context token_authadmin_token_auth json_body ec2_extension public_service"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[pipeline:admin_api]"},{"line_number":60,"context_line":"# The last item in this pipeline must be admin_service or an equivalent"}],"source_content_type":"text/x-properties","patch_set":1,"id":"dae33548_bfb905ec","line":57,"in_reply_to":"dae33548_91651a47","updated":"2016-02-15 18:51:31.000000000","message":"Done","commit_id":"ededb4ddda697a266dc5afa5d8b6aa289726326e"}],"keystone/middleware/core.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"07d38dd3dfeefba45bec4b02cdc0091dc3bf2a1b","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def __init__(self, application):"},{"line_number":62,"context_line":"        super(AdminTokenAuthMiddleware, self).__init__(application)"},{"line_number":63,"context_line":"        msg \u003d _(\"Remove admin_token_auth from the paste-ini file.\""},{"line_number":64,"context_line":"                \"the admin_token_auth middleware should only be used for\""},{"line_number":65,"context_line":"                \"initializing the keystone server, and should be removed \""},{"line_number":66,"context_line":"                \"from pasts.ini file in the [pipeline:api_v3], \""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_71fdf639","line":63,"updated":"2016-02-15 17:23:51.000000000","message":"I suggest this: \"The admin_auth_token middleware presents a security risk and should be removed from the [pipeline:api_v3], [pipeline:admin_api], and [pipeline:public_api] sections of your paste ini file.\"","commit_id":"ededb4ddda697a266dc5afa5d8b6aa289726326e"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"e8574a384c6489d6d2bac84ca383e9b08bf20f79","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def __init__(self, application):"},{"line_number":62,"context_line":"        super(AdminTokenAuthMiddleware, self).__init__(application)"},{"line_number":63,"context_line":"        msg \u003d _(\"Remove admin_token_auth from the paste-ini file.\""},{"line_number":64,"context_line":"                \"the admin_token_auth middleware should only be used for\""},{"line_number":65,"context_line":"                \"initializing the keystone server, and should be removed \""},{"line_number":66,"context_line":"                \"from pasts.ini file in the [pipeline:api_v3], \""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_ff48ad2f","line":63,"in_reply_to":"dae33548_71fdf639","updated":"2016-02-15 18:51:31.000000000","message":"Done","commit_id":"ededb4ddda697a266dc5afa5d8b6aa289726326e"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"07d38dd3dfeefba45bec4b02cdc0091dc3bf2a1b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def __init__(self, application):"},{"line_number":62,"context_line":"        super(AdminTokenAuthMiddleware, self).__init__(application)"},{"line_number":63,"context_line":"        msg \u003d _(\"Remove admin_token_auth from the paste-ini file.\""},{"line_number":64,"context_line":"                \"the admin_token_auth middleware should only be used for\""},{"line_number":65,"context_line":"                \"initializing the keystone server, and should be removed \""},{"line_number":66,"context_line":"                \"from pasts.ini file in the [pipeline:api_v3], \""},{"line_number":67,"context_line":"                \"[pipeline:admin_api], and [pipeline:public_api] sections.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_b1ddbe16","line":64,"updated":"2016-02-15 17:23:51.000000000","message":"s/the/The/","commit_id":"ededb4ddda697a266dc5afa5d8b6aa289726326e"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"e8574a384c6489d6d2bac84ca383e9b08bf20f79","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def __init__(self, application):"},{"line_number":62,"context_line":"        super(AdminTokenAuthMiddleware, self).__init__(application)"},{"line_number":63,"context_line":"        msg \u003d _(\"Remove admin_token_auth from the paste-ini file.\""},{"line_number":64,"context_line":"                \"the admin_token_auth middleware should only be used for\""},{"line_number":65,"context_line":"                \"initializing the keystone server, and should be removed \""},{"line_number":66,"context_line":"                \"from pasts.ini file in the [pipeline:api_v3], \""},{"line_number":67,"context_line":"                \"[pipeline:admin_api], and [pipeline:public_api] sections.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_1f21114e","line":64,"in_reply_to":"dae33548_b1ddbe16","updated":"2016-02-15 18:51:31.000000000","message":"Done","commit_id":"ededb4ddda697a266dc5afa5d8b6aa289726326e"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"b8a19bfe8d40c2bd10354c1be9c5baf6cfa952b9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        msg \u003d _(\"Remove admin_token_auth from the paste-ini file.\""},{"line_number":64,"context_line":"                \"the admin_token_auth middleware should only be used for\""},{"line_number":65,"context_line":"                \"initializing the keystone server, and should be removed \""},{"line_number":66,"context_line":"                \"from pasts.ini file in the [pipeline:api_v3], \""},{"line_number":67,"context_line":"                \"[pipeline:admin_api], and [pipeline:public_api] sections.\")"},{"line_number":68,"context_line":"        LOG.WARN(msg)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_b1881e24","line":66,"range":{"start_line":66,"start_character":22,"end_line":66,"end_character":31},"updated":"2016-02-15 17:17:37.000000000","message":"paste.ini?","commit_id":"ededb4ddda697a266dc5afa5d8b6aa289726326e"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"07d38dd3dfeefba45bec4b02cdc0091dc3bf2a1b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        msg \u003d _(\"Remove admin_token_auth from the paste-ini file.\""},{"line_number":64,"context_line":"                \"the admin_token_auth middleware should only be used for\""},{"line_number":65,"context_line":"                \"initializing the keystone server, and should be removed \""},{"line_number":66,"context_line":"                \"from pasts.ini file in the [pipeline:api_v3], \""},{"line_number":67,"context_line":"                \"[pipeline:admin_api], and [pipeline:public_api] sections.\")"},{"line_number":68,"context_line":"        LOG.WARN(msg)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_f182a6ff","line":66,"updated":"2016-02-15 17:23:51.000000000","message":"s/pasts/paste/","commit_id":"ededb4ddda697a266dc5afa5d8b6aa289726326e"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"e8574a384c6489d6d2bac84ca383e9b08bf20f79","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        msg \u003d _(\"Remove admin_token_auth from the paste-ini file.\""},{"line_number":64,"context_line":"                \"the admin_token_auth middleware should only be used for\""},{"line_number":65,"context_line":"                \"initializing the keystone server, and should be removed \""},{"line_number":66,"context_line":"                \"from pasts.ini file in the [pipeline:api_v3], \""},{"line_number":67,"context_line":"                \"[pipeline:admin_api], and [pipeline:public_api] sections.\")"},{"line_number":68,"context_line":"        LOG.WARN(msg)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_ff1d4d10","line":66,"range":{"start_line":66,"start_character":22,"end_line":66,"end_character":31},"in_reply_to":"dae33548_b1881e24","updated":"2016-02-15 18:51:31.000000000","message":"Done","commit_id":"ededb4ddda697a266dc5afa5d8b6aa289726326e"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"103c327140b507827245a0edce24aa6daa88904f","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def __init__(self, application):"},{"line_number":62,"context_line":"        super(AdminTokenAuthMiddleware, self).__init__(application)"},{"line_number":63,"context_line":"        msg \u003d _(\"Remove admin_token_auth from the paste-ini file.\""},{"line_number":64,"context_line":"                \"The admin_token_auth middleware should only be used for \""},{"line_number":65,"context_line":"                \"initializing the keystone server.  The admin_auth_token \""},{"line_number":66,"context_line":"                \"middleware presents a security risk and should be \""}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_856310b1","line":63,"updated":"2016-02-15 18:48:51.000000000","message":"let\u0027s remove the first 2 sentences here. The first is redundant and the second is partly redundant, partly true-but-only-if-you\u0027re-not-using-the-preferred-keystone-manage-CLI.","commit_id":"92bd75333fd39a2b69ca81b337d6736c06ecb732"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"103c327140b507827245a0edce24aa6daa88904f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        msg \u003d _(\"Remove admin_token_auth from the paste-ini file.\""},{"line_number":64,"context_line":"                \"The admin_token_auth middleware should only be used for \""},{"line_number":65,"context_line":"                \"initializing the keystone server.  The admin_auth_token \""},{"line_number":66,"context_line":"                \"middleware presents a security risk and should be \""},{"line_number":67,"context_line":"                \"removed from the [pipeline:api_v3], [pipeline:admin_api], \""},{"line_number":68,"context_line":"                \"and [pipeline:public_api] sections of your paste ini file.\")"},{"line_number":69,"context_line":"        LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_c5cfd8ae","line":66,"updated":"2016-02-15 18:48:51.000000000","message":"s/admin_auth_token/admin_token_auth/  (my bad, I typed that wrong in my previous comment).","commit_id":"92bd75333fd39a2b69ca81b337d6736c06ecb732"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"0d2c1ae352e459f7f6563c05e50da9a8263f7ab5","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def __init__(self, application):"},{"line_number":62,"context_line":"        super(AdminTokenAuthMiddleware, self).__init__(application)"},{"line_number":63,"context_line":"        msg \u003d _(\"The admin_token_auth middleware presents a security risk \""},{"line_number":64,"context_line":"                \"and should be removed from the [pipeline:api_v3], \""},{"line_number":65,"context_line":"                \"[pipeline:admin_api], and [pipeline:public_api] sections of \""},{"line_number":66,"context_line":"                \"your paste ini file.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_4a6d9097","line":63,"updated":"2016-02-15 20:52:34.000000000","message":"should be _LW not _ and moving it down into the LOG.warning() call itself will fix the pep8 error","commit_id":"3749791220aadd5b08907c4295e465c3850a3aef"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"d9998641a828b7aad085e8bba1b3f7589a4a83eb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                        \"risk and should be removed from the \""},{"line_number":65,"context_line":"                        \"[pipeline:api_v3], [pipeline:admin_api], and \""},{"line_number":66,"context_line":"                        \"[pipeline:public_api] sections of your paste ini \""},{"line_number":67,"context_line":"                        \"file.\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def process_request(self, request):"},{"line_number":70,"context_line":"        token \u003d request.headers.get(AUTH_TOKEN_HEADER)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_6de22ed7","line":67,"updated":"2016-02-15 21:30:58.000000000","message":"missing Paren.","commit_id":"1ab71987ab1cf43ab9b4d7be34c4e520ba705c56"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"a11c4aa982411c2020b473dccd50d99bd90ea6cb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                        \"risk and should be removed from the \""},{"line_number":65,"context_line":"                        \"[pipeline:api_v3], [pipeline:admin_api], and \""},{"line_number":66,"context_line":"                        \"[pipeline:public_api] sections of your paste ini \""},{"line_number":67,"context_line":"                        \"file.\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def process_request(self, request):"},{"line_number":70,"context_line":"        token \u003d request.headers.get(AUTH_TOKEN_HEADER)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_48e8f810","line":67,"in_reply_to":"dae33548_6de22ed7","updated":"2016-02-15 21:51:00.000000000","message":"Ah what I get for editing in gerrit interface :P","commit_id":"1ab71987ab1cf43ab9b4d7be34c4e520ba705c56"}],"releasenotes/notes/deprecated-as-of-mitaka-8534e43fa40c1d09.yaml":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"116d2a61b6755c63f27c9645f1f5182b9e4a57a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"deprecations:"},{"line_number":5,"context_line":"  - \u003e"},{"line_number":6,"context_line":"    [`blueprint deprecated-as-of-mitaka \u003chttps://blueprints.launchpad.net/keystone/+spec/deprecated-as-of-mitaka\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dae33548_eaf624d6","line":3,"updated":"2016-02-15 20:53:10.000000000","message":"REmove the \"upgrade:\" and \"- \u003e\" lines as well.","commit_id":"3749791220aadd5b08907c4295e465c3850a3aef"}]}