)]}'
{"keystone/identity/controllers.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a058f10d92f10933265dc4bc6fc95515aac358bc","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                context, context[\u0027query_string\u0027].get(\u0027name\u0027))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.assert_admin(context)"},{"line_number":51,"context_line":"        user_list \u003d self.identity_api.list_users("},{"line_number":52,"context_line":"            CONF.identity.default_domain_id)"},{"line_number":53,"context_line":"        return {\u0027users\u0027: self.v3_to_v2_user(user_list)}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @controller.v2_deprecated"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_66a0b691","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":44},"updated":"2016-02-26 00:22:04.000000000","message":"nothing here? yet the test passes.. hmm","commit_id":"073cf4fff45fd814f23d40b600e36c73a54eb81e"}],"keystone/resource/core.py":[{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"3ef99c2b0759ce00e142f720cd6e0c3fa3a824a8","unresolved":false,"context_lines":[{"line_number":802,"context_line":"                \u0027id\u0027: CONF.identity.default_domain_id,"},{"line_number":803,"context_line":"                \u0027description\u0027: \u0027Domain created automatically to support V2.0 \u0027"},{"line_number":804,"context_line":"                               \u0027operations.\u0027,"},{"line_number":805,"context_line":"            }"},{"line_number":806,"context_line":"            self.create_domain(CONF.identity.default_domain_id,"},{"line_number":807,"context_line":"                               default_domain_attrs)"},{"line_number":808,"context_line":"            LOG.warning(_LW("}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_b79f935e","line":805,"updated":"2016-02-26 17:07:01.000000000","message":"Why try to create every time? would it be better to get default domain and create it if it doesn\u0027t exist","commit_id":"bbaf6b57a997affc289482a5a0b2bcb5d898ba80"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a058f10d92f10933265dc4bc6fc95515aac358bc","unresolved":false,"context_lines":[{"line_number":804,"context_line":"            default_domain_attrs \u003d {"},{"line_number":805,"context_line":"                \u0027name\u0027: \u0027Default\u0027,"},{"line_number":806,"context_line":"                \u0027id\u0027: CONF.identity.default_domain_id,"},{"line_number":807,"context_line":"                \u0027description\u0027: \u0027Domain created automatically to support V2.0 \u0027"},{"line_number":808,"context_line":"                               \u0027operations.\u0027,"},{"line_number":809,"context_line":"            }"},{"line_number":810,"context_line":"            self.create_domain(CONF.identity.default_domain_id,"},{"line_number":811,"context_line":"                               default_domain_attrs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_e6be86d3","line":808,"range":{"start_line":807,"start_character":0,"end_line":808,"end_character":45},"updated":"2016-02-26 00:22:04.000000000","message":"the description was changed recently...\n\nhttps://github.com/openstack/keystone/commit/52080a8f8f6d9ef98154b5efa2b8a950937fc50f","commit_id":"073cf4fff45fd814f23d40b600e36c73a54eb81e"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"3406951564fdf65cb28dfda606ee720fe699b001","unresolved":false,"context_lines":[{"line_number":804,"context_line":"            default_domain_attrs \u003d {"},{"line_number":805,"context_line":"                \u0027name\u0027: \u0027Default\u0027,"},{"line_number":806,"context_line":"                \u0027id\u0027: CONF.identity.default_domain_id,"},{"line_number":807,"context_line":"                \u0027description\u0027: \u0027Domain created automatically to support V2.0 \u0027"},{"line_number":808,"context_line":"                               \u0027operations.\u0027,"},{"line_number":809,"context_line":"            }"},{"line_number":810,"context_line":"            self.create_domain(CONF.identity.default_domain_id,"},{"line_number":811,"context_line":"                               default_domain_attrs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_606875f6","line":808,"range":{"start_line":807,"start_character":0,"end_line":808,"end_character":45},"in_reply_to":"9aed3d3a_e6be86d3","updated":"2016-02-26 14:10:54.000000000","message":"This is only used with V2 operations, so if this domain is created then it\u0027s because it\u0027s not a V3-only deployment. So the description is different.","commit_id":"073cf4fff45fd814f23d40b600e36c73a54eb81e"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a058f10d92f10933265dc4bc6fc95515aac358bc","unresolved":false,"context_lines":[{"line_number":812,"context_line":"            LOG.warning(_LW("},{"line_number":813,"context_line":"                \u0027The default domain was created automatically to contain V2 \u0027"},{"line_number":814,"context_line":"                \u0027resources. This is deprecated in the M release and will not \u0027"},{"line_number":815,"context_line":"                \u0027be supported in the N release. Create the default domain \u0027"},{"line_number":816,"context_line":"                \u0027manually or use the keystone-manage bootstrap command.\u0027))"},{"line_number":817,"context_line":"        except exception.Conflict:"},{"line_number":818,"context_line":"            LOG.debug(\u0027The default domain already exists.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_c676e23d","line":815,"range":{"start_line":815,"start_character":37,"end_line":815,"end_character":38},"updated":"2016-02-26 00:22:04.000000000","message":"O release? it needs 2 cycles","commit_id":"073cf4fff45fd814f23d40b600e36c73a54eb81e"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"3406951564fdf65cb28dfda606ee720fe699b001","unresolved":false,"context_lines":[{"line_number":812,"context_line":"            LOG.warning(_LW("},{"line_number":813,"context_line":"                \u0027The default domain was created automatically to contain V2 \u0027"},{"line_number":814,"context_line":"                \u0027resources. This is deprecated in the M release and will not \u0027"},{"line_number":815,"context_line":"                \u0027be supported in the N release. Create the default domain \u0027"},{"line_number":816,"context_line":"                \u0027manually or use the keystone-manage bootstrap command.\u0027))"},{"line_number":817,"context_line":"        except exception.Conflict:"},{"line_number":818,"context_line":"            LOG.debug(\u0027The default domain already exists.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_c06d0106","line":815,"range":{"start_line":815,"start_character":37,"end_line":815,"end_character":38},"in_reply_to":"9aed3d3a_c676e23d","updated":"2016-02-26 14:10:54.000000000","message":"Done","commit_id":"073cf4fff45fd814f23d40b600e36c73a54eb81e"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"cc6df60783aff3cce4c10dab28a5a97c61269e74","unresolved":false,"context_lines":[{"line_number":804,"context_line":"            default_domain_attrs \u003d {"},{"line_number":805,"context_line":"                \u0027name\u0027: \u0027Default\u0027,"},{"line_number":806,"context_line":"                \u0027id\u0027: CONF.identity.default_domain_id,"},{"line_number":807,"context_line":"                \u0027description\u0027: \u0027Domain created automatically to support V2.0 \u0027"},{"line_number":808,"context_line":"                               \u0027operations.\u0027,"},{"line_number":809,"context_line":"            }"},{"line_number":810,"context_line":"            self.create_domain(CONF.identity.default_domain_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_d6fdbd3b","line":807,"updated":"2016-02-26 16:58:26.000000000","message":"does this really need to be spelled out in the description? I would just leave that explanation to the log message. When bootstrap creates the domain, it doesn\u0027t say \"Domain created by keystone-manage bootstrap\", because nobody is going to care about that in the long run.","commit_id":"8461b0640eb65edd1f1b509a1243647736872de4"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"73a3322502f7829bf6158c8ba3fc195036a10216","unresolved":false,"context_lines":[{"line_number":804,"context_line":"            default_domain_attrs \u003d {"},{"line_number":805,"context_line":"                \u0027name\u0027: \u0027Default\u0027,"},{"line_number":806,"context_line":"                \u0027id\u0027: CONF.identity.default_domain_id,"},{"line_number":807,"context_line":"                \u0027description\u0027: \u0027Domain created automatically to support V2.0 \u0027"},{"line_number":808,"context_line":"                               \u0027operations.\u0027,"},{"line_number":809,"context_line":"            }"},{"line_number":810,"context_line":"            self.create_domain(CONF.identity.default_domain_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_ef4c6472","line":807,"in_reply_to":"9aed3d3a_d6fdbd3b","updated":"2016-02-26 17:33:01.000000000","message":"It doesn\u0027t need to be. Deployments that want a different description can use PATCH /v3/domains to change the description for however they want to actually use it. Or they can create a default domain themselves beforehand.","commit_id":"8461b0640eb65edd1f1b509a1243647736872de4"}],"keystone/tests/unit/resource/test_core.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3c9ccaca4eefc61cf0673505b7c9d4153beddcae","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027id\u0027: CONF.identity.default_domain_id,"},{"line_number":48,"context_line":"            \u0027name\u0027: \u0027Default\u0027,"},{"line_number":49,"context_line":"            \u0027enabled\u0027: True,"},{"line_number":50,"context_line":"            \u0027description\u0027: \u0027Domain created automatically to support V2.0 \u0027"},{"line_number":51,"context_line":"                           \u0027operations.\u0027,"},{"line_number":52,"context_line":"        }"},{"line_number":53,"context_line":"        self.assertEqual(expected_domain, default_domain)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_46e772e4","line":51,"range":{"start_line":50,"start_character":28,"end_line":51,"end_character":39},"updated":"2016-02-26 00:22:52.000000000","message":"the description changed to \"The default domain.\", this was done for v3 specific deployments that don\u0027t expose v2, but still have a default domain","commit_id":"073cf4fff45fd814f23d40b600e36c73a54eb81e"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"85b30b5f03a75860b4cee8f69c6b913a5e73568c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027id\u0027: CONF.identity.default_domain_id,"},{"line_number":48,"context_line":"            \u0027name\u0027: \u0027Default\u0027,"},{"line_number":49,"context_line":"            \u0027enabled\u0027: True,"},{"line_number":50,"context_line":"            \u0027description\u0027: \u0027Domain created automatically to support V2.0 \u0027"},{"line_number":51,"context_line":"                           \u0027operations.\u0027,"},{"line_number":52,"context_line":"        }"},{"line_number":53,"context_line":"        self.assertEqual(expected_domain, default_domain)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_c0350147","line":51,"range":{"start_line":50,"start_character":28,"end_line":51,"end_character":39},"in_reply_to":"9aed3d3a_46e772e4","updated":"2016-02-26 14:08:41.000000000","message":"If this code path is used then this isn\u0027t a V3 specific deployment, so the description is different.","commit_id":"073cf4fff45fd814f23d40b600e36c73a54eb81e"}]}