)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b415d42052dc3e8f7549b6f4c907c5fb3516029c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael Krotscheck \u003ckrotscheck@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-26 07:07:55 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Moved CORS middleware configuration into oslo-config-generator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Default values for CORS middleware have been moved from paste.ini"},{"line_number":10,"context_line":"into oslo\u0027s config generator. All configuration options in use will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aed3d3a_20bae86e","line":7,"updated":"2016-02-26 15:23:36.000000000","message":"The config generator just creates the sample configuration file... is this adequate to actually allow configuration through the config file?","commit_id":"2abf199f893959f8c68435e58a856c51c0db76a4"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"b80b9fe3ae1e4519907e77df3837540c3dd66ade","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael Krotscheck \u003ckrotscheck@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-26 07:07:55 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Moved CORS middleware configuration into oslo-config-generator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Default values for CORS middleware have been moved from paste.ini"},{"line_number":10,"context_line":"into oslo\u0027s config generator. All configuration options in use will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aed3d3a_f14d709a","line":7,"in_reply_to":"9aed3d3a_20bae86e","updated":"2016-02-26 16:06:06.000000000","message":"Yes. The remaining component is the \"oslo_config_project \u003d keystone\" line in paste.ini, which instructs the middleware to try to use oslo_config to discover the keystone.conf file.","commit_id":"2abf199f893959f8c68435e58a856c51c0db76a4"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"359d159bd06165707c621b2699e66fb4eac2d3eb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael Krotscheck \u003ckrotscheck@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-29 13:32:52 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Moved CORS middleware configuration into oslo-config-generator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Default values for CORS middleware have been moved from paste.ini"},{"line_number":10,"context_line":"into oslo\u0027s config generator. All configuration options in use will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9aed3d3a_90c3c756","line":7,"updated":"2016-02-29 23:43:16.000000000","message":"This should describe what the change actually does. oslo-config-generator doesn\u0027t configure anything.\n\nThe same comment applies to the body of the commit message.","commit_id":"3b8668ca041fe2e45cfdfd821b9d1a67778dbb9f"}],"etc/keystone.conf.sample":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b415d42052dc3e8f7549b6f4c907c5fb3516029c","unresolved":false,"context_lines":[{"line_number":468,"context_line":""},{"line_number":469,"context_line":"# Indicate whether this resource may be shared with the domain received in the"},{"line_number":470,"context_line":"# requests \"origin\" header. (list value)"},{"line_number":471,"context_line":"#allowed_origin \u003d https://horizon.example.com"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"# Indicate that the actual request can include user credentials (boolean value)"},{"line_number":474,"context_line":"#allow_credentials \u003d true"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9aed3d3a_8b14b544","line":471,"updated":"2016-02-26 15:23:36.000000000","message":"this should have no default since we don\u0027t know how they\u0027ve deployed their ui.\n\nThis applies to the allowed_origin in cors.subdomain, too.","commit_id":"2abf199f893959f8c68435e58a856c51c0db76a4"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"b80b9fe3ae1e4519907e77df3837540c3dd66ade","unresolved":false,"context_lines":[{"line_number":468,"context_line":""},{"line_number":469,"context_line":"# Indicate whether this resource may be shared with the domain received in the"},{"line_number":470,"context_line":"# requests \"origin\" header. (list value)"},{"line_number":471,"context_line":"#allowed_origin \u003d https://horizon.example.com"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"# Indicate that the actual request can include user credentials (boolean value)"},{"line_number":474,"context_line":"#allow_credentials \u003d true"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9aed3d3a_71696025","line":471,"in_reply_to":"9aed3d3a_8b14b544","updated":"2016-02-26 16:06:06.000000000","message":"I disagree.... sortof.  There is utility in demonstrating an example value, since misformatting this could result in deployer frustration. There\u0027s a related patch that updates the config comments to provide an example value: https://review.openstack.org/#/c/285387/\n\nIf that patch manages to still get into Mitaka (unlikely), then I don\u0027t mind switching this to \u003cnone\u003e. Otherwise, I would prefer that we keep a sane demo value here.","commit_id":"2abf199f893959f8c68435e58a856c51c0db76a4"}],"keystone/cmd/cli.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7554ff0bc8501c598b136a40c47c5aca1cfece79","unresolved":false,"context_lines":[{"line_number":860,"context_line":"    config.configure()"},{"line_number":861,"context_line":"    sql.initialize()"},{"line_number":862,"context_line":"    config.set_default_for_default_log_levels()"},{"line_number":863,"context_line":"    config.set_middleware_defaults()"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"    CONF(args\u003dargv[1:],"},{"line_number":866,"context_line":"         project\u003d\u0027keystone\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_a37e9416","line":863,"updated":"2016-02-29 19:14:26.000000000","message":"No need to do this here since middleware isn\u0027t used when doing keystone-manage.","commit_id":"5ab7717ede45ca16b440d08c042b422b2aa2da67"}],"keystone/common/config.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b415d42052dc3e8f7549b6f4c907c5fb3516029c","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"    \"\"\"Update default configuration options for oslo.middleware.\"\"\""},{"line_number":1226,"context_line":"    # CORS Defaults"},{"line_number":1227,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":1228,"context_line":"                     allowed_origin\u003d[\u0027https://horizon.example.com\u0027],"},{"line_number":1229,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":1230,"context_line":"                                    \u0027X-Openstack-Request-Id\u0027,"},{"line_number":1231,"context_line":"                                    \u0027X-Subject-Token\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_0b9c25bf","line":1228,"updated":"2016-02-26 15:23:36.000000000","message":"I\u0027m guessing this is it. This isn\u0027t going to work for anybody so it shouldn\u0027t be the default.","commit_id":"2abf199f893959f8c68435e58a856c51c0db76a4"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"24bd75c315049a494d837ffa62955c309d59c6f0","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"    \"\"\"Update default configuration options for oslo.middleware.\"\"\""},{"line_number":1226,"context_line":"    # CORS Defaults"},{"line_number":1227,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":1228,"context_line":"                     allowed_origin\u003d[\u0027https://horizon.example.com\u0027],"},{"line_number":1229,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":1230,"context_line":"                                    \u0027X-Openstack-Request-Id\u0027,"},{"line_number":1231,"context_line":"                                    \u0027X-Subject-Token\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_cf123bb4","line":1228,"in_reply_to":"9aed3d3a_09270365","updated":"2016-02-26 19:09:13.000000000","message":"@werner- We\u0027ve got two different situations here. One is set_default as a tool solely to drive oslo-generate-config. The second is to set_default in order to change the behavior of the system. This particular patch doesn\u0027t include any code paths for the latter, it only addresses the former. There\u0027s an open question in the main patch discussion on whether it makes sense to do one, both, or neither.","commit_id":"2abf199f893959f8c68435e58a856c51c0db76a4"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"11593824beaf36a69de12da1b26c7bdf7b08aed3","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"    \"\"\"Update default configuration options for oslo.middleware.\"\"\""},{"line_number":1226,"context_line":"    # CORS Defaults"},{"line_number":1227,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":1228,"context_line":"                     allowed_origin\u003d[\u0027https://horizon.example.com\u0027],"},{"line_number":1229,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":1230,"context_line":"                                    \u0027X-Openstack-Request-Id\u0027,"},{"line_number":1231,"context_line":"                                    \u0027X-Subject-Token\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_09270365","line":1228,"in_reply_to":"9aed3d3a_0b9c25bf","updated":"2016-02-26 18:24:10.000000000","message":"This value should not be set default in code since it\u0027s just an example.","commit_id":"2abf199f893959f8c68435e58a856c51c0db76a4"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"6782e2a1fcf9930a2043f5e4ef3e5cf40e7c8068","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"    \"\"\"Update default configuration options for oslo.middleware.\"\"\""},{"line_number":1226,"context_line":"    # CORS Defaults"},{"line_number":1227,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":1228,"context_line":"                     allowed_origin\u003d[\u0027https://horizon.example.com\u0027],"},{"line_number":1229,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":1230,"context_line":"                                    \u0027X-Openstack-Request-Id\u0027,"},{"line_number":1231,"context_line":"                                    \u0027X-Subject-Token\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_094d0dc4","line":1228,"in_reply_to":"9aed3d3a_cf123bb4","updated":"2016-02-29 05:59:15.000000000","message":"the sample config should mirror the actual defaults.\n\nPlease do not use bogus values here that are not actually the default values in reality (or planned default values)","commit_id":"2abf199f893959f8c68435e58a856c51c0db76a4"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7554ff0bc8501c598b136a40c47c5aca1cfece79","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"def set_middleware_defaults():"},{"line_number":1225,"context_line":"    \"\"\"Update default configuration options for oslo.middleware.\"\"\""},{"line_number":1226,"context_line":"    # CORS Defaults"},{"line_number":1227,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":1228,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":1229,"context_line":"                                    \u0027X-Openstack-Request-Id\u0027,"},{"line_number":1230,"context_line":"                                    \u0027X-Subject-Token\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_4338683d","line":1227,"updated":"2016-02-29 19:14:26.000000000","message":"oslo_middleware.cors should provide a function for this. I\u0027m worried that the config option names will change or move to another section name option name.","commit_id":"5ab7717ede45ca16b440d08c042b422b2aa2da67"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"16bd8691a1c56204458a73f93d9e0a1f3bed3f74","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"def set_middleware_defaults():"},{"line_number":1225,"context_line":"    \"\"\"Update default configuration options for oslo.middleware.\"\"\""},{"line_number":1226,"context_line":"    # CORS Defaults"},{"line_number":1227,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":1228,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":1229,"context_line":"                                    \u0027X-Openstack-Request-Id\u0027,"},{"line_number":1230,"context_line":"                                    \u0027X-Subject-Token\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_46b4f180","line":1227,"in_reply_to":"9aed3d3a_4338683d","updated":"2016-02-29 21:20:38.000000000","message":"....says the man who -2\u0027d the patch that adds this feature ;)\n\nhttps://review.openstack.org/#/c/285368/","commit_id":"5ab7717ede45ca16b440d08c042b422b2aa2da67"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"4942be54ab7f77bfdfa6d093edc230e28151b087","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"def set_middleware_defaults():"},{"line_number":1225,"context_line":"    \"\"\"Update default configuration options for oslo.middleware.\"\"\""},{"line_number":1226,"context_line":"    # CORS Defaults"},{"line_number":1227,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":1228,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":1229,"context_line":"                                    \u0027X-Openstack-Request-Id\u0027,"},{"line_number":1230,"context_line":"                                    \u0027X-Subject-Token\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_a68b3d67","line":1227,"in_reply_to":"9aed3d3a_4338683d","updated":"2016-02-29 21:08:14.000000000","message":"A valid concern. this may be something that has to be a followup when CORS/oslo middleware supports it.","commit_id":"5ab7717ede45ca16b440d08c042b422b2aa2da67"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8ecedf08bfdd04311a188a2b700ce122d32f6337","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"def set_middleware_defaults():"},{"line_number":1225,"context_line":"    \"\"\"Update default configuration options for oslo.middleware.\"\"\""},{"line_number":1226,"context_line":"    # CORS Defaults"},{"line_number":1227,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":1228,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":1229,"context_line":"                                    \u0027X-Openstack-Request-Id\u0027,"},{"line_number":1230,"context_line":"                                    \u0027X-Subject-Token\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_a9182e76","line":1227,"in_reply_to":"9aed3d3a_46b4f180","updated":"2016-02-29 21:23:43.000000000","message":"I\u0027m ok with the code working like this. We can update in N.","commit_id":"5ab7717ede45ca16b440d08c042b422b2aa2da67"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"882b5c58276bc9ed64eb21e9ff03bb6571d41ae6","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"def set_middleware_defaults():"},{"line_number":1225,"context_line":"    \"\"\"Update default configuration options for oslo.middleware.\"\"\""},{"line_number":1226,"context_line":"    # CORS Defaults"},{"line_number":1227,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":1228,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":1229,"context_line":"                                    \u0027X-Openstack-Request-Id\u0027,"},{"line_number":1230,"context_line":"                                    \u0027X-Subject-Token\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_c98e5278","line":1227,"in_reply_to":"9aed3d3a_a9182e76","updated":"2016-02-29 21:27:49.000000000","message":"You got it :). I\u0027ll add a todo comment in the next revision.","commit_id":"5ab7717ede45ca16b440d08c042b422b2aa2da67"}]}