)]}'
{"keystone/common/config.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f1d5ee4d9961167300a02c044c3847213fa0d1d0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                   help\u003d\u0027Maximum depth of the project hierarchy. WARNING: \u0027"},{"line_number":82,"context_line":"                        \u0027setting it to a large value may adversely impact \u0027"},{"line_number":83,"context_line":"                        \u0027performance.\u0027),"},{"line_number":84,"context_line":"        cfg.IntOpt(\u0027max_param_size\u0027, default\u003d64,"},{"line_number":85,"context_line":"                   help\u003d\u0027Limit the sizes of user \u0026 project ID/names.\u0027),"},{"line_number":86,"context_line":"        # we allow tokens to be a bit larger to accommodate PKI"},{"line_number":87,"context_line":"        cfg.IntOpt(\u0027max_token_size\u0027, default\u003d8192,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_3f04dc7c","side":"PARENT","line":84,"updated":"2016-03-01 20:33:28.000000000","message":"Why can\u0027t this just be changed to 255 instead if introducing another config option? The purpose of both seem very similar.","commit_id":"8c4a19300a0fb905b032fb0fb45df067d1b4bbab"}],"keystone/tests/unit/test_auth.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"a675ee562bf1d218e8e1cdc47183be3263b6506c","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    def test_authenticate_tenant_id_too_large(self):"},{"line_number":197,"context_line":"        \"\"\"Verify sending large \u0027tenantId\u0027 raises the right exception.\"\"\""},{"line_number":198,"context_line":"        body_dict \u003d _build_user_auth(username\u003d\u0027FOO\u0027, password\u003d\u0027foo2\u0027,"},{"line_number":199,"context_line":"                                     tenant_id\u003d\u00270\u0027 * (CONF.max_param_size + 1))"},{"line_number":200,"context_line":"        self.assertRaises(exception.ValidationSizeError,"},{"line_number":201,"context_line":"                          self.controller.authenticate,"},{"line_number":202,"context_line":"                          {}, body_dict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_b53bf4ea","line":199,"range":{"start_line":199,"start_character":53,"end_line":199,"end_character":78},"updated":"2016-03-07 18:16:32.000000000","message":"thought the change was only for \"username\"","commit_id":"548af6c27e6a8b78459478739188db0fe60112c5"}],"keystone/token/controllers.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"a675ee562bf1d218e8e1cdc47183be3263b6506c","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        username \u003d auth[\u0027passwordCredentials\u0027].get(\u0027username\u0027, \u0027\u0027)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if username:"},{"line_number":288,"context_line":"            if len(username) \u003e 255:"},{"line_number":289,"context_line":"                raise exception.ValidationSizeError(attribute\u003d\u0027username\u0027,"},{"line_number":290,"context_line":"                                                    size\u003d255)"},{"line_number":291,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_b56db406","line":288,"range":{"start_line":288,"start_character":31,"end_line":288,"end_character":34},"updated":"2016-03-07 18:16:32.000000000","message":"don\u0027t use a magic number here, it should be a constant with a meaningful name and with some comments to explain it","commit_id":"548af6c27e6a8b78459478739188db0fe60112c5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"03f5475e854ae1286de0c4e85805c57e4c6c8ac8","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        if username:"},{"line_number":288,"context_line":"            if len(username) \u003e CONF.max_param_size:"},{"line_number":289,"context_line":"                raise exception.ValidationSizeError(attribute\u003d\u0027username\u0027,"},{"line_number":290,"context_line":"                                                    size\u003dCONF.max_param_size)"},{"line_number":291,"context_line":"            try:"},{"line_number":292,"context_line":"                user_ref \u003d self.identity_api.get_user_by_name("},{"line_number":293,"context_line":"                    username, CONF.identity.default_domain_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_1841f8a9","side":"PARENT","line":290,"updated":"2016-04-05 21:41:19.000000000","message":"If we\u0027re not going to be using this anymore, we should deprecate the configuration option. Otherwise operators will be setting this and it won\u0027t take effect because we\u0027re ignoring it.","commit_id":"2445d24efacd4c5f96174b3bf1028bf5770f7bab"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"8bde5fda766cefb90e8eb6bb2d9504676af0882a","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    pass"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"MAX_USERNAME_SIZE \u003d 255  # Value used for validation of the username attribute"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"@dependency.requires(\u0027assignment_api\u0027, \u0027catalog_api\u0027, \u0027identity_api\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_830f99e0","line":44,"range":{"start_line":44,"start_character":25,"end_line":44,"end_character":78},"updated":"2016-03-07 20:39:42.000000000","message":"maybe cite the db schema here","commit_id":"cee735486c07dd474b837ef0be5c3323261fc6bb"}]}