)]}'
{"id":"openstack%2Fkeystone~28657","triplet_id":"openstack%2Fkeystone~master~I890415c755dd383749f2d4382f53d0b3a6badc6c","project":"openstack/keystone","branch":"master","topic":"bug/1166697","hashtags":[],"change_id":"I890415c755dd383749f2d4382f53d0b3a6badc6c","subject":"A minor refactor in wsgi.py","status":"MERGED","created":"2013-05-09 06:02:29.000000000","updated":"2013-05-09 21:05:21.000000000","submitted":"2013-05-09 21:05:20.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b61d7450a7541c95e7e18f652d65dc0235b4f9c2","_number":28657,"virtual_id_number":28657,"owner":{"_account_id":6526,"name":"David Geng","email":"gengjh@cn.ibm.com","username":"genggjh"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6526,"name":"David Geng","email":"gengjh@cn.ibm.com","username":"genggjh"},{"value":0,"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":1,"date":"2013-05-09 07:40:31.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2013-05-09 21:05:20.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"all":[{"value":0,"_account_id":6526,"name":"David Geng","email":"gengjh@cn.ibm.com","username":"genggjh"},{"value":0,"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},{"value":2,"date":"2013-05-09 07:17:29.000000000","_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2013-05-09 20:18:30.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"date":"2013-05-09 06:19:00.000000000","_account_id":6526,"name":"David Geng","email":"gengjh@cn.ibm.com","username":"genggjh"},{"value":0,"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},{"value":0,"date":"2013-05-09 07:17:29.000000000","_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2013-05-09 20:18:30.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":6526,"name":"David Geng","email":"gengjh@cn.ibm.com","username":"genggjh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-09 06:15:11.000000000","updated_by":{"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},"reviewer":{"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},"state":"REVIEWER"},{"updated":"2013-05-09 07:17:29.000000000","updated_by":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"reviewer":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"state":"REVIEWER"},{"updated":"2013-05-09 07:40:31.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-05-09 20:18:30.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2013-05-09 21:05:20.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"64db7ec36bd9d31529e682c0b937428fd4f7129c","author":{"_account_id":6526,"name":"David Geng","email":"gengjh@cn.ibm.com","username":"genggjh"},"date":"2013-05-09 06:19:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"dd94eed71c035889fbf9c29597ce64ef95d88539","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-05-09 06:19:08.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"955fe80cadc17cd2667f580b088185e7ecc79a1f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-09 07:16:16.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/28657/2/check/gate-keystone-pep8/4967 : SUCCESS in 00:01:09\n- http://docs-draft.openstack.org/28657/2/check/gate-keystone-docs/3341/doc/build/html/ : SUCCESS in 00:01:58\n- http://logs.openstack.org/28657/2/check/gate-keystone-python26/3861 : SUCCESS in 00:09:23\n- http://logs.openstack.org/28657/2/check/gate-keystone-python26-centos6/98 : FAILURE in 00:06:58 (non-voting)\n- http://logs.openstack.org/28657/2/check/gate-keystone-python27/3873 : SUCCESS in 00:05:41\n- http://logs.openstack.org/28657/2/check/gate-tempest-devstack-vm-full/15182 : SUCCESS in 00:44:21\n- http://logs.openstack.org/28657/2/check/gate-tempest-devstack-vm-postgres-full/14897 : FAILURE in 00:56:53 (non-voting)\n- http://logs.openstack.org/28657/2/check/gate-tempest-devstack-vm-quantum/21436 : SUCCESS in 00:22:04\n- http://logs.openstack.org/28657/2/check/gate-grenade-devstack-vm/2924 : SUCCESS in 00:14:12 (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"cbe5bfd0b6a2ae8325561419f139a4a2f9e3d8dd","author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"date":"2013-05-09 07:17:29.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nThanks for following up and doing this so quickly.","accounts_in_message":[],"_revision_number":2},{"id":"534d5ebeb89a7adb7eefa9af7d82c8c16ac3eb46","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-05-09 07:40:31.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/85933\n","accounts_in_message":[],"_revision_number":2},{"id":"1f70c96a0d3dfc3d401fe8f9669153514587432f","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-05-09 20:18:30.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nThis is just moving code around, so looks good.","accounts_in_message":[],"_revision_number":2},{"id":"fb29cfb516099fa294f25f6025ed34008436bcbe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-09 20:18:32.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"d963a8fecd53ade1a0397c490f5eeda180eb1828","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-09 21:05:20.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/28657/2/gate/gate-keystone-docs/3354/doc/build/html/ : SUCCESS in 00:01:55\n- http://logs.openstack.org/28657/2/gate/gate-keystone-pep8/4980 : SUCCESS in 00:01:06\n- http://logs.openstack.org/28657/2/gate/gate-keystone-python26/3874 : SUCCESS in 00:08:05\n- http://logs.openstack.org/28657/2/gate/gate-keystone-python27/3886 : SUCCESS in 00:05:49\n- http://logs.openstack.org/28657/2/gate/gate-tempest-devstack-vm-full/15285 : SUCCESS in 00:44:43\n- http://logs.openstack.org/28657/2/gate/gate-tempest-devstack-vm-postgres-full/15000 : FAILURE in 00:46:37 (non-voting)\n- http://logs.openstack.org/28657/2/gate/gate-tempest-devstack-vm-quantum/21561 : SUCCESS in 00:21:31\n- http://logs.openstack.org/28657/2/gate/gate-grenade-devstack-vm/3019 : FAILURE in 00:10:02 (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"c469d21999c84b648ee5626ed53d4f34dbea8cc5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-09 21:05:21.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"13f8dc829f6a2cadfc8dbcf88c1d632558531e6c","revisions":{"f7536dc7a9b8b2bcec561272546ac3dce175a2d3":{"kind":"REWORK","_number":1,"created":"2013-05-09 06:02:29.000000000","uploader":{"_account_id":6526,"name":"David Geng","email":"gengjh@cn.ibm.com","username":"genggjh"},"ref":"refs/changes/57/28657/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/57/28657/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/57/28657/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/57/28657/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/57/28657/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/57/28657/1"}}},"commit":{"parents":[{"commit":"bb401047200b4bc3fa12220782b8e036c557282c","subject":"Merge \"Replace password to \"***\" in the debug message\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/bb401047200b4bc3fa12220782b8e036c557282c"}]}],"author":{"name":"gengjh","email":"gengjh@cn.ibm.com","date":"2013-05-09 05:54:27.000000000","tz":480},"committer":{"name":"gengjh","email":"gengjh@cn.ibm.com","date":"2013-05-09 05:55:28.000000000","tz":480},"subject":"a minor refactor in wsgi.py","message":"a minor refactor in wsgi.py\n\na minor refactor to move the code up in the file as suggested by termie\nand henry regarding the review comments in\nhttps://review.openstack.org/#/c/26487/\n\nFix bug 1166697\n\nChange-Id: I890415c755dd383749f2d4382f53d0b3a6badc6c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/f7536dc7a9b8b2bcec561272546ac3dce175a2d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/f7536dc7a9b8b2bcec561272546ac3dce175a2d3"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"bb401047200b4bc3fa12220782b8e036c557282c","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"13f8dc829f6a2cadfc8dbcf88c1d632558531e6c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-05-09 06:19:00.000000000","uploader":{"_account_id":6526,"name":"David Geng","email":"gengjh@cn.ibm.com","username":"genggjh"},"ref":"refs/changes/57/28657/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/57/28657/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/57/28657/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/57/28657/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/57/28657/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/57/28657/2"}}},"commit":{"parents":[{"commit":"bb401047200b4bc3fa12220782b8e036c557282c","subject":"Merge \"Replace password to \"***\" in the debug message\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/bb401047200b4bc3fa12220782b8e036c557282c"}]}],"author":{"name":"gengjh","email":"gengjh@cn.ibm.com","date":"2013-05-09 05:54:27.000000000","tz":480},"committer":{"name":"gengjh","email":"gengjh@cn.ibm.com","date":"2013-05-09 06:14:18.000000000","tz":480},"subject":"A minor refactor in wsgi.py","message":"A minor refactor in wsgi.py\n\nA minor refactor to move the code up in the file as suggested by termie\nand henry regarding the review comments in\nhttps://review.openstack.org/#/c/26487/\n\nFix bug 1166697\n\nChange-Id: I890415c755dd383749f2d4382f53d0b3a6badc6c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/13f8dc829f6a2cadfc8dbcf88c1d632558531e6c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/13f8dc829f6a2cadfc8dbcf88c1d632558531e6c"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"bb401047200b4bc3fa12220782b8e036c557282c","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
