)]}'
{"keystone/resource/core.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"686f16708dd0018eb10259188ea447f1b49465c0","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"    def create_project(self, project_id, project):"},{"line_number":1243,"context_line":"        \"\"\"Creates a new project."},{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"        :param project_id: This parameter can be ignored."},{"line_number":1246,"context_line":"        :param dict project: The new project"},{"line_number":1247,"context_line":""},{"line_number":1248,"context_line":"        Project schema::"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_3c392da5","line":1245,"range":{"start_line":1245,"start_character":27,"end_line":1245,"end_character":56},"updated":"2016-03-09 10:46:09.000000000","message":"nit: the wording is inconsistent between the v9 and v8 doc strings:\n\nThis parameter is ignored vs This parameter can be ignored","commit_id":"8220cb731391749f187c01c9d02485e00c965ceb"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4d9da11b0f07351076bdfe4b51785687e6db8c20","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"    def create_project(self, project_id, project):"},{"line_number":1243,"context_line":"        \"\"\"Creates a new project."},{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"        :param project_id: This parameter can be ignored."},{"line_number":1246,"context_line":"        :param dict project: The new project"},{"line_number":1247,"context_line":""},{"line_number":1248,"context_line":"        Project schema::"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_0f54e31e","line":1245,"range":{"start_line":1245,"start_character":27,"end_line":1245,"end_character":56},"in_reply_to":"5aef4532_3c392da5","updated":"2016-03-09 14:24:21.000000000","message":"Done","commit_id":"8220cb731391749f187c01c9d02485e00c965ceb"}],"keystone/tests/unit/backend/legacy_drivers/resource/V8/sql.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"90950284c02121facc7e69d34c806ece4b9aaffd","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.driver \u003d sql.Resource()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @unittest.skip(\u0027Null domain not allowed.\u0027)"},{"line_number":70,"context_line":"    def test_create_project_null_domain(self):"},{"line_number":71,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_ead08e21","line":70,"range":{"start_line":70,"start_character":4,"end_line":70,"end_character":45},"updated":"2016-03-09 12:29:27.000000000","message":"shouldn\u0027t this test be written to fail?","commit_id":"8220cb731391749f187c01c9d02485e00c965ceb"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4d9da11b0f07351076bdfe4b51785687e6db8c20","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.driver \u003d sql.Resource()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @unittest.skip(\u0027Null domain not allowed.\u0027)"},{"line_number":70,"context_line":"    def test_create_project_null_domain(self):"},{"line_number":71,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_6f1ac77e","line":70,"range":{"start_line":70,"start_character":4,"end_line":70,"end_character":45},"in_reply_to":"5aef4532_ead08e21","updated":"2016-03-09 14:24:21.000000000","message":"No, because we don\u0027t know what the driver is going to do. It might work or it might fail. The SQL driver will fail, but if somebody writes their own driver it might work.","commit_id":"8220cb731391749f187c01c9d02485e00c965ceb"}],"keystone/tests/unit/resource/test_backends.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"90950284c02121facc7e69d34c806ece4b9aaffd","unresolved":false,"context_lines":[{"line_number":1629,"context_line":"        }"},{"line_number":1630,"context_line":"        self.driver.create_project(project_id, project)"},{"line_number":1631,"context_line":""},{"line_number":1632,"context_line":"    def test_create_project_same_name_same_domain_conflict(self):"},{"line_number":1633,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":1634,"context_line":"        domain_id \u003d uuid.uuid4().hex"},{"line_number":1635,"context_line":""},{"line_number":1636,"context_line":"        project_id \u003d uuid.uuid4().hex"},{"line_number":1637,"context_line":"        project \u003d {"},{"line_number":1638,"context_line":"            \u0027name\u0027: name,"},{"line_number":1639,"context_line":"            \u0027id\u0027: project_id,"},{"line_number":1640,"context_line":"            \u0027domain_id\u0027: domain_id,"},{"line_number":1641,"context_line":"        }"},{"line_number":1642,"context_line":"        self.driver.create_project(project_id, project)"},{"line_number":1643,"context_line":""},{"line_number":1644,"context_line":"        project_id \u003d uuid.uuid4().hex"},{"line_number":1645,"context_line":"        project \u003d {"},{"line_number":1646,"context_line":"            \u0027name\u0027: name,"},{"line_number":1647,"context_line":"            \u0027id\u0027: project_id,"},{"line_number":1648,"context_line":"            \u0027domain_id\u0027: domain_id,"},{"line_number":1649,"context_line":"        }"},{"line_number":1650,"context_line":"        self.assertRaises(exception.Conflict, self.driver.create_project,"},{"line_number":1651,"context_line":"                          project_id, project)"},{"line_number":1652,"context_line":""},{"line_number":1653,"context_line":"    def test_create_project_same_id_conflict(self):"},{"line_number":1654,"context_line":"        project_id \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_ea56ce5a","line":1651,"range":{"start_line":1632,"start_character":0,"end_line":1651,"end_character":46},"updated":"2016-03-09 12:29:27.000000000","message":"there is already a test for this behavior (and some others including the domain_id update): https://github.com/openstack/keystone/blob/master/keystone/tests/unit/resource/test_backends.py#L91-L100\n\nI guess it is better to rename the existing test","commit_id":"8220cb731391749f187c01c9d02485e00c965ceb"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"4f1ff0170ffca6f629ae6d640ec13c2ffd64e015","unresolved":false,"context_lines":[{"line_number":1629,"context_line":"        }"},{"line_number":1630,"context_line":"        self.driver.create_project(project_id, project)"},{"line_number":1631,"context_line":""},{"line_number":1632,"context_line":"    def test_create_project_same_name_same_domain_conflict(self):"},{"line_number":1633,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":1634,"context_line":"        domain_id \u003d uuid.uuid4().hex"},{"line_number":1635,"context_line":""},{"line_number":1636,"context_line":"        project_id \u003d uuid.uuid4().hex"},{"line_number":1637,"context_line":"        project \u003d {"},{"line_number":1638,"context_line":"            \u0027name\u0027: name,"},{"line_number":1639,"context_line":"            \u0027id\u0027: project_id,"},{"line_number":1640,"context_line":"            \u0027domain_id\u0027: domain_id,"},{"line_number":1641,"context_line":"        }"},{"line_number":1642,"context_line":"        self.driver.create_project(project_id, project)"},{"line_number":1643,"context_line":""},{"line_number":1644,"context_line":"        project_id \u003d uuid.uuid4().hex"},{"line_number":1645,"context_line":"        project \u003d {"},{"line_number":1646,"context_line":"            \u0027name\u0027: name,"},{"line_number":1647,"context_line":"            \u0027id\u0027: project_id,"},{"line_number":1648,"context_line":"            \u0027domain_id\u0027: domain_id,"},{"line_number":1649,"context_line":"        }"},{"line_number":1650,"context_line":"        self.assertRaises(exception.Conflict, self.driver.create_project,"},{"line_number":1651,"context_line":"                          project_id, project)"},{"line_number":1652,"context_line":""},{"line_number":1653,"context_line":"    def test_create_project_same_id_conflict(self):"},{"line_number":1654,"context_line":"        project_id \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_4a38a2ef","line":1651,"range":{"start_line":1632,"start_character":0,"end_line":1651,"end_character":46},"in_reply_to":"5aef4532_ea56ce5a","updated":"2016-03-09 12:30:58.000000000","message":"sorry, noticed these tests are calling the driver directly - don\u0027t consider the comment above.","commit_id":"8220cb731391749f187c01c9d02485e00c965ceb"}]}