)]}'
{"keystone/tests/unit/resource/test_core.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"564f373bc3eabc3271ae2b9d2964c9a3f3eb188d","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def setUp(self):"},{"line_number":101,"context_line":"        self.domain \u003d unit.new_domain_ref()"},{"line_number":102,"context_line":"        self.resource_api.create_domain(self.domain[\u0027id\u0027], self.domain)"},{"line_number":103,"context_line":"        self.addCleanup(self.clean_up_domain)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def clean_up_domain(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_2e54381f","line":102,"updated":"2016-03-09 16:24:50.000000000","message":"driver tests shouldn\u0027t need any managers.\n\nThis applies to all these tests. They should be able to use self.driver.create_config_option(), etc.","commit_id":"e0790a9652da4fdc4ea41b3192585edd073d8f1c"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"914c869ae60780eca105fd8b4531e87f1a6469c0","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def setUp(self):"},{"line_number":101,"context_line":"        self.domain \u003d unit.new_domain_ref()"},{"line_number":102,"context_line":"        self.resource_api.create_domain(self.domain[\u0027id\u0027], self.domain)"},{"line_number":103,"context_line":"        self.addCleanup(self.clean_up_domain)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def clean_up_domain(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_c9b2ee05","line":102,"in_reply_to":"5aef4532_2e54381f","updated":"2016-03-09 16:29:38.000000000","message":"so agree with you for the driver api under test (in this case domain_config), so the tests below should be changed. create-domain() is not part of that api, so I would think this line is OK (as it is part of setup needed to execute the actual driver tests)","commit_id":"e0790a9652da4fdc4ea41b3192585edd073d8f1c"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e23a4228475a165765276cf18400007399676624","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def setUp(self):"},{"line_number":101,"context_line":"        self.domain \u003d unit.new_domain_ref()"},{"line_number":102,"context_line":"        self.resource_api.create_domain(self.domain[\u0027id\u0027], self.domain)"},{"line_number":103,"context_line":"        self.addCleanup(self.clean_up_domain)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def clean_up_domain(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_31013c39","line":102,"in_reply_to":"5aef4532_c9b2ee05","updated":"2016-03-09 16:43:54.000000000","message":"How can it be required that there\u0027s a driver in the resource backend for the domain_config backend to work? what if resource driver is not sql?","commit_id":"e0790a9652da4fdc4ea41b3192585edd073d8f1c"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"d7b89d872b54b335883c331c2b7850f07e1af58d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"class DomainConfigDriverTests(object):"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def setUp(self):"},{"line_number":101,"context_line":"        self.domain \u003d {\u0027id\u0027: uuid.uuid4().hex}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _domain_config_crud(self, sensitive):"},{"line_number":104,"context_line":"        domain \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_60748867","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":46},"updated":"2016-03-09 17:31:04.000000000","message":"oops, should remove this","commit_id":"e6069b89a2579c07c61efd18df5787da6229421a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"be27e59b1fdc008d86fe4d3ce9bcf80ed5cb5205","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        config_whitelisted \u003d copy.deepcopy(config)"},{"line_number":274,"context_line":"        config_whitelisted[\u0027ldap\u0027].pop(\u0027password\u0027)"},{"line_number":275,"context_line":"        self.assertEqual(config_whitelisted, res)"},{"line_number":276,"context_line":"        res \u003d self.domain_config_api.driver.get_config_option("},{"line_number":277,"context_line":"            self.domain[\u0027id\u0027], \u0027ldap\u0027, \u0027password\u0027, sensitive\u003dTrue)"},{"line_number":278,"context_line":"        self.assertEqual(config[\u0027ldap\u0027][\u0027password\u0027], res[\u0027value\u0027])"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_c89db067","line":276,"updated":"2016-03-10 00:05:37.000000000","message":"why change this?","commit_id":"21941ac3dbcbde7bc5976475bbcf81337c4dfb73"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"1fa68ff903074a8fbc6f7eef601d9d99dade3dc6","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        config_whitelisted \u003d copy.deepcopy(config)"},{"line_number":274,"context_line":"        config_whitelisted[\u0027ldap\u0027].pop(\u0027password\u0027)"},{"line_number":275,"context_line":"        self.assertEqual(config_whitelisted, res)"},{"line_number":276,"context_line":"        res \u003d self.domain_config_api.driver.get_config_option("},{"line_number":277,"context_line":"            self.domain[\u0027id\u0027], \u0027ldap\u0027, \u0027password\u0027, sensitive\u003dTrue)"},{"line_number":278,"context_line":"        self.assertEqual(config[\u0027ldap\u0027][\u0027password\u0027], res[\u0027value\u0027])"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_b5ae9d2b","line":276,"in_reply_to":"5aef4532_c89db067","updated":"2016-03-10 14:33:25.000000000","message":"so there is no manager call get_config_option(), so was just making in clear that this was a driver call to check where the data was actually being stored.","commit_id":"21941ac3dbcbde7bc5976475bbcf81337c4dfb73"}]}