)]}'
{"keystone/common/sql/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"efbb28f1a4f3d1676bbb566b4d8006d174332b35","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        self._sessionmaker \u003d self._sessionmaker or self.get_sessionmaker("},{"line_number":222,"context_line":"            self._engine)"},{"line_number":223,"context_line":"        return self._sessionmaker(autocommit\u003dautocommit,"},{"line_number":224,"context_line":"                                  expire_on_commit\u003dexpire_on_commit)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def get_engine(self, allow_global_engine\u003dTrue):"},{"line_number":227,"context_line":"        \"\"\"Return a SQLAlchemy engine."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F8RM%3D","line":224,"updated":"2013-05-16 16:08:44.000000000","message":"(NIT) this is really pick but should the indentation of \u0027expire...\u0027 be on the same level as \u0027autocommit..\u0027 on the line above?","commit_id":"4e0cfb12f75da943d168d9c4889837498ac06292"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5e2ed389eee11bc835a3723f168ef70204d0e9f4","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        self._sessionmaker \u003d self._sessionmaker or self.get_sessionmaker("},{"line_number":222,"context_line":"            self._engine)"},{"line_number":223,"context_line":"        return self._sessionmaker(autocommit\u003dautocommit,"},{"line_number":224,"context_line":"                                  expire_on_commit\u003dexpire_on_commit)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def get_engine(self, allow_global_engine\u003dTrue):"},{"line_number":227,"context_line":"        \"\"\"Return a SQLAlchemy engine."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F8LU%3D","line":224,"in_reply_to":"AAAAO3%2F%2F8PQ%3D","updated":"2013-05-16 16:34:55.000000000","message":"gotcha, good to know. Just wanted to make sure. Thanks!","commit_id":"4e0cfb12f75da943d168d9c4889837498ac06292"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"55926a2605433809f1845f4200f8b196b1590133","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        self._sessionmaker \u003d self._sessionmaker or self.get_sessionmaker("},{"line_number":222,"context_line":"            self._engine)"},{"line_number":223,"context_line":"        return self._sessionmaker(autocommit\u003dautocommit,"},{"line_number":224,"context_line":"                                  expire_on_commit\u003dexpire_on_commit)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def get_engine(self, allow_global_engine\u003dTrue):"},{"line_number":227,"context_line":"        \"\"\"Return a SQLAlchemy engine."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F8PQ%3D","line":224,"in_reply_to":"AAAAO3%2F%2F8RM%3D","updated":"2013-05-16 16:16:44.000000000","message":"it is; gerrit sucks at rendering monospace fonts","commit_id":"4e0cfb12f75da943d168d9c4889837498ac06292"},{"author":{"_account_id":5971,"name":"nachiappan-veerappan-nachiappan","email":"nachiappan_vrn@yahoo.com","username":"nachiappan-veerappan-nachiappan"},"change_message_id":"8a671f89a282b6f66327b72aede5072fe66f3204","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        self._sessionmaker \u003d self._sessionmaker or self.get_sessionmaker("},{"line_number":216,"context_line":"            self._engine)"},{"line_number":217,"context_line":"        return self._sessionmaker(autocommit\u003dautocommit,"},{"line_number":218,"context_line":"                                  expire_on_commit\u003dexpire_on_commit)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def get_engine(self, allow_global_engine\u003dTrue):"},{"line_number":221,"context_line":"        \"\"\"Return a SQLAlchemy engine."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2F2BA%3D","line":218,"updated":"2013-06-19 22:27:30.000000000","message":"should this instance variable be called as _session instead of _sessionmaker. As sessionmaker factory generates new Session objects when called.","commit_id":"02fefdf434c9f3ccd0b2fe95645d58065dbae0ce"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"f4b2e5d7b7fd38378d40355af1412300e4eb4074","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        self._sessionmaker \u003d self._sessionmaker or self.get_sessionmaker("},{"line_number":216,"context_line":"            self._engine)"},{"line_number":217,"context_line":"        return self._sessionmaker(autocommit\u003dautocommit,"},{"line_number":218,"context_line":"                                  expire_on_commit\u003dexpire_on_commit)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def get_engine(self, allow_global_engine\u003dTrue):"},{"line_number":221,"context_line":"        \"\"\"Return a SQLAlchemy engine."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FVLQ%3D","line":218,"in_reply_to":"AAAAPn%2F%2F2BA%3D","updated":"2013-07-03 21:26:39.000000000","message":"if you are suggesting a change, I\u0027m not sure what it is. Please clarify.","commit_id":"02fefdf434c9f3ccd0b2fe95645d58065dbae0ce"},{"author":{"_account_id":5971,"name":"nachiappan-veerappan-nachiappan","email":"nachiappan_vrn@yahoo.com","username":"nachiappan-veerappan-nachiappan"},"change_message_id":"d55e70e4bf30ae9eaf946f0e470c8128b29086b0","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        self._sessionmaker \u003d self._sessionmaker or self.get_sessionmaker("},{"line_number":216,"context_line":"            self._engine)"},{"line_number":217,"context_line":"        return self._sessionmaker(autocommit\u003dautocommit,"},{"line_number":218,"context_line":"                                  expire_on_commit\u003dexpire_on_commit)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def get_engine(self, allow_global_engine\u003dTrue):"},{"line_number":221,"context_line":"        \"\"\"Return a SQLAlchemy engine."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FVII%3D","line":218,"in_reply_to":"AAAAPn%2F%2FVLQ%3D","updated":"2013-07-03 21:51:28.000000000","message":"I had a question reading the sqlalchemy.orm.sessionmaker api doc whether the call\nself._sessionmaker \u003d self._sessionmaker or self.get_sessionmaker(\nself._engine)\n\nreturns a factory or session object. Now after re-reading the documentation, I understand that it returns a factory. There is no change required. Code looks good.","commit_id":"02fefdf434c9f3ccd0b2fe95645d58065dbae0ce"}],"tests/test_sql_core.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"64fe7a355d1072d3f904c2e44603380c27fb421a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        # to the session created."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        base \u003d sql.Base()"},{"line_number":27,"context_line":"        session1 \u003d base.get_session(autocommit\u003dFalse, expire_on_commit\u003dTrue)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        self.assertFalse(session1.autocommit)"},{"line_number":30,"context_line":"        self.assertTrue(session1.expire_on_commit)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FtEw%3D","line":27,"updated":"2013-05-24 22:34:11.000000000","message":"why session1? just call it `session`","commit_id":"160780b18e6b78c725e16272f6e6b83f7b1fdd99"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a336f7dbf053ffc4bc53e5f54e081c99e16791d2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        # to the session created."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        base \u003d sql.Base()"},{"line_number":27,"context_line":"        session1 \u003d base.get_session(autocommit\u003dFalse, expire_on_commit\u003dTrue)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        self.assertFalse(session1.autocommit)"},{"line_number":30,"context_line":"        self.assertTrue(session1.expire_on_commit)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Flds%3D","line":27,"in_reply_to":"AAAAPH%2F%2FtEw%3D","updated":"2013-05-29 22:03:05.000000000","message":"Done","commit_id":"160780b18e6b78c725e16272f6e6b83f7b1fdd99"}]}