)]}'
{"keystone/common/sql/core.py":[{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"a96446028e7d8771527134ff4419318770717a65","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        # auto-build the db to support wsgi server w/ in-memory backend"},{"line_number":254,"context_line":"        if CONF.sql.connection \u003d\u003d \u0027sqlite://\u0027:"},{"line_number":255,"context_line":"            ModelBase.metadata.create_all(bind\u003dengine)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        set_global_engine(engine)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2Fw6Q%3D","line":255,"updated":"2013-05-23 15:44:46.000000000","message":"Hi Brant, question - if allow_global_engine is true and GLOBLE_ENGINE was found, then above check will never be executed - is that not needed?","commit_id":"d56bbde214e5eef27484fb758f68c4f7f2f9ba09"},{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"d724526712eb8394ef53b9ce53c50aeaf664fbd7","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        # auto-build the db to support wsgi server w/ in-memory backend"},{"line_number":254,"context_line":"        if CONF.sql.connection \u003d\u003d \u0027sqlite://\u0027:"},{"line_number":255,"context_line":"            ModelBase.metadata.create_all(bind\u003dengine)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        set_global_engine(engine)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2FjLY%3D","line":255,"in_reply_to":"AAAAPH%2F%2FjVw%3D","updated":"2013-05-30 18:53:49.000000000","message":"OK, sounds fair. Thanks!","commit_id":"d56bbde214e5eef27484fb758f68c4f7f2f9ba09"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"93216b992c20472fd5b184a05428f985703e2d8b","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        # auto-build the db to support wsgi server w/ in-memory backend"},{"line_number":254,"context_line":"        if CONF.sql.connection \u003d\u003d \u0027sqlite://\u0027:"},{"line_number":255,"context_line":"            ModelBase.metadata.create_all(bind\u003dengine)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        set_global_engine(engine)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2FjVw%3D","line":255,"in_reply_to":"AAAAPH%2F%2FlG0%3D","updated":"2013-05-30 17:44:50.000000000","message":"I changed my mind on this. It\u0027s working as designed. GLOBAL_ENGINE will only be set if we\u0027ve gone through this code before, in which case we would have created the tables.\n\nAlso, if you check the original version of the code, create_all() was only done if allow_global_engine, so I don\u0027t want to change the behavior so that the tables are created even when not allow_global_engine.\n\nI can\u0027t say that I totally understand the intent of the original code... it makes no sense to me, but that\u0027s how it worked.","commit_id":"d56bbde214e5eef27484fb758f68c4f7f2f9ba09"},{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"860d3553aaacfe5627bff6c4df20eaffab11999b","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        # auto-build the db to support wsgi server w/ in-memory backend"},{"line_number":254,"context_line":"        if CONF.sql.connection \u003d\u003d \u0027sqlite://\u0027:"},{"line_number":255,"context_line":"            ModelBase.metadata.create_all(bind\u003dengine)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        set_global_engine(engine)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2FlG0%3D","line":255,"in_reply_to":"AAAAPH%2F%2FlHo%3D","updated":"2013-05-30 02:30:39.000000000","message":"OK, sounds good. Thanks, Brant!","commit_id":"d56bbde214e5eef27484fb758f68c4f7f2f9ba09"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"3dc774720ca6d1d283095014ff032b6208357390","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        # auto-build the db to support wsgi server w/ in-memory backend"},{"line_number":254,"context_line":"        if CONF.sql.connection \u003d\u003d \u0027sqlite://\u0027:"},{"line_number":255,"context_line":"            ModelBase.metadata.create_all(bind\u003dengine)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        set_global_engine(engine)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2FlHo%3D","line":255,"in_reply_to":"AAAAPH%2F%2Fw6Q%3D","updated":"2013-05-30 02:21:54.000000000","message":"I\u0027ll move this code into new_engine so that it gets called any time a new engine is created.","commit_id":"d56bbde214e5eef27484fb758f68c4f7f2f9ba09"}]}