)]}'
{"keystone/cmd/cli.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"e7778110f8456425e93d596b63da718730c3b7e7","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            LOG.info(_LI(\u0027User %s already exists, skipping creation.\u0027),"},{"line_number":217,"context_line":"                     self.username)"},{"line_number":218,"context_line":"        except exception.UserNotFound:"},{"line_number":219,"context_line":"            user \u003d self.identity_manager.create_user("},{"line_number":220,"context_line":"                user_ref\u003d{\u0027name\u0027: self.username,"},{"line_number":221,"context_line":"                          \u0027enabled\u0027: True,"},{"line_number":222,"context_line":"                          \u0027domain_id\u0027: default_domain[\u0027id\u0027],"},{"line_number":223,"context_line":"                          \u0027password\u0027: self.password"},{"line_number":224,"context_line":"                          }"},{"line_number":225,"context_line":"            )"},{"line_number":226,"context_line":"            LOG.info(_LI(\u0027Created user %s\u0027), self.username)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # NOTE(morganfainberg): Do not create the role if it already exists."},{"line_number":229,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_6beddfee","line":226,"range":{"start_line":219,"start_character":12,"end_line":226,"end_character":59},"updated":"2016-03-16 15:54:37.000000000","message":"based on the bug, this should also be in a try / except block and should fail completely if the user cannot be created with a more friendly error IMO saying that the user doesn\u0027t exist *and* cannot be created.\n\nI would be ok with the change to include changing all try/excepts for bootstrap to be a get and if notfound create pattern.","commit_id":"6ecd7b6965c4441a9590a6751dc1818703672965"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"5e91e8131db22d1016e2abd63f2536175c121799","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                )"},{"line_number":227,"context_line":"                LOG.info(_LI(\u0027Created user %s\u0027), self.username)"},{"line_number":228,"context_line":"            except exception.ForbiddenAction as e:"},{"line_number":229,"context_line":"                LOG.error(_LI(\u0027Unable to create user %s\u0027),"},{"line_number":230,"context_line":"                          self.username,"},{"line_number":231,"context_line":"                          exc_info\u003dTrue)"},{"line_number":232,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_bf79ddfe","line":229,"updated":"2016-03-16 16:44:34.000000000","message":"Should be _LE since this is for an error.","commit_id":"0a6260da7ea1565e03a1c5572a6bf2a88520d8e3"}]}