)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"c0ea657a98f4a73ed8c6c3c6d2e7c55b5ae0a11f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"needed in oslo.db and osprofiler."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I206b26814a67ecc96473343c8fd1c0fba063a48a"},{"line_number":13,"context_line":"Depends-On: Ie517524a10713e09bb2491f2d76b651b20ecd4b6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3aaa91ec_b629f38b","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":53},"updated":"2016-06-23 00:26:04.000000000","message":"You can now remove this","commit_id":"5337eb6173cbd245eada90f0bb42dc7c1434ce57"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"e14dc6c59641e8e93f1fcafbe6a10d4f7b853a04","unresolved":false,"context_lines":[{"line_number":10,"context_line":"needed in oslo.db and osprofiler."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I206b26814a67ecc96473343c8fd1c0fba063a48a"},{"line_number":13,"context_line":"Depends-On: Ie517524a10713e09bb2491f2d76b651b20ecd4b6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a6eadb0_a19382f9","line":13,"updated":"2016-12-20 01:34:35.000000000","message":"this has been merged, Depends-On tag is not needed anymore","commit_id":"7814d68957bcee7fde0a4c244ecbd00c8d7716e5"}],"keystone/common/sql/core.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"1d615a3210d1a776ab450893d2a359cb41849795","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    return _wrap_session(writer.using(_get_context()))"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"def _wrap_session(sess):"},{"line_number":223,"context_line":"    if CONF.profiler.enabled and CONF.profiler.trace_sqlalchemy:"},{"line_number":224,"context_line":"        sess \u003d osprofiler.sqlalchemy.wrap_session(sql, sess)"},{"line_number":225,"context_line":"    return sess"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"def truncated(f):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_76c00a7c","line":225,"range":{"start_line":222,"start_character":0,"end_line":225,"end_character":15},"updated":"2016-04-13 15:14:26.000000000","message":"Thank you for making this not always wrap the session! profiling should be next to zero cost when/if disabled. Nicely done.","commit_id":"ace0252424145106b8f711e7d5abb028a919f58d"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"3ead1359d13370befc6798b03ff286e4f04f7182","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    return _wrap_session(writer.using(_get_context()))"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"def _wrap_session(sess):"},{"line_number":223,"context_line":"    if CONF.profiler.enabled and CONF.profiler.trace_sqlalchemy:"},{"line_number":224,"context_line":"        sess \u003d osprofiler.sqlalchemy.wrap_session(sql, sess)"},{"line_number":225,"context_line":"    return sess"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"def truncated(f):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_80647722","line":225,"range":{"start_line":222,"start_character":0,"end_line":225,"end_character":15},"in_reply_to":"5a18252c_76c00a7c","updated":"2016-04-13 16:05:20.000000000","message":"You\u0027re welcome! Once profiler release will be cut this week, this will be fully workable :)","commit_id":"ace0252424145106b8f711e7d5abb028a919f58d"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"6986f5840f18850d459cd0b6ea147b2209087500","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    return _wrap_session(writer.using(_get_context()))"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"def _wrap_session(sess):"},{"line_number":223,"context_line":"    if (\u0027profiler\u0027 in CONF"},{"line_number":224,"context_line":"            and CONF.profiler.enabled"},{"line_number":225,"context_line":"            and CONF.profiler.trace_sqlalchemy):"},{"line_number":226,"context_line":"        sess \u003d osprofiler.sqlalchemy.wrap_session(sql, sess)"},{"line_number":227,"context_line":"    return sess"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"def truncated(f):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a18252c_76f3ead6","line":227,"range":{"start_line":222,"start_character":0,"end_line":227,"end_character":15},"updated":"2016-04-13 15:15:30.000000000","message":"same comment as on 5, thanks for making this next to zero cost if profiling is disabled.","commit_id":"f560963f3d267e7afc9ea7932468afb1276d3f64"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"3b90698a11dac88dd6c7d5c1d885e7de3937321f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"from keystone.i18n import _"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"ModelBase \u003d declarative.declarative_base()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_759dfe58","line":43,"updated":"2016-05-24 11:41:55.000000000","message":"Morgan, do you think we can use keystone/common/config.py here instead of oslo_config? if so, we\u0027ll be able to use all already set up options","commit_id":"5337eb6173cbd245eada90f0bb42dc7c1434ce57"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"7e433709ecfffcf2fbd4e00ebff66f9f47bbcaae","unresolved":false,"context_lines":[{"line_number":40,"context_line":"from keystone.i18n import _"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"ModelBase \u003d declarative.declarative_base()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_9beb5eb0","line":43,"in_reply_to":"bab6814e_759dfe58","updated":"2016-05-24 17:15:17.000000000","message":"Not sure what this would entail. common.config uses oslo_config and we don\u0027t actually have access to the options until we call setup (on syustem startup)","commit_id":"5337eb6173cbd245eada90f0bb42dc7c1434ce57"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"062f11e26e9283642a950294229f41b0b03c3212","unresolved":false,"context_lines":[{"line_number":40,"context_line":"from keystone.i18n import _"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"ModelBase \u003d declarative.declarative_base()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_e103bf74","line":43,"in_reply_to":"bab6814e_9beb5eb0","updated":"2016-05-25 08:42:05.000000000","message":"oops, yes, I was confused here. I think we can modify these lines\n\nhttps://github.com/openstack/keystone/blob/master/keystone/cmd/cli.py#L941-L942\n\nto look like this:\n\n    config.set_config_defaults()\n    sql.initialize()\n\nthe only moment I want to ensure - is the order sql initialisation first and then config management intentional? or I can just swap these two steps? if it\u0027s intentional I can just add set_external_opts_defaults() prior sql initialization","commit_id":"5337eb6173cbd245eada90f0bb42dc7c1434ce57"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"ffde4990cfcef5bef1b6c96eb72479ffc86675c6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"from keystone.i18n import _"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"ModelBase \u003d declarative.declarative_base()"}],"source_content_type":"text/x-python","patch_set":8,"id":"9abb7d3a_1183ffcd","line":43,"in_reply_to":"bab6814e_dc428e0e","updated":"2016-05-27 10:26:38.000000000","message":"ok, so it looks like I just need to ensure needed opts are initialised in this module and that\u0027s it. Not so fancy, but no influence to current behaviour.","commit_id":"5337eb6173cbd245eada90f0bb42dc7c1434ce57"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c0a4bc732bf49899f4d06dac839fe959c7418d66","unresolved":false,"context_lines":[{"line_number":40,"context_line":"from keystone.i18n import _"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"ModelBase \u003d declarative.declarative_base()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_dc428e0e","line":43,"in_reply_to":"bab6814e_e103bf74","updated":"2016-05-26 14:18:21.000000000","message":"Unfortunatly, no. Because wedon\u0027t iniitalize config until runtime to avoid issues with reading config before it\u0027s populated/read from disk.","commit_id":"5337eb6173cbd245eada90f0bb42dc7c1434ce57"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5694607db6b1e91fae46d7e6a763a751ee57b91e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    db_options.set_defaults("},{"line_number":75,"context_line":"        CONF,"},{"line_number":76,"context_line":"        connection\u003d\"sqlite:///keystone.db\")"},{"line_number":77,"context_line":"    keystone.conf.set_external_opts_defaults()"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def initialize_decorator(init):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a629dbe_485ba687","line":77,"updated":"2016-11-08 15:02:05.000000000","message":"it\u0027s not obvious to me why this is here. Add a comment.","commit_id":"7814d68957bcee7fde0a4c244ecbd00c8d7716e5"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"17c1942ea71376dc50648e80341040c0939ba35d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    db_options.set_defaults("},{"line_number":75,"context_line":"        CONF,"},{"line_number":76,"context_line":"        connection\u003d\"sqlite:///keystone.db\")"},{"line_number":77,"context_line":"    keystone.conf.set_external_opts_defaults()"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def initialize_decorator(init):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5201f7_07934ca4","line":77,"in_reply_to":"1a6eadb0_41b9ce78","updated":"2017-01-04 03:11:02.000000000","message":"I believe that he want to set this (inside set_external_opts_defaults()):\n\nprofiler.set_defaults(CONF, enabled\u003dFalse, trace_sqlalchemy\u003dFalse)","commit_id":"7814d68957bcee7fde0a4c244ecbd00c8d7716e5"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"e14dc6c59641e8e93f1fcafbe6a10d4f7b853a04","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    db_options.set_defaults("},{"line_number":75,"context_line":"        CONF,"},{"line_number":76,"context_line":"        connection\u003d\"sqlite:///keystone.db\")"},{"line_number":77,"context_line":"    keystone.conf.set_external_opts_defaults()"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def initialize_decorator(init):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_41b9ce78","line":77,"in_reply_to":"9a629dbe_485ba687","updated":"2016-12-20 01:34:35.000000000","message":"++\n\nis this just to set CONF.profiler options ?","commit_id":"7814d68957bcee7fde0a4c244ecbd00c8d7716e5"}]}