)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19985,"name":"Ryosuke Mizuno","email":"r-mizuno@rs.jp.nec.com","username":"r-mizuno"},"change_message_id":"2d892f9d7379667fefea682b0096395ae339ab2f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Run federation tests under Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since pysaml2 is now python 3 compatable we can remove the testing"},{"line_number":10,"context_line":"file from the blacklist file. There were also a few other compatiblity"},{"line_number":11,"context_line":"changes that need to be made."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba0121b8_acf2e603","line":9,"range":{"start_line":9,"start_character":30,"end_line":9,"end_character":40},"updated":"2016-04-01 02:23:23.000000000","message":"compatible?","commit_id":"eae117fec9257bc327a8326c518910de4d7b64c3"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"0b275b42779834ece64eddff44a85ee60fe99ccf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Run federation tests under Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since pysaml2 is now python 3 compatable we can remove the testing"},{"line_number":10,"context_line":"file from the blacklist file. There were also a few other compatiblity"},{"line_number":11,"context_line":"changes that need to be made."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba0121b8_28706271","line":9,"range":{"start_line":9,"start_character":30,"end_line":9,"end_character":40},"in_reply_to":"ba0121b8_acf2e603","updated":"2016-04-01 16:07:52.000000000","message":"Done","commit_id":"eae117fec9257bc327a8326c518910de4d7b64c3"}],"keystone/tests/unit/test_v3_federation.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0e7bfc7fc603e0c298aaf7468d8db4fcf01a08e2","unresolved":false,"context_lines":[{"line_number":2809,"context_line":"            assertion_xml \u003d six.text_type(assertion_xml)"},{"line_number":2810,"context_line":"            # make sure we have the proper tag and prefix for the assertion"},{"line_number":2811,"context_line":"            # namespace"},{"line_number":2812,"context_line":"            self.assertIn(\u0027\u003csaml:Assertion\u0027, assertion_xml)"},{"line_number":2813,"context_line":"            self.assertIn(\u0027xmlns:saml\u003d\"\u0027 + saml2.NAMESPACE + \u0027\"\u0027,"},{"line_number":2814,"context_line":"                          assertion_xml)"},{"line_number":2815,"context_line":"            self.assertIn(\u0027xmlns:xmldsig\u003d\"\u0027 + xmldsig.NAMESPACE + \u0027\"\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da0c15f0_e093dda1","line":2812,"updated":"2016-03-25 20:57:53.000000000","message":"I\u0027d prefer it if these reference values were changed rather than the actual function response was modified to match the reference values.\n\nThis applies ot all these changes. Don\u0027t adapt the real response to the test values. The test values should match the real response.","commit_id":"c7a4119d58c1a7e472faa6421897f75cab782e1b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"24e939445edc4526987fc346bba597f8c7772edd","unresolved":false,"context_lines":[{"line_number":2809,"context_line":"            assertion_xml \u003d six.text_type(assertion_xml)"},{"line_number":2810,"context_line":"            # make sure we have the proper tag and prefix for the assertion"},{"line_number":2811,"context_line":"            # namespace"},{"line_number":2812,"context_line":"            self.assertIn(\u0027\u003csaml:Assertion\u0027, assertion_xml)"},{"line_number":2813,"context_line":"            self.assertIn(\u0027xmlns:saml\u003d\"\u0027 + saml2.NAMESPACE + \u0027\"\u0027,"},{"line_number":2814,"context_line":"                          assertion_xml)"},{"line_number":2815,"context_line":"            self.assertIn(\u0027xmlns:xmldsig\u003d\"\u0027 + xmldsig.NAMESPACE + \u0027\"\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_f023af03","line":2812,"in_reply_to":"da0c15f0_e093dda1","updated":"2016-03-29 15:08:29.000000000","message":"Done","commit_id":"c7a4119d58c1a7e472faa6421897f75cab782e1b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"3b8e5f40944f75f45b4c7d913d61a6057654ee83","unresolved":false,"context_lines":[{"line_number":2809,"context_line":"            assertion_xml \u003d six.text_type(assertion_xml)"},{"line_number":2810,"context_line":"            # make sure we have the proper tag and prefix for the assertion"},{"line_number":2811,"context_line":"            # namespace"},{"line_number":2812,"context_line":"            self.assertIn(\u0027\u003csaml:Assertion\u0027, assertion_xml)"},{"line_number":2813,"context_line":"            self.assertIn(\u0027xmlns:saml\u003d\"\u0027 + saml2.NAMESPACE + \u0027\"\u0027,"},{"line_number":2814,"context_line":"                          assertion_xml)"},{"line_number":2815,"context_line":"            self.assertIn(\u0027xmlns:xmldsig\u003d\"\u0027 + xmldsig.NAMESPACE + \u0027\"\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_b5baf7be","line":2812,"in_reply_to":"da0c15f0_e093dda1","updated":"2016-03-28 18:41:14.000000000","message":"I agree 100%, It will be fixed in the next patch set.","commit_id":"c7a4119d58c1a7e472faa6421897f75cab782e1b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"df590f2e68c6de3a46bea8b7640c8d4bdbb85cd7","unresolved":false,"context_lines":[{"line_number":2808,"context_line":"            # Python 2 and \u0027bytes\u0027 in Python 3"},{"line_number":2809,"context_line":"            # make sure we have the proper tag and prefix for the assertion"},{"line_number":2810,"context_line":"            # namespace"},{"line_number":2811,"context_line":"            self.assertIn(\u0027\u003csaml:Assertion\u0027.encode(\u0027utf-8\u0027),"},{"line_number":2812,"context_line":"                          assertion_xml)"},{"line_number":2813,"context_line":"            self.assertIn((\u0027xmlns:saml\u003d\"\u0027 + saml2.NAMESPACE +"},{"line_number":2814,"context_line":"                          \u0027\"\u0027).encode(\u0027utf-8\u0027), assertion_xml)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_636ae2ef","line":2811,"updated":"2016-03-30 21:51:54.000000000","message":"To make a binary string literal use b\u0027\u0027.","commit_id":"0f19b295bfc308643414481ce4c06c8e84f4f676"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"990355914fb353f7c011a1fc92e74bf96bcf1cb6","unresolved":false,"context_lines":[{"line_number":2808,"context_line":"            # Python 2 and \u0027bytes\u0027 in Python 3"},{"line_number":2809,"context_line":"            # make sure we have the proper tag and prefix for the assertion"},{"line_number":2810,"context_line":"            # namespace"},{"line_number":2811,"context_line":"            self.assertIn(\u0027\u003csaml:Assertion\u0027.encode(\u0027utf-8\u0027),"},{"line_number":2812,"context_line":"                          assertion_xml)"},{"line_number":2813,"context_line":"            self.assertIn((\u0027xmlns:saml\u003d\"\u0027 + saml2.NAMESPACE +"},{"line_number":2814,"context_line":"                          \u0027\"\u0027).encode(\u0027utf-8\u0027), assertion_xml)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_4acfd128","line":2811,"in_reply_to":"ba0121b8_636ae2ef","updated":"2016-03-31 13:26:12.000000000","message":"okay will do that now","commit_id":"0f19b295bfc308643414481ce4c06c8e84f4f676"}],"keystone/token/providers/fernet/token_formatters.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"02098943bb751fbb9bbb1b6442b869665927256b","unresolved":false,"context_lines":[{"line_number":536,"context_line":"            idp_id \u003d cls.convert_uuid_bytes_to_hex(idp_id)"},{"line_number":537,"context_line":"        else:"},{"line_number":538,"context_line":"            idp_id \u003d idp_id.decode(\u0027utf-8\u0027)"},{"line_number":539,"context_line":"        protocol_id \u003d payload[4].decode(\u0027utf-8\u0027)"},{"line_number":540,"context_line":"        expires_at_str \u003d cls._convert_float_to_time_string(payload[5])"},{"line_number":541,"context_line":"        audit_ids \u003d list(map(provider.base64_encode, payload[6]))"},{"line_number":542,"context_line":"        federated_info \u003d dict(group_ids\u003dgroup_ids, idp_id\u003didp_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da0c15f0_db819e4f","line":539,"updated":"2016-03-24 20:37:21.000000000","message":"Does this not apply to other IDs in the federated payload, like user IDs?","commit_id":"c7a4119d58c1a7e472faa6421897f75cab782e1b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"fba44844fd449a06de557ef321349d2b1a0fe323","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        methods \u003d auth_plugins.convert_integer_to_method_list(payload[1])"},{"line_number":533,"context_line":"        group_ids \u003d list(map(cls.unpack_group_id, payload[2]))"},{"line_number":534,"context_line":"        (is_stored_as_bytes, idp_id) \u003d payload[3]"},{"line_number":535,"context_line":"        if is_stored_as_bytes:"},{"line_number":536,"context_line":"            idp_id \u003d cls.convert_uuid_bytes_to_hex(idp_id)"},{"line_number":537,"context_line":"        else:"},{"line_number":538,"context_line":"            idp_id \u003d idp_id.decode(\u0027utf-8\u0027)"},{"line_number":539,"context_line":"        protocol_id \u003d payload[4].decode(\u0027utf-8\u0027)"},{"line_number":540,"context_line":"        expires_at_str \u003d cls._convert_float_to_time_string(payload[5])"},{"line_number":541,"context_line":"        audit_ids \u003d list(map(provider.base64_encode, payload[6]))"},{"line_number":542,"context_line":"        federated_info \u003d dict(group_ids\u003dgroup_ids, idp_id\u003didp_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da0c15f0_90109750","line":539,"range":{"start_line":535,"start_character":8,"end_line":539,"end_character":48},"updated":"2016-03-25 04:23:09.000000000","message":"whats the difference between this and \"attempt_convert_uuid_hex_to_bytes\" like on line 564","commit_id":"c7a4119d58c1a7e472faa6421897f75cab782e1b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"0bf5938d84326b45c38868316ec539c125143eee","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        methods \u003d auth_plugins.convert_integer_to_method_list(payload[1])"},{"line_number":533,"context_line":"        group_ids \u003d list(map(cls.unpack_group_id, payload[2]))"},{"line_number":534,"context_line":"        (is_stored_as_bytes, idp_id) \u003d payload[3]"},{"line_number":535,"context_line":"        if is_stored_as_bytes:"},{"line_number":536,"context_line":"            idp_id \u003d cls.convert_uuid_bytes_to_hex(idp_id)"},{"line_number":537,"context_line":"        else:"},{"line_number":538,"context_line":"            idp_id \u003d idp_id.decode(\u0027utf-8\u0027)"},{"line_number":539,"context_line":"        protocol_id \u003d payload[4].decode(\u0027utf-8\u0027)"},{"line_number":540,"context_line":"        expires_at_str \u003d cls._convert_float_to_time_string(payload[5])"},{"line_number":541,"context_line":"        audit_ids \u003d list(map(provider.base64_encode, payload[6]))"},{"line_number":542,"context_line":"        federated_info \u003d dict(group_ids\u003dgroup_ids, idp_id\u003didp_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da0c15f0_ea02af3d","line":539,"range":{"start_line":535,"start_character":8,"end_line":539,"end_character":48},"in_reply_to":"da0c15f0_90109750","updated":"2016-03-25 13:18:22.000000000","message":"@Lance Checking now.\n\n@Steve, attempt_convert_uuid_hex_to_bytes will convert from bytes to hex where this is converting bytes to text_type.","commit_id":"c7a4119d58c1a7e472faa6421897f75cab782e1b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"ce97ae8f3a6049ba1242b318cc4e43c95f8739ca","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        methods \u003d auth_plugins.convert_integer_to_method_list(payload[1])"},{"line_number":533,"context_line":"        group_ids \u003d list(map(cls.unpack_group_id, payload[2]))"},{"line_number":534,"context_line":"        (is_stored_as_bytes, idp_id) \u003d payload[3]"},{"line_number":535,"context_line":"        if is_stored_as_bytes:"},{"line_number":536,"context_line":"            idp_id \u003d cls.convert_uuid_bytes_to_hex(idp_id)"},{"line_number":537,"context_line":"        else:"},{"line_number":538,"context_line":"            idp_id \u003d idp_id.decode(\u0027utf-8\u0027)"},{"line_number":539,"context_line":"        protocol_id \u003d payload[4].decode(\u0027utf-8\u0027)"},{"line_number":540,"context_line":"        expires_at_str \u003d cls._convert_float_to_time_string(payload[5])"},{"line_number":541,"context_line":"        audit_ids \u003d list(map(provider.base64_encode, payload[6]))"},{"line_number":542,"context_line":"        federated_info \u003d dict(group_ids\u003dgroup_ids, idp_id\u003didp_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da0c15f0_854dd374","line":539,"range":{"start_line":535,"start_character":8,"end_line":539,"end_character":48},"in_reply_to":"da0c15f0_ea02af3d","updated":"2016-03-25 20:01:25.000000000","message":"@Lance I think the key is to get the file `test_fernet_provider` working with python 3 -\u003e https://review.openstack.org/#/c/297768/  I think we are seeing some gaps in those tests here. I will try to add to the tests to make sure everything is working correctly before we move forward with this patch. Thanks!","commit_id":"c7a4119d58c1a7e472faa6421897f75cab782e1b"}]}