)]}'
{"keystone/cmd/cli.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ec5a69cce5c90aa81cc70e451e8fc993e9dd34bd","unresolved":false,"context_lines":[{"line_number":989,"context_line":"         usage\u003d\u0027%(prog)s [\u0027 + \u0027|\u0027.join([cmd.name for cmd in CMDS]) + \u0027]\u0027,"},{"line_number":990,"context_line":"         default_config_files\u003dconfig_files)"},{"line_number":991,"context_line":"    if not CONF.default_config_files:"},{"line_number":992,"context_line":"        LOG.warning(_LW(\u0027Config file not found, using default configs.\u0027))"},{"line_number":993,"context_line":"    config.setup_logging()"},{"line_number":994,"context_line":"    CONF.command.cmd_class.main()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_db452e6f","line":992,"updated":"2016-04-01 16:43:30.000000000","message":"++ This works for me but I think we should add a test to make sure we don\u0027t accidentally refactor out this behavior. Maybe something along the lines of: \n\nhttps://review.openstack.org/#/c/214287/9/keystone/tests/unit/test_cli.py","commit_id":"ec5b2c13a23cf66c1e799d7eab9259832e68750a"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"6af670e5d0a54db186750087b2551d921df484ce","unresolved":false,"context_lines":[{"line_number":978,"context_line":"         default_config_files\u003dconfig_files)"},{"line_number":979,"context_line":"    if not CONF.default_config_files:"},{"line_number":980,"context_line":"        LOG.warning(_LW(\u0027Config file not found, using default configs.\u0027))"},{"line_number":981,"context_line":"    config.setup_logging()"},{"line_number":982,"context_line":"    CONF.command.cmd_class.main()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_df505d0d","line":981,"updated":"2016-04-02 21:09:05.000000000","message":"Do we need to do setup_logging first?","commit_id":"01d667e8d69749328e2f64c58d82b9882f5d0ded"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"8bb7627bd276eb3238aaefa271624a5aac7ebc52","unresolved":false,"context_lines":[{"line_number":978,"context_line":"         default_config_files\u003dconfig_files)"},{"line_number":979,"context_line":"    if not CONF.default_config_files:"},{"line_number":980,"context_line":"        LOG.warning(_LW(\u0027Config file not found, using default configs.\u0027))"},{"line_number":981,"context_line":"    config.setup_logging()"},{"line_number":982,"context_line":"    CONF.command.cmd_class.main()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_d09e4bb7","line":981,"in_reply_to":"9a061dce_2277b43b","updated":"2016-04-05 15:41:43.000000000","message":"I tend to err to the side of consistency, so the prefixes and such would be generally good. I really think that in either case just adding the log lines is super useful; so either way.","commit_id":"01d667e8d69749328e2f64c58d82b9882f5d0ded"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8ba1ae914856a677c3c0af135f0d0790ce4fd3bc","unresolved":false,"context_lines":[{"line_number":978,"context_line":"         default_config_files\u003dconfig_files)"},{"line_number":979,"context_line":"    if not CONF.default_config_files:"},{"line_number":980,"context_line":"        LOG.warning(_LW(\u0027Config file not found, using default configs.\u0027))"},{"line_number":981,"context_line":"    config.setup_logging()"},{"line_number":982,"context_line":"    CONF.command.cmd_class.main()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_2277b43b","line":981,"in_reply_to":"ba0121b8_df505d0d","updated":"2016-04-04 18:50:18.000000000","message":"My thought with having it second was that oslo_log.log.setup() uses configs from keystone.conf, so warning they were missing ahead of trying to use them made sense. On the other hand, oslo_log.log.setup() adds the log formatting prefix to the output, so that might be preferable. What do you think?","commit_id":"01d667e8d69749328e2f64c58d82b9882f5d0ded"}],"keystone/tests/unit/test_cli.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"61c5c2e6de0df61e1f2b833b45b43421aa809904","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        cli.TokenFlush.main()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class CliNoConfigTestCase(unit.TestCase):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def setUp(self):"},{"line_number":53,"context_line":"        super(CliNoConfigTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_e1e03cfd","line":50,"updated":"2016-04-01 19:54:25.000000000","message":"For this, is there something that we need in TestCase or can we just use BaseTestCase?","commit_id":"318f93db1e0fed1603db1b0b758a120d70e4a429"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"61c5c2e6de0df61e1f2b833b45b43421aa809904","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            def __init__(self):"},{"line_number":59,"context_line":"                self.cmd_class \u003d mock.Mock()"},{"line_number":60,"context_line":"        self.useFixture(mockpatch.PatchObject("},{"line_number":61,"context_line":"            CONF, \u0027command\u0027, FakeConfCommand()))"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.logging \u003d self.useFixture("},{"line_number":64,"context_line":"            fixtures.FakeLogger(level\u003dlogging.WARN))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_c129b8f4","line":61,"updated":"2016-04-01 19:54:25.000000000","message":"I pulled this down and ran the tests but inherited BaseTestCase instead of TestCase and got this failure (http://cdn.pasteraw.com/472zi6z5qs9yxt0gxmv9teg1uvbedj6). \n\nShouldn\u0027t the mock allow us to use BaseTestCase instead?","commit_id":"318f93db1e0fed1603db1b0b758a120d70e4a429"}]}