)]}'
{"keystone/identity/backends/ldap/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"104f02653f4fa7830f840fa23dd77d78692b46bb","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        model \u003d super(RoleApi, self).get(id, filter)"},{"line_number":672,"context_line":"        return model"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    def create(self, values):"},{"line_number":675,"context_line":"        #values[\u0027id\u0027] \u003d values[\u0027name\u0027]"},{"line_number":676,"context_line":"        #delattr(values, \u0027name\u0027)"},{"line_number":677,"context_line":"        return super(RoleApi, self).create(values)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FwEg%3D","line":674,"updated":"2013-05-23 21:06:28.000000000","message":"I understand this doesn\u0027t lie within the scope of this fix but I just happen to see it. Can I push up a patch to remove?","commit_id":"d633413c33f37df55a0bfb1c2c3ad137f4bf6fcf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"424f0864983178f3da424ba0983a1b126b593a17","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        model \u003d super(RoleApi, self).get(id, filter)"},{"line_number":672,"context_line":"        return model"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    def create(self, values):"},{"line_number":675,"context_line":"        #values[\u0027id\u0027] \u003d values[\u0027name\u0027]"},{"line_number":676,"context_line":"        #delattr(values, \u0027name\u0027)"},{"line_number":677,"context_line":"        return super(RoleApi, self).create(values)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fv7s%3D","line":674,"in_reply_to":"AAAAPH%2F%2FwEg%3D","updated":"2013-05-23 21:54:26.000000000","message":"no functional fix I said I would push up related to this: \n\nhttps://review.openstack.org/#/c/30349/","commit_id":"d633413c33f37df55a0bfb1c2c3ad137f4bf6fcf"}],"keystone/token/controllers.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"042fff0123850705aa7683b2fefc16944c75b0fc","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        tenant_ref \u003d self._get_project_ref(context, user_id, tenant_id)"},{"line_number":216,"context_line":"        metadata_ref \u003d self._get_metadata_ref(context, user_id, tenant_id)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        # TODO(henry-nash) If no tenant was specified, instead check"},{"line_number":219,"context_line":"        # for a domain and find any related user/group roles"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        self._append_roles(metadata_ref,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FwA0%3D","line":218,"updated":"2013-05-23 21:20:57.000000000","message":"TODO(henry-hash): If ..\n\nIs the colon significant?","commit_id":"a7e1add548a06b94e8dcea1e27b9118551c649dc"}],"tests/test_backend_ldap.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"042fff0123850705aa7683b2fefc16944c75b0fc","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        expected_dict \u003d {\u0027description\u0027: \u0027name\u0027, \u0027gecos\u0027: \u0027password\u0027}"},{"line_number":387,"context_line":"        self.assertDictEqual(expected_dict, mapping)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"# TODO(henry-nash) These need to be removed when the full LDAP implementation"},{"line_number":390,"context_line":"# is submitted - see Bugs 1092187, 1101287, 1101276, 1101289"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    # (spzala)The group and domain crud tests below override the standard ones"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FwA4%3D","line":389,"updated":"2013-05-23 21:20:57.000000000","message":"TODO(henry-nash): These ..","commit_id":"a7e1add548a06b94e8dcea1e27b9118551c649dc"},{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"c2139bee3430178bae1f0cc48279ae793cbec40d","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        self.assertDictEqual(expected_dict, mapping)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"# TODO(henry-nash) These need to be removed when the full LDAP implementation"},{"line_number":390,"context_line":"# is submitted - see Bugs 1092187, 1101287, 1101276, 1101289"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    # (spzala)The group and domain crud tests below override the standard ones"},{"line_number":393,"context_line":"    # in test_backend.py so that we can exclude the update name test, since we"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Fv8Q%3D","line":390,"updated":"2013-05-23 21:55:15.000000000","message":"Missed : ? :-)","commit_id":"980977db68a86542c662d2f4faf1fe4f16e5e89e"},{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"4b343eeadb1827f416ed38e487808aed221c2583","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        self.assertDictEqual(expected_dict, mapping)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"# TODO(henry-nash) These need to be removed when the full LDAP implementation"},{"line_number":390,"context_line":"# is submitted - see Bugs 1092187, 1101287, 1101276, 1101289"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    # (spzala)The group and domain crud tests below override the standard ones"},{"line_number":393,"context_line":"    # in test_backend.py so that we can exclude the update name test, since we"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Fv1g%3D","line":390,"in_reply_to":"AAAAPH%2F%2Fv2k%3D","updated":"2013-05-23 22:22:38.000000000","message":"Aha, Cool. Thanks!","commit_id":"980977db68a86542c662d2f4faf1fe4f16e5e89e"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a4f1255ce2496c2dbce35c3a57e3224b0f7f7080","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        self.assertDictEqual(expected_dict, mapping)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"# TODO(henry-nash) These need to be removed when the full LDAP implementation"},{"line_number":390,"context_line":"# is submitted - see Bugs 1092187, 1101287, 1101276, 1101289"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    # (spzala)The group and domain crud tests below override the standard ones"},{"line_number":393,"context_line":"    # in test_backend.py so that we can exclude the update name test, since we"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Fv2k%3D","line":390,"in_reply_to":"AAAAPH%2F%2Fv3M%3D","updated":"2013-05-23 22:18:02.000000000","message":"ack is fairly new, but has 100% replaced grep for me http://beyondgrep.com/","commit_id":"980977db68a86542c662d2f4faf1fe4f16e5e89e"},{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"c2690b6c47abdd103262381679125bffad436b82","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        self.assertDictEqual(expected_dict, mapping)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"# TODO(henry-nash) These need to be removed when the full LDAP implementation"},{"line_number":390,"context_line":"# is submitted - see Bugs 1092187, 1101287, 1101276, 1101289"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    # (spzala)The group and domain crud tests below override the standard ones"},{"line_number":393,"context_line":"    # in test_backend.py so that we can exclude the update name test, since we"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Fv3M%3D","line":390,"in_reply_to":"AAAAPH%2F%2Fv4U%3D","updated":"2013-05-23 22:15:11.000000000","message":":-) \nand thanks for sharing ack result. I learned that cool thing. With my limited knowledge I didn\u0027t know about ack. thought it was some acronym :(. I am going to install it :-).","commit_id":"980977db68a86542c662d2f4faf1fe4f16e5e89e"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"dcd5a0c053b3dff3ea072b1bd7c5035c7a9de868","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        self.assertDictEqual(expected_dict, mapping)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"# TODO(henry-nash) These need to be removed when the full LDAP implementation"},{"line_number":390,"context_line":"# is submitted - see Bugs 1092187, 1101287, 1101276, 1101289"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    # (spzala)The group and domain crud tests below override the standard ones"},{"line_number":393,"context_line":"    # in test_backend.py so that we can exclude the update name test, since we"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Fv4U%3D","line":390,"in_reply_to":"AAAAPH%2F%2Fv4w%3D","updated":"2013-05-23 22:08:07.000000000","message":"i really don\u0027t want to do more code reviews until all this stuff is non-human gated :) and code reviews are otherwise my highest priority!","commit_id":"980977db68a86542c662d2f4faf1fe4f16e5e89e"},{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"1128b40b1393c46fc027ee7412351a19db086c7f","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        self.assertDictEqual(expected_dict, mapping)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"# TODO(henry-nash) These need to be removed when the full LDAP implementation"},{"line_number":390,"context_line":"# is submitted - see Bugs 1092187, 1101287, 1101276, 1101289"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    # (spzala)The group and domain crud tests below override the standard ones"},{"line_number":393,"context_line":"    # in test_backend.py so that we can exclude the update name test, since we"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Fv4w%3D","line":390,"in_reply_to":"AAAAPH%2F%2Fv6I%3D","updated":"2013-05-23 22:05:08.000000000","message":"thanks. He he .. well, no .. it\u0027s just you are working too hard, I am seeing one after one new patches :-) .. great job.","commit_id":"980977db68a86542c662d2f4faf1fe4f16e5e89e"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"49d7f512fbbad873007910bd98a5d9c5ab29fc4e","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        self.assertDictEqual(expected_dict, mapping)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"# TODO(henry-nash) These need to be removed when the full LDAP implementation"},{"line_number":390,"context_line":"# is submitted - see Bugs 1092187, 1101287, 1101276, 1101289"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    # (spzala)The group and domain crud tests below override the standard ones"},{"line_number":393,"context_line":"    # in test_backend.py so that we can exclude the update name test, since we"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Fv6I%3D","line":390,"in_reply_to":"AAAAPH%2F%2Fv8Q%3D","updated":"2013-05-23 21:58:48.000000000","message":"weird, my ack skills must suck -- will fix","commit_id":"980977db68a86542c662d2f4faf1fe4f16e5e89e"}],"tox.ini":[{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"c2139bee3430178bae1f0cc48279ae793cbec40d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"# H702: use bare string concatenation instead of +; formatting operation should be outside of localization method call"},{"line_number":45,"context_line":"# H703: multiple positional placeholders"},{"line_number":46,"context_line":"# H902: use the \u0027not in\u0027 operator for collection membership evaluation"},{"line_number":47,"context_line":"ignore \u003d H201,H301,H302,H304,H306,H401,H402,H403,H404,H701,H702,H703,H902"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"builtins \u003d _"},{"line_number":50,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,tools,vendor"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAPH%2F%2Fv8A%3D","line":47,"updated":"2013-05-23 21:55:15.000000000","message":"Cool.","commit_id":"980977db68a86542c662d2f4faf1fe4f16e5e89e"}]}