)]}'
{"id":"openstack%2Fkeystone~3047","triplet_id":"openstack%2Fkeystone~master~I63e24189832cb96454c085797bff4c5c09e10b70","project":"openstack/keystone","branch":"master","topic":"bug/916199","hashtags":[],"change_id":"I63e24189832cb96454c085797bff4c5c09e10b70","subject":"Bug #916199: keystone-manage service list fails with AttributeError on Service.description","status":"MERGED","created":"2012-01-13 22:26:42.000000000","updated":"2012-01-20 02:11:02.000000000","submitted":"2012-01-20 02:11:02.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ece57b33ee4dda49f036ae41f3f4c716eb474f5b","_number":3047,"virtual_id_number":3047,"owner":{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},{"value":1,"date":"2012-01-20 02:10:57.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},{"value":2,"date":"2012-01-20 02:11:02.000000000","post_submit":true,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":2,"date":"2012-01-19 19:42:22.000000000","_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},{"value":0,"date":"2012-01-19 20:33:10.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"all":[{"value":0,"date":"2012-01-19 19:41:50.000000000","_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":1,"date":"2012-01-19 19:42:22.000000000","_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-01-16 18:02:44.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2012-01-19 19:42:22.000000000","updated_by":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"reviewer":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"state":"REVIEWER"},{"updated":"2012-01-20 02:10:57.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6dcc570e3809e52667aed9e774ce13ee987e8943","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2012-01-16 18:02:44.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"a00a7476c3de5cb11e08af37afef8d4619d205b4","author":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"date":"2012-01-16 23:57:50.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"df8f57b3dc1dc24114379a089f853d19af5dea68","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-01-17 00:30:34.000000000","message":"Patch Set 1: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/516/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-json/160/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-pep8/683/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-pylint/747/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-unittests/244/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-keystone-merge/630/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2624ca889cacfd2c0419dd2ea53ccc7a55ff386a","author":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"date":"2012-01-17 00:52:05.000000000","message":"Patch Set 1:\n\nRetrying - looks like Jenkins could not get to the repo...","accounts_in_message":[],"_revision_number":1},{"id":"d640ad25107a2a283317bcc87999a8f33aca6ed4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-01-17 01:12:20.000000000","message":"Patch Set 1:\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/520/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-json/161/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-pep8/684/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-keystone-pylint/748/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-unittests/245/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-merge/631/ : This change was unable to be automatically merged  with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"a27d4efaa895df8c171b89c50c5ff180ea3d8c22","author":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"date":"2012-01-19 18:45:00.000000000","message":"Patch Set 1:\n\nRetrying","accounts_in_message":[],"_revision_number":1},{"id":"32a336f5395a7f47cba7f80e394381187042f6ef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-01-19 19:40:38.000000000","message":"Patch Set 1:\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/615/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-json/170/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-pep8/695/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-pylint/759/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-unittests/258/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-merge/645/ : This change was unable to be automatically merged  with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"a2c3b22753f69eb58c7393b4e35bd0a5c0951d3d","author":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"date":"2012-01-19 19:41:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"80b40f8c63dc53db152909f8472fdcc7233a0136","author":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"date":"2012-01-19 19:42:22.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nRebased","accounts_in_message":[],"_revision_number":2},{"id":"af12aacce9de5bd5a17a0058318772b2f154bf81","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-01-19 20:33:10.000000000","message":"Patch Set 2: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/620/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-json/172/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-pep8/697/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-pylint/761/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-unittests/260/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-keystone-merge/647/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"6df484e4a186702e24a54a0239ddadee477be5c4","author":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"date":"2012-01-19 22:20:17.000000000","message":"Patch Set 2:\n\nRetry","accounts_in_message":[],"_revision_number":2},{"id":"6cdc82e5e635cfd82117cd2becf231f7508b31c1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-01-19 22:30:43.000000000","message":"Patch Set 2:\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/630/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-json/180/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-pep8/705/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-pylint/769/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-unittests/268/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-keystone-merge/655/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"0eb8bbae71138d14694c9deb87c9da7baf9ad189","author":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"date":"2012-01-20 01:36:06.000000000","message":"Patch Set 2:\n\nRetry","accounts_in_message":[],"_revision_number":2},{"id":"f8d4c9e6633082e6cecc1d9c7d174655deb12bf1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-01-20 01:52:11.000000000","message":"Patch Set 2:\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/636/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-json/183/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-pep8/708/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-keystone-pylint/772/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-unittests/271/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-merge/658/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"b41ceab01a388451947a3a072072723ed1908942","author":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"date":"2012-01-20 01:53:55.000000000","message":"Patch Set 2:\n\nKeep retrying...","accounts_in_message":[],"_revision_number":2},{"id":"eb1a091a15c8d011e71ec97ce61d384e2bc4ad5e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-01-20 02:10:57.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/638/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-json/185/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-pep8/710/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-pylint/774/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-unittests/273/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-keystone-merge/660/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"5f7ce96f75ec9e4076e4eacfc666ab3fe77d2ed2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-01-20 02:11:02.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7c0529fac859c9131aae3986d81fdb10810a49c1","revisions":{"b34f969e961a125c57a04c4705a76ed34a85be53":{"kind":"REWORK","_number":1,"created":"2012-01-13 22:26:42.000000000","uploader":{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},"ref":"refs/changes/47/3047/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/47/3047/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/47/3047/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/47/3047/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/47/3047/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/47/3047/1"}}},"commit":{"parents":[{"commit":"4d85d09f8981881526e92632968c330631196061","subject":"Merge \"Show useful traceback if manage command fails\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/4d85d09f8981881526e92632968c330631196061"}]}],"author":{"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","date":"2012-01-13 22:01:34.000000000","tz":-480},"committer":{"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","date":"2012-01-13 22:23:01.000000000","tz":-480},"subject":"Bug #916199: keystone-manage service list fails with AttributeError on Service.description","message":"Bug #916199: keystone-manage service list fails with AttributeError on Service.description\n\nMake sqlalchemy.api.service take a keystone.models.Service into create, and\nreturn the same from get_all.  This replaces their use of\nsqlalchemy.models.Service in these positions.  This is consistent with\nUser, Tenant, Token, and fixes the bug referenced above.\n\nAdded unit tests for keystone.manage.api.{list_services,add_service,\nadd_token}.  The latter isn\u0027t actually related to this bug (that call turned\nout to be working fine) but I\u0027ve written it so you may as well have it!\n\nFix tearDown in test_backends.  These tests were leaving the DB layer in an\ninvalid state, so the subsequent test_commands_v1 tests couldn\u0027t initialize.\n\nChange-Id: I63e24189832cb96454c085797bff4c5c09e10b70\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/b34f969e961a125c57a04c4705a76ed34a85be53"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/b34f969e961a125c57a04c4705a76ed34a85be53"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4d85d09f8981881526e92632968c330631196061","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"7c0529fac859c9131aae3986d81fdb10810a49c1":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2012-01-19 19:41:50.000000000","uploader":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"ref":"refs/changes/47/3047/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/47/3047/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/47/3047/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/47/3047/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/47/3047/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/47/3047/2"}}},"commit":{"parents":[{"commit":"8d9ace78ee467a7c866d74343a1f50d9a3afc670","subject":"Merge \"Revert \"Exception raise error\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/8d9ace78ee467a7c866d74343a1f50d9a3afc670"}]}],"author":{"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","date":"2012-01-13 22:01:34.000000000","tz":-480},"committer":{"name":"Ziad Sawalha","email":"github@highbridgellc.com","date":"2012-01-19 19:41:31.000000000","tz":-360},"subject":"Bug #916199: keystone-manage service list fails with AttributeError on Service.description","message":"Bug #916199: keystone-manage service list fails with AttributeError on Service.description\n\nMake sqlalchemy.api.service take a keystone.models.Service into create, and\nreturn the same from get_all.  This replaces their use of\nsqlalchemy.models.Service in these positions.  This is consistent with\nUser, Tenant, Token, and fixes the bug referenced above.\n\nAdded unit tests for keystone.manage.api.{list_services,add_service,\nadd_token}.  The latter isn\u0027t actually related to this bug (that call turned\nout to be working fine) but I\u0027ve written it so you may as well have it!\n\nFix tearDown in test_backends.  These tests were leaving the DB layer in an\ninvalid state, so the subsequent test_commands_v1 tests couldn\u0027t initialize.\n\nChange-Id: I63e24189832cb96454c085797bff4c5c09e10b70\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/7c0529fac859c9131aae3986d81fdb10810a49c1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/7c0529fac859c9131aae3986d81fdb10810a49c1"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"8d9ace78ee467a7c866d74343a1f50d9a3afc670","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}