)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f321659f605c5cb774d877f48ce72518a3130691","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Live SQL migration tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Make it possible to run the migration tests for the supported databases"},{"line_number":10,"context_line":"without editing the config files."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iaf14ad42333b0a0cd1f7d0fb37f135a8bf7af14a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAPH%2F%2Fprg%3D","line":10,"updated":"2013-05-28 15:29:01.000000000","message":"Does this pertain to a bug or blueprint?","commit_id":"f3ecc229becfdffb28f543dac7371fca85bb347a"}],"tests/_sql_livetest.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"757fade84e1b8acdbc2bfb76a7458c3885da0ee2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def config_files(self):"},{"line_number":34,"context_line":"        files \u003d (test_sql_upgrade.SqlUpgradeTests."},{"line_number":35,"context_line":"                 _config_file_list[:])"},{"line_number":36,"context_line":"        files.append(\"backend_mysql.conf\")"},{"line_number":37,"context_line":"        return files"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2FgK8%3D","line":36,"updated":"2013-05-31 18:28:54.000000000","message":"suggest having a base class to share this code between the 2 tests:\n\n class LiveMigrateTests...:\n    extra_config_file \u003d None\n\n    def config_files(...)\n\nThen just need to set extra_config_file in Postgres / Mysql","commit_id":"62abd5d85384416dc05aa0a449dab1694caec3e8"}],"tests/backend_mysql.conf":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b16d5a15abbaf8263130aaa8483a78a18016abb3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[sql]"},{"line_number":2,"context_line":"connection \u003d mysql://keystone:keystone@localhost/keystone?charset\u003dutf8"}],"source_content_type":"text/plain","patch_set":3,"id":"AAAAPH%2F%2Fk8g%3D","line":1,"updated":"2013-05-30 04:44:27.000000000","message":"definitely throw a comment into these new files regarding where they\u0027re used / what they\u0027re for... it\u0027d be way too easy to come along and notice some unused configuration files that happen to still pass gating when you delete them","commit_id":"f3ecc229becfdffb28f543dac7371fca85bb347a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"964a12c0560128ea2a4a74276730f1b986e65190","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[sql]"},{"line_number":2,"context_line":"connection \u003d mysql://keystone:keystone@localhost/keystone?charset\u003dutf8"}],"source_content_type":"text/plain","patch_set":3,"id":"AAAAPH%2F%2FinU%3D","line":2,"updated":"2013-05-30 22:00:06.000000000","message":"\"keystone\" is the same database used for devstack. It would be easier for me if it was a different database (keystone-test or something).\n\nIt might be easier if there was a way to pass in the name of this file so that I don\u0027t have to modify a file in git to use a different password.","commit_id":"f3ecc229becfdffb28f543dac7371fca85bb347a"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"e20833b50f71a42bc80bedbdfb35b9f3756a6279","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[sql]"},{"line_number":2,"context_line":"connection \u003d mysql://keystone:keystone@localhost/keystone?charset\u003dutf8"}],"source_content_type":"text/plain","patch_set":3,"id":"AAAAPH%2F%2FiOI%3D","line":2,"in_reply_to":"AAAAPH%2F%2FinU%3D","updated":"2013-05-31 13:43:03.000000000","message":"Hrm...I intentionally matched the devstack setup because that way I know my database is initialized.","commit_id":"f3ecc229becfdffb28f543dac7371fca85bb347a"}],"tests/test_sql_upgrade.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b16d5a15abbaf8263130aaa8483a78a18016abb3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        super(SqlUpgradeTests, self).setUp()"},{"line_number":55,"context_line":"        self.config([test.etcdir(\u0027keystone.conf.sample\u0027),"},{"line_number":56,"context_line":"                     test.testsdir(\u0027test_overrides.conf\u0027),"},{"line_number":57,"context_line":"                     test.testsdir(\u0027backend_sql.conf\u0027)])"},{"line_number":58,"context_line":"        self.base \u003d sql.Base()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # create and share a single sqlalchemy engine for testing"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Fk8Y%3D","side":"PARENT","line":57,"updated":"2013-05-30 04:44:27.000000000","message":"why not just make the list itself a class attribute that can be overridden or modified?","commit_id":"af4e96986f6ee45e9e4ccac0b143902362a1a676"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"e20833b50f71a42bc80bedbdfb35b9f3756a6279","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        super(SqlUpgradeTests, self).setUp()"},{"line_number":55,"context_line":"        self.config([test.etcdir(\u0027keystone.conf.sample\u0027),"},{"line_number":56,"context_line":"                     test.testsdir(\u0027test_overrides.conf\u0027),"},{"line_number":57,"context_line":"                     test.testsdir(\u0027backend_sql.conf\u0027)])"},{"line_number":58,"context_line":"        self.base \u003d sql.Base()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # create and share a single sqlalchemy engine for testing"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2FhBA%3D","side":"PARENT","line":57,"in_reply_to":"AAAAPH%2F%2Fk8Y%3D","updated":"2013-05-31 13:43:03.000000000","message":"Done","commit_id":"af4e96986f6ee45e9e4ccac0b143902362a1a676"}]}