)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"bca7ed6e2b8f8e467bff9dcbeebc01368fc6752a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"need to keep this around. In addition to the deprecation I\u0027ve removed it"},{"line_number":11,"context_line":"from the default pipelines."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"bp deprecated-as-of-newton"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6deb66eb1450d76ac246a91f8cf9e1e3a417e39e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a77a97e_46cdb064","line":13,"range":{"start_line":13,"start_character":20,"end_line":13,"end_character":26},"updated":"2016-11-20 04:28:31.000000000","message":"ocata*","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"8cf151c7c63c252aad12c46714fde899423350b8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"need to keep this around. In addition to the deprecation I\u0027ve removed it"},{"line_number":11,"context_line":"from the default pipelines."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"bp deprecated-as-of-newton"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6deb66eb1450d76ac246a91f8cf9e1e3a417e39e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a74a57a_8deb5a12","line":13,"range":{"start_line":13,"start_character":20,"end_line":13,"end_character":26},"in_reply_to":"7a77a97e_46cdb064","updated":"2016-11-29 16:49:10.000000000","message":"Done","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"}],"etc/keystone-paste.ini":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"c699820ea0a92a628d5980e3535d8514336dad87","unresolved":false,"context_lines":[{"line_number":13,"context_line":"use \u003d egg:keystone#token_auth"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[filter:admin_token_auth]"},{"line_number":16,"context_line":"# This is deprecated in the M release and will be removed in the O release."},{"line_number":17,"context_line":"# Use `keystone-manage bootstrap` and remove this from the pipelines below."},{"line_number":18,"context_line":"use \u003d egg:keystone#admin_token_auth"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[filter:json_body]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1aa78d24_b37ffca9","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":75},"updated":"2016-07-06 13:52:50.000000000","message":"This is saying it was already deprecated, which is odd","commit_id":"6917389f1e8bc18c0e4edc5a47cf358ca40850ca"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"e4c098893eb21bb01df05ee1d2005db19cd0d2c8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"use \u003d egg:keystone#token_auth"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[filter:admin_token_auth]"},{"line_number":16,"context_line":"# This is deprecated in the M release and will be removed in the O release."},{"line_number":17,"context_line":"# Use `keystone-manage bootstrap` and remove this from the pipelines below."},{"line_number":18,"context_line":"use \u003d egg:keystone#admin_token_auth"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[filter:json_body]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1aa78d24_ce377ffd","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":75},"in_reply_to":"1aa78d24_b37ffca9","updated":"2016-07-06 14:09:41.000000000","message":"Indeed. It seemed to me that we have deprecated it in Mitaka and i think i saw a warning about it in the logs.","commit_id":"6917389f1e8bc18c0e4edc5a47cf358ca40850ca"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"4e6ad16d9665ac5428300749c48318b6ac802b59","unresolved":false,"context_lines":[{"line_number":60,"context_line":"[pipeline:public_api]"},{"line_number":61,"context_line":"# The last item in this pipeline must be public_service or an equivalent"},{"line_number":62,"context_line":"# application. It cannot be a filter."},{"line_number":63,"context_line":"pipeline \u003d healthcheck cors sizelimit http_proxy_to_wsgi osprofiler url_normalize request_id admin_token_auth build_auth_context token_auth json_body ec2_extension public_service"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"[pipeline:admin_api]"},{"line_number":66,"context_line":"# The last item in this pipeline must be admin_service or an equivalent"}],"source_content_type":"text/x-properties","patch_set":5,"id":"7a77a97e_2a0f79e2","side":"PARENT","line":63,"range":{"start_line":63,"start_character":93,"end_line":63,"end_character":109},"updated":"2016-11-15 03:15:36.000000000","message":"I\u0027d like keep this around until the admin token auth middleware is actually removed, with this patch merged users need add back this into pipeline while the middleware is just deprecated.","commit_id":"3d513daeb3b4e492834946511404c7950050f90b"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"159767004f0e596a370b65c0a44b1866c610a6d4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"[pipeline:public_api]"},{"line_number":61,"context_line":"# The last item in this pipeline must be public_service or an equivalent"},{"line_number":62,"context_line":"# application. It cannot be a filter."},{"line_number":63,"context_line":"pipeline \u003d healthcheck cors sizelimit http_proxy_to_wsgi osprofiler url_normalize request_id admin_token_auth build_auth_context token_auth json_body ec2_extension public_service"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"[pipeline:admin_api]"},{"line_number":66,"context_line":"# The last item in this pipeline must be admin_service or an equivalent"}],"source_content_type":"text/x-properties","patch_set":5,"id":"7a77a97e_ce77e7d2","side":"PARENT","line":63,"range":{"start_line":63,"start_character":93,"end_line":63,"end_character":109},"in_reply_to":"7a77a97e_2a0f79e2","updated":"2016-11-15 12:00:56.000000000","message":"We don\u0027t want people to use it so I don\u0027t now why we\u0027d keep it in the pipeline. If someone really wants to use it they can add it back.","commit_id":"3d513daeb3b4e492834946511404c7950050f90b"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"4e6ad16d9665ac5428300749c48318b6ac802b59","unresolved":false,"context_lines":[{"line_number":12,"context_line":"[filter:token_auth]"},{"line_number":13,"context_line":"use \u003d egg:keystone#token_auth"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[filter:admin_token_auth]"},{"line_number":16,"context_line":"# This is deprecated in the N release and will be removed in the P release."},{"line_number":17,"context_line":"# Use `keystone-manage bootstrap` and remove this from the pipelines below."},{"line_number":18,"context_line":"use \u003d egg:keystone#admin_token_auth"}],"source_content_type":"text/x-properties","patch_set":5,"id":"7a77a97e_cac5255c","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":25},"updated":"2016-11-15 03:15:36.000000000","message":"If this is pulled off from the pipeline why we need this hang around?","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"159767004f0e596a370b65c0a44b1866c610a6d4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"[filter:token_auth]"},{"line_number":13,"context_line":"use \u003d egg:keystone#token_auth"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[filter:admin_token_auth]"},{"line_number":16,"context_line":"# This is deprecated in the N release and will be removed in the P release."},{"line_number":17,"context_line":"# Use `keystone-manage bootstrap` and remove this from the pipelines below."},{"line_number":18,"context_line":"use \u003d egg:keystone#admin_token_auth"}],"source_content_type":"text/x-properties","patch_set":5,"id":"7a77a97e_4ebcb76c","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":25},"in_reply_to":"7a77a97e_cac5255c","updated":"2016-11-15 12:00:56.000000000","message":"To make keeping the tests around easier. I dynamically add the middleware back into the pipeline so that we can still test it.","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"bca7ed6e2b8f8e467bff9dcbeebc01368fc6752a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"use \u003d egg:keystone#token_auth"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[filter:admin_token_auth]"},{"line_number":16,"context_line":"# This is deprecated in the N release and will be removed in the P release."},{"line_number":17,"context_line":"# Use `keystone-manage bootstrap` and remove this from the pipelines below."},{"line_number":18,"context_line":"use \u003d egg:keystone#admin_token_auth"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-properties","patch_set":5,"id":"7a77a97e_86c34837","line":16,"range":{"start_line":16,"start_character":28,"end_line":16,"end_character":29},"updated":"2016-11-20 04:28:31.000000000","message":"O","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"bca7ed6e2b8f8e467bff9dcbeebc01368fc6752a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"use \u003d egg:keystone#token_auth"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[filter:admin_token_auth]"},{"line_number":16,"context_line":"# This is deprecated in the N release and will be removed in the P release."},{"line_number":17,"context_line":"# Use `keystone-manage bootstrap` and remove this from the pipelines below."},{"line_number":18,"context_line":"use \u003d egg:keystone#admin_token_auth"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-properties","patch_set":5,"id":"7a77a97e_c6df000b","line":16,"range":{"start_line":16,"start_character":65,"end_line":16,"end_character":66},"updated":"2016-11-20 04:28:31.000000000","message":"Q","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"8cf151c7c63c252aad12c46714fde899423350b8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"use \u003d egg:keystone#token_auth"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[filter:admin_token_auth]"},{"line_number":16,"context_line":"# This is deprecated in the N release and will be removed in the P release."},{"line_number":17,"context_line":"# Use `keystone-manage bootstrap` and remove this from the pipelines below."},{"line_number":18,"context_line":"use \u003d egg:keystone#admin_token_auth"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-properties","patch_set":5,"id":"5a74a57a_0dc74a96","line":16,"range":{"start_line":16,"start_character":28,"end_line":16,"end_character":29},"in_reply_to":"7a77a97e_86c34837","updated":"2016-11-29 16:49:10.000000000","message":"Done","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"8cf151c7c63c252aad12c46714fde899423350b8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"use \u003d egg:keystone#token_auth"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[filter:admin_token_auth]"},{"line_number":16,"context_line":"# This is deprecated in the N release and will be removed in the P release."},{"line_number":17,"context_line":"# Use `keystone-manage bootstrap` and remove this from the pipelines below."},{"line_number":18,"context_line":"use \u003d egg:keystone#admin_token_auth"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-properties","patch_set":5,"id":"5a74a57a_4dbdc200","line":16,"range":{"start_line":16,"start_character":65,"end_line":16,"end_character":66},"in_reply_to":"7a77a97e_c6df000b","updated":"2016-11-29 16:49:10.000000000","message":"Done","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6ec3e59053c7a8b5b76f7ba0b52687dfcd6832b0","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[filter:admin_token_auth]"},{"line_number":16,"context_line":"# This is deprecated in the O release and will be removed in the Q release."},{"line_number":17,"context_line":"# Use `keystone-manage bootstrap` and remove this from the pipelines below."},{"line_number":18,"context_line":"use \u003d egg:keystone#admin_token_auth"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[filter:json_body]"}],"source_content_type":"text/x-properties","patch_set":7,"id":"5a74a57a_9c3b579c","line":17,"updated":"2016-11-30 15:14:21.000000000","message":"This is already removed from the pipelines.","commit_id":"3271fc121c227c03fb2827c177d2f6578c0a0622"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"bd96cfe067c8ad2ef6637aac9e583ea1d9600cc3","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[filter:admin_token_auth]"},{"line_number":16,"context_line":"# This is deprecated in the O release and will be removed in the Q release."},{"line_number":17,"context_line":"# Use `keystone-manage bootstrap` and remove this from the pipelines below."},{"line_number":18,"context_line":"use \u003d egg:keystone#admin_token_auth"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[filter:json_body]"}],"source_content_type":"text/x-properties","patch_set":7,"id":"1a6eadb0_7b03b8b8","line":17,"in_reply_to":"5a74a57a_9c3b579c","updated":"2016-12-20 13:02:11.000000000","message":"I am seeing admin_token_auth being removed from the pipelines in this patch. Is it something I am not seeing ?","commit_id":"3271fc121c227c03fb2827c177d2f6578c0a0622"}],"keystone/middleware/core.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"bca7ed6e2b8f8e467bff9dcbeebc01368fc6752a","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @versionutils.deprecated("},{"line_number":63,"context_line":"        what\u003d\u0027keystone.middleware.AdminTokenAuthMiddleware\u0027,"},{"line_number":64,"context_line":"        as_of\u003dversionutils.deprecated.NEWTON,"},{"line_number":65,"context_line":"        remove_in\u003d+2)"},{"line_number":66,"context_line":"    def __init__(self, application):"},{"line_number":67,"context_line":"        super(AdminTokenAuthMiddleware, self).__init__(application)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_e6e23cd4","line":64,"range":{"start_line":64,"start_character":38,"end_line":64,"end_character":44},"updated":"2016-11-20 04:28:31.000000000","message":"OCATA*","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"8cf151c7c63c252aad12c46714fde899423350b8","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @versionutils.deprecated("},{"line_number":63,"context_line":"        what\u003d\u0027keystone.middleware.AdminTokenAuthMiddleware\u0027,"},{"line_number":64,"context_line":"        as_of\u003dversionutils.deprecated.NEWTON,"},{"line_number":65,"context_line":"        remove_in\u003d+2)"},{"line_number":66,"context_line":"    def __init__(self, application):"},{"line_number":67,"context_line":"        super(AdminTokenAuthMiddleware, self).__init__(application)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_cd5632cd","line":64,"range":{"start_line":64,"start_character":38,"end_line":64,"end_character":44},"in_reply_to":"7a77a97e_e6e23cd4","updated":"2016-11-29 16:49:10.000000000","message":"Done","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"}],"keystone/tests/unit/test_no_admin_token_auth.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7668965124ee02e7e9b794064c470cde626ad773","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from keystone.tests.unit.ksfixtures import database"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TestNoAdminTokenAuth(unit.TestCase):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def setUp(self):"},{"line_number":25,"context_line":"        super(TestNoAdminTokenAuth, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_17759d62","line":22,"updated":"2016-11-29 15:17:19.000000000","message":"We don\u0027t need this test anymore since all the tests will run with no admin token in the pipeline. There\u0027s already a test that verifies that admin token still works when added to the pipeline, so this file can just be removed.","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"8cf151c7c63c252aad12c46714fde899423350b8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from keystone.tests.unit.ksfixtures import database"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TestNoAdminTokenAuth(unit.TestCase):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def setUp(self):"},{"line_number":25,"context_line":"        super(TestNoAdminTokenAuth, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_8d4c3a9f","line":22,"in_reply_to":"5a74a57a_17759d62","updated":"2016-11-29 16:49:10.000000000","message":"Done","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7668965124ee02e7e9b794064c470cde626ad773","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TestNoAdminTokenAuth(unit.TestCase):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def setUp(self):"},{"line_number":25,"context_line":"        super(TestNoAdminTokenAuth, self).setUp()"},{"line_number":26,"context_line":"        self.useFixture(database.Database())"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_97eb6d12","line":23,"updated":"2016-11-29 15:17:19.000000000","message":"revert this unrelated change.","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"}],"keystone/tests/unit/test_v3_identity.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7668965124ee02e7e9b794064c470cde626ad773","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        # NOTE(dstanek): The tailing space is significant. Without it the code"},{"line_number":65,"context_line":"        # would mangle the filter declaration."},{"line_number":66,"context_line":"        new_contents \u003d contents.replace(\u0027request_id \u0027,"},{"line_number":67,"context_line":"                                        \u0027request_id admin_token_auth \u0027)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        filename \u003d unit.dirs.tmp(\u0027admin_token_auth-paste.ini\u0027)"},{"line_number":70,"context_line":"        with open(filename, \u0027w\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_77a7b1a6","line":67,"range":{"start_line":67,"start_character":52,"end_line":67,"end_character":68},"updated":"2016-11-29 15:17:19.000000000","message":"this is EXTENSION_TO_ADD, so use that, or remove EXTENSION_TO_ADD since it\u0027s apparently not working correctly in this case anyways.\n\nIf there\u0027s nothing using EXTENSION_TO_ADD anymore then support for it should be removed.","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"68d2b64edcf1feebbae06a67a81c73b0945895e1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        # NOTE(dstanek): The tailing space is significant. Without it the code"},{"line_number":65,"context_line":"        # would mangle the filter declaration."},{"line_number":66,"context_line":"        new_contents \u003d contents.replace(\u0027request_id \u0027,"},{"line_number":67,"context_line":"                                        \u0027request_id admin_token_auth \u0027)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        filename \u003d unit.dirs.tmp(\u0027admin_token_auth-paste.ini\u0027)"},{"line_number":70,"context_line":"        with open(filename, \u0027w\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_84e33033","line":67,"range":{"start_line":67,"start_character":52,"end_line":67,"end_character":68},"in_reply_to":"5a74a57a_77a7b1a6","updated":"2016-11-29 17:10:31.000000000","message":"We actually don\u0027t have that anymore. I\u0027ve done a little cleanup for that: https://review.openstack.org/404350","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6ec3e59053c7a8b5b76f7ba0b52687dfcd6832b0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        super(IdentityTestCaseStaticAdminToken, self).setUp()"},{"line_number":47,"context_line":"        self._generate_paste_config()"},{"line_number":48,"context_line":"        self.useFixture(database.Database())"},{"line_number":49,"context_line":"        self.load_backends()"},{"line_number":50,"context_line":"        self.domain_id \u003d \u0027default\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.admin_app \u003d webtest.TestApp("}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_1cad8731","line":49,"updated":"2016-11-30 15:14:21.000000000","message":"isn\u0027t loading the app going to load the backends?","commit_id":"3271fc121c227c03fb2827c177d2f6578c0a0622"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6ec3e59053c7a8b5b76f7ba0b52687dfcd6832b0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self._generate_paste_config()"},{"line_number":48,"context_line":"        self.useFixture(database.Database())"},{"line_number":49,"context_line":"        self.load_backends()"},{"line_number":50,"context_line":"        self.domain_id \u003d \u0027default\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.admin_app \u003d webtest.TestApp("},{"line_number":53,"context_line":"            self.loadapp(unit.dirs.tmp(\u0027admin_token_auth\u0027), name\u003d\u0027admin\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_5c1d3fbc","line":50,"updated":"2016-11-30 15:14:21.000000000","message":"this is only used in 1 place, so suggest just hard-code it there, or use CONF.default_domain_id there.","commit_id":"3271fc121c227c03fb2827c177d2f6578c0a0622"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6ec3e59053c7a8b5b76f7ba0b52687dfcd6832b0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.domain_id \u003d \u0027default\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.admin_app \u003d webtest.TestApp("},{"line_number":53,"context_line":"            self.loadapp(unit.dirs.tmp(\u0027admin_token_auth\u0027), name\u003d\u0027admin\u0027),"},{"line_number":54,"context_line":"            extra_environ\u003ddict(REMOTE_ADDR\u003d\u0027127.0.0.1\u0027))"},{"line_number":55,"context_line":"        self.addCleanup(setattr, self, \u0027admin_app\u0027, None)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_1c510763","line":53,"updated":"2016-11-30 15:14:21.000000000","message":"it would probably be safer to use public_app rather than admin_app, since admin_app will go away with v2.","commit_id":"3271fc121c227c03fb2827c177d2f6578c0a0622"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6ec3e59053c7a8b5b76f7ba0b52687dfcd6832b0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        filename \u003d unit.dirs.tmp(\u0027admin_token_auth-paste.ini\u0027)"},{"line_number":69,"context_line":"        with open(filename, \u0027w\u0027) as f:"},{"line_number":70,"context_line":"            f.write(new_contents)"},{"line_number":71,"context_line":"        self.addCleanup(os.remove, filename)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def config_overrides(self):"},{"line_number":74,"context_line":"        super(IdentityTestCaseStaticAdminToken, self).config_overrides()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_fcd0cbf9","line":71,"updated":"2016-11-30 15:14:21.000000000","message":"This could cause a problem if tests are run in parallel, since one process could remove the file that another test is about to use. The files should be named uniquely.","commit_id":"3271fc121c227c03fb2827c177d2f6578c0a0622"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"bd96cfe067c8ad2ef6637aac9e583ea1d9600cc3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        filename \u003d unit.dirs.tmp(\u0027admin_token_auth-paste.ini\u0027)"},{"line_number":69,"context_line":"        with open(filename, \u0027w\u0027) as f:"},{"line_number":70,"context_line":"            f.write(new_contents)"},{"line_number":71,"context_line":"        self.addCleanup(os.remove, filename)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def config_overrides(self):"},{"line_number":74,"context_line":"        super(IdentityTestCaseStaticAdminToken, self).config_overrides()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_1bb724f6","line":71,"in_reply_to":"5a74a57a_fcd0cbf9","updated":"2016-12-20 13:02:11.000000000","message":"++","commit_id":"3271fc121c227c03fb2827c177d2f6578c0a0622"}],"releasenotes/notes/deprecate-admin-token-auth-middleware-7fcaf48266ef1235.yaml":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5ece529e66fc9155f99f8c1e843960ad664012d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7a77a97e_e6095c96","updated":"2016-11-20 04:32:44.000000000","message":"add this note to the existing deprecated-as-of-ocata one?\n\nhttps://github.com/openstack/keystone/blob/master/releasenotes/notes/deprecated-as-of-ocata-a5b2f1e3e39f818e.yaml","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"8cf151c7c63c252aad12c46714fde899423350b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5a74a57a_2d93265c","in_reply_to":"7a77a97e_e6095c96","updated":"2016-11-29 16:49:10.000000000","message":"Done","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5ece529e66fc9155f99f8c1e843960ad664012d1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`blueprint deprecated-as-of-ocata \u003chttps://blueprints.launchpad.net/keystone/+spec/deprecated-as-of-ocata\u003e`_]"},{"line_number":5,"context_line":"    As of the Ocata release, the admin token auth middleware (`keystone.middleware.AdminTokenAuthMiddleware`)"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a77a97e_c6062085","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":13},"updated":"2016-11-20 04:32:44.000000000","message":"we should add something about this in the prelude section:\n\n---\nprelude: \u003e\n  - Using the ``admin token auth`` middleware is now deprecated. See ``deprecations`` for more details.","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"8cf151c7c63c252aad12c46714fde899423350b8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`blueprint deprecated-as-of-ocata \u003chttps://blueprints.launchpad.net/keystone/+spec/deprecated-as-of-ocata\u003e`_]"},{"line_number":5,"context_line":"    As of the Ocata release, the admin token auth middleware (`keystone.middleware.AdminTokenAuthMiddleware`)"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a74a57a_ada656be","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":13},"in_reply_to":"7a77a97e_c6062085","updated":"2016-11-29 16:49:10.000000000","message":"Done","commit_id":"febf17cedcd86d3b478c17d6b53a402fa24b1b04"}],"releasenotes/notes/deprecated-as-of-ocata-a5b2f1e3e39f818e.yaml":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6ec3e59053c7a8b5b76f7ba0b52687dfcd6832b0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"  - Using the ``admin token auth`` middleware is now deprecated. See ``deprecations`` for more details."},{"line_number":4,"context_line":"deprecations:"},{"line_number":5,"context_line":"  - \u003e"},{"line_number":6,"context_line":"    [`blueprint deprecated-as-of-ocata \u003chttps://blueprints.launchpad.net/keystone/+spec/deprecated-as-of-ocata\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a74a57a_b008372a","line":3,"updated":"2016-11-30 15:14:21.000000000","message":"suggest keep the lines shorter so that it\u0027s easier to review.","commit_id":"3271fc121c227c03fb2827c177d2f6578c0a0622"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6ec3e59053c7a8b5b76f7ba0b52687dfcd6832b0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    removed in the `Pike` release."},{"line_number":12,"context_line":"  - \u003e"},{"line_number":13,"context_line":"    [`blueprint deprecated-as-of-ocata \u003chttps://blueprints.launchpad.net/keystone/+spec/deprecated-as-of-ocata\u003e`_]"},{"line_number":14,"context_line":"    As of the Ocata release, the admin token auth middleware (`keystone.middleware.AdminTokenAuthMiddleware`)"},{"line_number":15,"context_line":"    has been deprecated. Please use the `keystone-manage bootstrap"},{"line_number":16,"context_line":"    \u003chttp://docs.openstack.org/developer/keystone/configuringservices.html#setting-up-credentials-with-keystone-manage-bootstrap\u003e`_"},{"line_number":17,"context_line":"    command instead to bootstrap keystone. It will be removed in the \u0027Q\u0027 release."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a74a57a_d05bf32c","line":14,"updated":"2016-11-30 15:14:21.000000000","message":"might also want to mention the egg: keystone#admin_token_auth\n\nsince this is what\u0027s in some paste configs.","commit_id":"3271fc121c227c03fb2827c177d2f6578c0a0622"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6ec3e59053c7a8b5b76f7ba0b52687dfcd6832b0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    As of the Ocata release, the admin token auth middleware (`keystone.middleware.AdminTokenAuthMiddleware`)"},{"line_number":15,"context_line":"    has been deprecated. Please use the `keystone-manage bootstrap"},{"line_number":16,"context_line":"    \u003chttp://docs.openstack.org/developer/keystone/configuringservices.html#setting-up-credentials-with-keystone-manage-bootstrap\u003e`_"},{"line_number":17,"context_line":"    command instead to bootstrap keystone. It will be removed in the \u0027Q\u0027 release."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a74a57a_909fbbb3","line":17,"range":{"start_line":17,"start_character":43,"end_line":17,"end_character":45},"updated":"2016-11-30 15:14:21.000000000","message":"To be clear that \"It\" is referring to the admin token auth middleware and not keystone-manage bootstrap, change this to \"The admin token auth middleware\".","commit_id":"3271fc121c227c03fb2827c177d2f6578c0a0622"}]}