)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2ee633737acdd4e5a689541e449f8b2d5842ef60","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make all fixture project_ids into uuids"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Fernet test for Python 34 fail id they are given"},{"line_number":10,"context_line":"project_ids that are not uuids. Since all issued"},{"line_number":11,"context_line":"project Ids in a live deployment are UUIDs, it is more"},{"line_number":12,"context_line":"correct to fix the tests than to change the formatter."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_5369a08a","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":37},"updated":"2016-04-18 20:12:52.000000000","message":"if","commit_id":"0728474eecd3d221e5dd76a0d5e19f43e8992f85"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"17528fc45ca0434f2407adc4e47fad0e04f1bfc0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make all fixture project_ids into uuids"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Fernet test for Python 34 fail id they are given"},{"line_number":10,"context_line":"project_ids that are not uuids. Since all issued"},{"line_number":11,"context_line":"project Ids in a live deployment are UUIDs, it is more"},{"line_number":12,"context_line":"correct to fix the tests than to change the formatter."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_cf53136a","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":37},"in_reply_to":"1a122d0e_5369a08a","updated":"2016-04-19 17:38:33.000000000","message":"Done","commit_id":"0728474eecd3d221e5dd76a0d5e19f43e8992f85"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2ee633737acdd4e5a689541e449f8b2d5842ef60","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Fernet test for Python 34 fail id they are given"},{"line_number":10,"context_line":"project_ids that are not uuids. Since all issued"},{"line_number":11,"context_line":"project Ids in a live deployment are UUIDs, it is more"},{"line_number":12,"context_line":"correct to fix the tests than to change the formatter."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I485c02cbb6484e52b4bb4563e2842c45a34e66eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_f3270c62","line":11,"updated":"2016-04-18 20:12:52.000000000","message":"they\u0027re not since we allow deployers to override the driver.","commit_id":"0728474eecd3d221e5dd76a0d5e19f43e8992f85"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"17528fc45ca0434f2407adc4e47fad0e04f1bfc0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Fernet test for Python 34 fail id they are given"},{"line_number":10,"context_line":"project_ids that are not uuids. Since all issued"},{"line_number":11,"context_line":"project Ids in a live deployment are UUIDs, it is more"},{"line_number":12,"context_line":"correct to fix the tests than to change the formatter."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I485c02cbb6484e52b4bb4563e2842c45a34e66eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_2f4d67c4","line":11,"in_reply_to":"1a122d0e_f3270c62","updated":"2016-04-19 17:38:33.000000000","message":"Done","commit_id":"0728474eecd3d221e5dd76a0d5e19f43e8992f85"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"d1ca3f33a3607d8ae618307058ef514035c9dcbd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make all fixture project_ids into uuids"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Fernet test for Python 34 fail id they are given"},{"line_number":10,"context_line":"project_ids that are not uuids. Since all issued"},{"line_number":11,"context_line":"project Ids in a live deployment are UUIDs, it is more"},{"line_number":12,"context_line":"correct to fix the tests than to change the formatter."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a122d0e_0d9efb06","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":37},"updated":"2016-05-03 21:51:13.000000000","message":"if","commit_id":"061f89749b61756264a5849ba74cb0d2be4292f6"}],"keystone/tests/unit/core.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2ee633737acdd4e5a689541e449f8b2d5842ef60","unresolved":false,"context_lines":[{"line_number":732,"context_line":"                fixtures_to_cleanup.append(attrname)"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"            for tenant in fixtures.TENANTS:"},{"line_number":735,"context_line":"                tenant_id \u003d \u0027tenant_%s\u0027 % tenant[\u0027name\u0027].lower()"},{"line_number":736,"context_line":"                if hasattr(self, tenant_id):"},{"line_number":737,"context_line":"                    try:"},{"line_number":738,"context_line":"                        # This will clear out any roles on the project as well"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_73f3fcd6","line":735,"updated":"2016-04-18 20:12:52.000000000","message":"this should be tenant_attr_name. It\u0027s confusing to call an attribute name an ID.","commit_id":"0728474eecd3d221e5dd76a0d5e19f43e8992f85"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"17528fc45ca0434f2407adc4e47fad0e04f1bfc0","unresolved":false,"context_lines":[{"line_number":732,"context_line":"                fixtures_to_cleanup.append(attrname)"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"            for tenant in fixtures.TENANTS:"},{"line_number":735,"context_line":"                tenant_id \u003d \u0027tenant_%s\u0027 % tenant[\u0027name\u0027].lower()"},{"line_number":736,"context_line":"                if hasattr(self, tenant_id):"},{"line_number":737,"context_line":"                    try:"},{"line_number":738,"context_line":"                        # This will clear out any roles on the project as well"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_cf01533a","line":735,"in_reply_to":"1a122d0e_73f3fcd6","updated":"2016-04-19 17:38:33.000000000","message":"Done","commit_id":"0728474eecd3d221e5dd76a0d5e19f43e8992f85"}],"keystone/tests/unit/default_fixtures.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2ee633737acdd4e5a689541e449f8b2d5842ef60","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# NOTE(dolph): please try to avoid additional fixtures if possible; test suite"},{"line_number":16,"context_line":"#              performance may be negatively affected."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BAR_TENANT_ID \u003d \"0ce32cd748454c3b95266ff0e70d986a\""},{"line_number":19,"context_line":"BAZ_TENANT_ID \u003d \"1bd50145c53f440f92dab29b34ffe345\""},{"line_number":20,"context_line":"MTU_TENANT_ID \u003d \"f3d44868a793426599669ab426b22a68\""},{"line_number":21,"context_line":"SERVICE_TENANT_ID \u003d \"8137db62a8d646aba8cfb3480e4377b5\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_13cba873","line":18,"updated":"2016-04-18 20:12:52.000000000","message":"use \u0027 for strings to be consistent with other strings in this file.\n\nAlso, use uuid.uuid4().hex.","commit_id":"0728474eecd3d221e5dd76a0d5e19f43e8992f85"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"17528fc45ca0434f2407adc4e47fad0e04f1bfc0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# NOTE(dolph): please try to avoid additional fixtures if possible; test suite"},{"line_number":16,"context_line":"#              performance may be negatively affected."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BAR_TENANT_ID \u003d \"0ce32cd748454c3b95266ff0e70d986a\""},{"line_number":19,"context_line":"BAZ_TENANT_ID \u003d \"1bd50145c53f440f92dab29b34ffe345\""},{"line_number":20,"context_line":"MTU_TENANT_ID \u003d \"f3d44868a793426599669ab426b22a68\""},{"line_number":21,"context_line":"SERVICE_TENANT_ID \u003d \"8137db62a8d646aba8cfb3480e4377b5\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_afcfb727","line":18,"in_reply_to":"1a122d0e_13cba873","updated":"2016-04-19 17:38:33.000000000","message":"Done","commit_id":"0728474eecd3d221e5dd76a0d5e19f43e8992f85"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"3f5d151f6b841ae85ecf4542b214f5b7cc23aabf","unresolved":false,"context_lines":[{"line_number":18,"context_line":"BAR_TENANT_ID \u003d \"0ce32cd748454c3b95266ff0e70d986a\""},{"line_number":19,"context_line":"BAZ_TENANT_ID \u003d \"1bd50145c53f440f92dab29b34ffe345\""},{"line_number":20,"context_line":"MTU_TENANT_ID \u003d \"f3d44868a793426599669ab426b22a68\""},{"line_number":21,"context_line":"SERVICE_TENANT_ID \u003d \"8137db62a8d646aba8cfb3480e4377b5\""},{"line_number":22,"context_line":"DEFAULT_DOMAIN_ID \u003d \u0027default\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"TENANTS \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_9b77d439","line":21,"updated":"2016-04-18 17:57:58.000000000","message":"what impact generate these IDs at runtime would have in the tests performance? I mean... you can\u0027t guarantee these are UUIDs in this way.","commit_id":"0728474eecd3d221e5dd76a0d5e19f43e8992f85"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"17528fc45ca0434f2407adc4e47fad0e04f1bfc0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"BAR_TENANT_ID \u003d \"0ce32cd748454c3b95266ff0e70d986a\""},{"line_number":19,"context_line":"BAZ_TENANT_ID \u003d \"1bd50145c53f440f92dab29b34ffe345\""},{"line_number":20,"context_line":"MTU_TENANT_ID \u003d \"f3d44868a793426599669ab426b22a68\""},{"line_number":21,"context_line":"SERVICE_TENANT_ID \u003d \"8137db62a8d646aba8cfb3480e4377b5\""},{"line_number":22,"context_line":"DEFAULT_DOMAIN_ID \u003d \u0027default\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"TENANTS \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_6ff0ff67","line":21,"in_reply_to":"1a122d0e_9b77d439","updated":"2016-04-19 17:38:33.000000000","message":"no impact, but no reason to, either","commit_id":"0728474eecd3d221e5dd76a0d5e19f43e8992f85"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"d8f044d86a0c8410163301be1e93323212dcc1ea","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# NOTE(dolph): please try to avoid additional fixtures if possible; test suite"},{"line_number":16,"context_line":"#              performance may be negatively affected."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BAR_TENANT_ID \u003d \u00270ce32cd748454c3b95266ff0e70d986a\u0027"},{"line_number":19,"context_line":"BAZ_TENANT_ID \u003d \u00271bd50145c53f440f92dab29b34ffe345\u0027"},{"line_number":20,"context_line":"MTU_TENANT_ID \u003d \u0027f3d44868a793426599669ab426b22a68\u0027"},{"line_number":21,"context_line":"SERVICE_TENANT_ID \u003d \u00278137db62a8d646aba8cfb3480e4377b5\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_d4e603af","line":18,"range":{"start_line":18,"start_character":17,"end_line":18,"end_character":49},"updated":"2016-04-19 19:13:43.000000000","message":"still need to use uuid.uuid4().hex?","commit_id":"1d66c1a7157cb0ece268a9adb64c0e5b64ffa2b1"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"45e94cdf2dbd99d54aefcda5f2eb9fa9f49e5fb7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# NOTE(dolph): please try to avoid additional fixtures if possible; test suite"},{"line_number":16,"context_line":"#              performance may be negatively affected."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BAR_TENANT_ID \u003d \u00270ce32cd748454c3b95266ff0e70d986a\u0027"},{"line_number":19,"context_line":"BAZ_TENANT_ID \u003d \u00271bd50145c53f440f92dab29b34ffe345\u0027"},{"line_number":20,"context_line":"MTU_TENANT_ID \u003d \u0027f3d44868a793426599669ab426b22a68\u0027"},{"line_number":21,"context_line":"SERVICE_TENANT_ID \u003d \u00278137db62a8d646aba8cfb3480e4377b5\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_23545b1f","line":18,"range":{"start_line":18,"start_character":17,"end_line":18,"end_character":49},"in_reply_to":"1a122d0e_720bbf8e","updated":"2016-04-19 21:32:03.000000000","message":"true... the only question is that leaving as strings, we can\u0027t be sure that they are uuids - what if someone in the future change them back to just names?","commit_id":"1d66c1a7157cb0ece268a9adb64c0e5b64ffa2b1"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"718a988ee1637cfc77842e53060d04ec988df35f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# NOTE(dolph): please try to avoid additional fixtures if possible; test suite"},{"line_number":16,"context_line":"#              performance may be negatively affected."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BAR_TENANT_ID \u003d \u00270ce32cd748454c3b95266ff0e70d986a\u0027"},{"line_number":19,"context_line":"BAZ_TENANT_ID \u003d \u00271bd50145c53f440f92dab29b34ffe345\u0027"},{"line_number":20,"context_line":"MTU_TENANT_ID \u003d \u0027f3d44868a793426599669ab426b22a68\u0027"},{"line_number":21,"context_line":"SERVICE_TENANT_ID \u003d \u00278137db62a8d646aba8cfb3480e4377b5\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_720bbf8e","line":18,"range":{"start_line":18,"start_character":17,"end_line":18,"end_character":49},"in_reply_to":"1a122d0e_d4e603af","updated":"2016-04-19 20:04:10.000000000","message":"So, this is a minor perf optimization.  THe strings themselves are the result of the CLI equivalent, but this prevents them from being run on in each import.  As written this way, they have minimal impact (just strings) but a call to random is actually dependant on VM entropy, and might slow things down a lot.","commit_id":"1d66c1a7157cb0ece268a9adb64c0e5b64ffa2b1"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"ba41c600ea0ab241d45d5a80e71900bdd137cf24","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#              performance may be negatively affected."},{"line_number":17,"context_line":"import uuid"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BAR_TENANT_ID \u003d uuid.uuid4().hex"},{"line_number":20,"context_line":"BAZ_TENANT_ID \u003d uuid.uuid4().hex"},{"line_number":21,"context_line":"MTU_TENANT_ID \u003d uuid.uuid4().hex"},{"line_number":22,"context_line":"SERVICE_TENANT_ID \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_d9af267b","line":19,"updated":"2016-04-20 15:24:11.000000000","message":"AHHH this won\u0027t work.  Each time they are implorted, they will be regernerated and not have consistant values.  Possibly ok, but certainly not what is meant.  Will roll back to previous.","commit_id":"60e2bb86a85b74ed673d7675a80ebf847b922b7c"}]}