)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c3cc4e6c02848a85797230bbfe22c916ec0ba5d4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the request creating or updating a protocol. All other schemas in keystone"},{"line_number":11,"context_line":"break the schemas into create and update schemas. This applies that same"},{"line_number":12,"context_line":"convention to the federated protocol entities."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic6f481cdb4147c2068c4378cf9e398a3db6eeb63"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_8a2708c9","line":13,"updated":"2016-05-10 23:48:48.000000000","message":"Next time please open a bug for tracking.","commit_id":"88713cce119c5f6a9f5b943de7cec49092cfebd4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"cde17b3c461c16edb2a9e26e6e2c7bc5de197f43","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the request creating or updating a protocol. All other schemas in keystone"},{"line_number":11,"context_line":"break the schemas into create and update schemas. This applies that same"},{"line_number":12,"context_line":"convention to the federated protocol entities."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic6f481cdb4147c2068c4378cf9e398a3db6eeb63"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_739e05ba","line":13,"in_reply_to":"dab17558_8a2708c9","updated":"2016-05-11 13:37:23.000000000","message":"Will do, wasn\u0027t sure one would be required since it wasn\u0027t impacting end users at all.","commit_id":"88713cce119c5f6a9f5b943de7cec49092cfebd4"}],"keystone/federation/schema.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"3a11e09354ff224ab6c676ca38923473e330d0d7","unresolved":false,"context_lines":[{"line_number":118,"context_line":"protocol_update \u003d {"},{"line_number":119,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":120,"context_line":"    \u0027properties\u0027: _protocol_properties,"},{"line_number":121,"context_line":"    \u0027minProperties\u0027: 1,"},{"line_number":122,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":123,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_c3e5a4dc","line":121,"range":{"start_line":121,"start_character":4,"end_line":121,"end_character":23},"updated":"2016-05-10 11:08:09.000000000","message":"In this context (single property), what is the difference between this and \"\u0027required\u0027: [\u0027mapping_id\u0027]\" from L114.\n\nIf they\u0027re the same, why not just make:\n\n    protocol_update \u003d protocol_create","commit_id":"88713cce119c5f6a9f5b943de7cec49092cfebd4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6e67f3f19c196440ea5e3a1cafb3a4cb3322fdb1","unresolved":false,"context_lines":[{"line_number":118,"context_line":"protocol_update \u003d {"},{"line_number":119,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":120,"context_line":"    \u0027properties\u0027: _protocol_properties,"},{"line_number":121,"context_line":"    \u0027minProperties\u0027: 1,"},{"line_number":122,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":123,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_90143f4d","line":121,"in_reply_to":"dab17558_c3e5a4dc","updated":"2016-05-11 13:36:24.000000000","message":"Yeah - that would make sense. I was following the existing convention with the rest of the schemas, but either way would work fine.","commit_id":"88713cce119c5f6a9f5b943de7cec49092cfebd4"}],"keystone/tests/unit/test_validation.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d2ec94e8bc1a904ef52531d70eaadab271bfd5b0","unresolved":false,"context_lines":[{"line_number":2117,"context_line":"        for bad_mapping_id in [12345, True]:"},{"line_number":2118,"context_line":"            request_to_validate \u003d {\u0027mapping_id\u0027: bad_mapping_id}"},{"line_number":2119,"context_line":"            self.assertRaises(exception.SchemaValidationError,"},{"line_number":2120,"context_line":"                            self.update_protocol_validator.validate,"},{"line_number":2121,"context_line":"                            request_to_validate)"},{"line_number":2122,"context_line":""},{"line_number":2123,"context_line":""},{"line_number":2124,"context_line":"class OAuth1ValidationTestCase(unit.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_e3d3d65d","line":2121,"range":{"start_line":2120,"start_character":28,"end_line":2121,"end_character":47},"updated":"2016-05-08 06:52:39.000000000","message":"pep8 fail here","commit_id":"05c873e94b2eb7d14d939193c6dff021fdf660e4"}]}