)]}'
{"keystone/tests/unit/contrib/federation/test_utils.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"f7d857761078f150b6925e55fb56674088d3ec1e","unresolved":false,"context_lines":[{"line_number":616,"context_line":"    def test_mapping_with_group_name(self):"},{"line_number":617,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_GROUP_NAMES"},{"line_number":618,"context_line":"        # validate_mapping_structure raises ValidationError when fails"},{"line_number":619,"context_line":"        mapping_utils.validate_mapping_structure(mapping)"},{"line_number":620,"context_line":"        self.assertTrue(True)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def test_type_not_in_assertion(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_5c55e3bf","line":619,"range":{"start_line":619,"start_character":8,"end_line":619,"end_character":57},"updated":"2016-04-27 15:22:27.000000000","message":"you need to check the ValidationError raising","commit_id":"ef6e2615971b87e18cea538dea2cb56408b24fab"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"06226b56137bdcee6a6118d56a9b375ce0a452a1","unresolved":false,"context_lines":[{"line_number":616,"context_line":"    def test_mapping_with_group_name(self):"},{"line_number":617,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_GROUP_NAMES"},{"line_number":618,"context_line":"        # validate_mapping_structure raises ValidationError when fails"},{"line_number":619,"context_line":"        mapping_utils.validate_mapping_structure(mapping)"},{"line_number":620,"context_line":"        self.assertTrue(True)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def test_type_not_in_assertion(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_ce1775ec","line":619,"range":{"start_line":619,"start_character":8,"end_line":619,"end_character":57},"in_reply_to":"1a122d0e_0e75ed96","updated":"2016-04-27 18:52:58.000000000","message":"no, you should verify only the *expected* exception","commit_id":"ef6e2615971b87e18cea538dea2cb56408b24fab"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"6a28445665f8532c5289e21d6f67ca129c25c5da","unresolved":false,"context_lines":[{"line_number":616,"context_line":"    def test_mapping_with_group_name(self):"},{"line_number":617,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_GROUP_NAMES"},{"line_number":618,"context_line":"        # validate_mapping_structure raises ValidationError when fails"},{"line_number":619,"context_line":"        mapping_utils.validate_mapping_structure(mapping)"},{"line_number":620,"context_line":"        self.assertTrue(True)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def test_type_not_in_assertion(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_0e75ed96","line":619,"range":{"start_line":619,"start_character":8,"end_line":619,"end_character":57},"in_reply_to":"1a122d0e_5c55e3bf","updated":"2016-04-27 18:40:53.000000000","message":"And should I handle other exceptions?","commit_id":"ef6e2615971b87e18cea538dea2cb56408b24fab"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"f7d857761078f150b6925e55fb56674088d3ec1e","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_GROUP_NAMES"},{"line_number":618,"context_line":"        # validate_mapping_structure raises ValidationError when fails"},{"line_number":619,"context_line":"        mapping_utils.validate_mapping_structure(mapping)"},{"line_number":620,"context_line":"        self.assertTrue(True)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def test_type_not_in_assertion(self):"},{"line_number":623,"context_line":"        \"\"\"Test that if the remote \"type\" is not in the assertion it fails.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_dc69f38d","line":620,"range":{"start_line":620,"start_character":8,"end_line":620,"end_character":29},"updated":"2016-04-27 15:22:27.000000000","message":"this is not doing anything...","commit_id":"ef6e2615971b87e18cea538dea2cb56408b24fab"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"07f600395e33b3738399a6e35253ed70677b1b86","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_GROUP_NAMES"},{"line_number":618,"context_line":"        # validate_mapping_structure raises ValidationError when fails"},{"line_number":619,"context_line":"        mapping_utils.validate_mapping_structure(mapping)"},{"line_number":620,"context_line":"        self.assertTrue(True)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def test_type_not_in_assertion(self):"},{"line_number":623,"context_line":"        \"\"\"Test that if the remote \"type\" is not in the assertion it fails.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_2eb8a974","line":620,"range":{"start_line":620,"start_character":8,"end_line":620,"end_character":29},"in_reply_to":"1a122d0e_0e7a0df1","updated":"2016-04-27 19:16:45.000000000","message":"in this case, the test should fail if something happens if you are passing a valid mapping, right? So it should do nothing after you call \"validate_mapping_structure\"","commit_id":"ef6e2615971b87e18cea538dea2cb56408b24fab"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"29071604d520a82615691d85029767efa1d19725","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_GROUP_NAMES"},{"line_number":618,"context_line":"        # validate_mapping_structure raises ValidationError when fails"},{"line_number":619,"context_line":"        mapping_utils.validate_mapping_structure(mapping)"},{"line_number":620,"context_line":"        self.assertTrue(True)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def test_type_not_in_assertion(self):"},{"line_number":623,"context_line":"        \"\"\"Test that if the remote \"type\" is not in the assertion it fails.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_2e46e97a","line":620,"range":{"start_line":620,"start_character":8,"end_line":620,"end_character":29},"in_reply_to":"1a122d0e_2eb8a974","updated":"2016-04-27 19:19:59.000000000","message":"Yes, exactly. I\u0027m thinking about a one-liner: mapping_utils.validate_mapping_structure(mapping)\nOr I still must catch the ValidationError? I don\u0027t think I can do a better assert if I catch it.","commit_id":"ef6e2615971b87e18cea538dea2cb56408b24fab"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"06226b56137bdcee6a6118d56a9b375ce0a452a1","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_GROUP_NAMES"},{"line_number":618,"context_line":"        # validate_mapping_structure raises ValidationError when fails"},{"line_number":619,"context_line":"        mapping_utils.validate_mapping_structure(mapping)"},{"line_number":620,"context_line":"        self.assertTrue(True)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def test_type_not_in_assertion(self):"},{"line_number":623,"context_line":"        \"\"\"Test that if the remote \"type\" is not in the assertion it fails.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_ee3191a3","line":620,"range":{"start_line":620,"start_character":8,"end_line":620,"end_character":29},"in_reply_to":"1a122d0e_8e69fdc0","updated":"2016-04-27 18:52:58.000000000","message":"you should test the return of \"validate_mapping_structure\"","commit_id":"ef6e2615971b87e18cea538dea2cb56408b24fab"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"6a28445665f8532c5289e21d6f67ca129c25c5da","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_GROUP_NAMES"},{"line_number":618,"context_line":"        # validate_mapping_structure raises ValidationError when fails"},{"line_number":619,"context_line":"        mapping_utils.validate_mapping_structure(mapping)"},{"line_number":620,"context_line":"        self.assertTrue(True)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def test_type_not_in_assertion(self):"},{"line_number":623,"context_line":"        \"\"\"Test that if the remote \"type\" is not in the assertion it fails.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_8e69fdc0","line":620,"range":{"start_line":620,"start_character":8,"end_line":620,"end_character":29},"in_reply_to":"1a122d0e_dc69f38d","updated":"2016-04-27 18:40:53.000000000","message":"It just passes the test, when no exception raised. What should I assert when no exception occured? (I\u0027m not a very experienced python unittest author).","commit_id":"ef6e2615971b87e18cea538dea2cb56408b24fab"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"afc9e90e1d4cdea4f84a356c6b3f0407f1154076","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_GROUP_NAMES"},{"line_number":618,"context_line":"        # validate_mapping_structure raises ValidationError when fails"},{"line_number":619,"context_line":"        mapping_utils.validate_mapping_structure(mapping)"},{"line_number":620,"context_line":"        self.assertTrue(True)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def test_type_not_in_assertion(self):"},{"line_number":623,"context_line":"        \"\"\"Test that if the remote \"type\" is not in the assertion it fails.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_0e7a0df1","line":620,"range":{"start_line":620,"start_character":8,"end_line":620,"end_character":29},"in_reply_to":"1a122d0e_ee3191a3","updated":"2016-04-27 19:10:01.000000000","message":"Well, it is either None (there is no return in the function) or raises ValidationError. Should I self.assertEqual(retval, None) then?","commit_id":"ef6e2615971b87e18cea538dea2cb56408b24fab"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e1fa2f8831d0c61c78e311326c39aee9a7fb4f88","unresolved":false,"context_lines":[{"line_number":616,"context_line":"    def test_mapping_with_group_name(self):"},{"line_number":617,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_GROUP_NAMES"},{"line_number":618,"context_line":"        try:"},{"line_number":619,"context_line":"            mapping_utils.validate_mapping_structure(mapping)"},{"line_number":620,"context_line":"        except exception.ValidationError, e:"},{"line_number":621,"context_line":"            raise AssertionError(\u0027validate_mapping_structure failed: %s\u0027 % str(e))"},{"line_number":622,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_768045f8","line":619,"updated":"2016-05-02 22:34:58.000000000","message":"the patch should just call this line, without the try/error block","commit_id":"7135b960a5d280df07e15ad9cd8d2a59f597b904"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"3e6a6223cbbc1a907da799e6ee5d008178961393","unresolved":false,"context_lines":[{"line_number":613,"context_line":"                          mapping_utils.validate_mapping_structure,"},{"line_number":614,"context_line":"                          mapping)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    def test_mapping_with_group_name(self):"},{"line_number":617,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_GROUP_NAMES"},{"line_number":618,"context_line":"        mapping_utils.validate_mapping_structure(mapping)"},{"line_number":619,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_f0defe0e","line":616,"range":{"start_line":616,"start_character":8,"end_line":616,"end_character":36},"updated":"2016-05-03 18:56:26.000000000","message":"nit: test_mapping_with_group_name_and_domain","commit_id":"5adaeac8a13dcfb4a732961cee0eebc246dc1b7c"}]}