)]}'
{"keystone/common/sql/migrate_repo/versions/020_migrate_metadata_table_roles.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"5ee570fa332b9983735d2276af1c5569616b004b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            q \u003d new_metadata_table.update().where("},{"line_number":42,"context_line":"                new_metadata_table.c.user_id \u003d\u003d metadata.user_id).where("},{"line_number":43,"context_line":"                    new_metadata_table.c.project_id \u003d\u003d"},{"line_number":44,"context_line":"                    metadata.tenant_id).values(data\u003djson.dumps(data))"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            q \u003d new_metadata_table.insert().values("},{"line_number":47,"context_line":"                user_id\u003dmetadata.user_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fhjk%3D","line":44,"updated":"2013-05-31 09:50:22.000000000","message":"So maybe my SQL just isn\u0027t good enough to determine why the old code fails and the new one is correct - could you explain why the original \"and\" version is wrong?  Maybe worth a comment since that is how most people who have written it.","commit_id":"87dd116aea6e3c8d9d436ce6b5bf1fbbe0ff0788"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"3f77a0fae839a8185c05e65d7176e949dd3ba169","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            q \u003d new_metadata_table.update().where("},{"line_number":42,"context_line":"                new_metadata_table.c.user_id \u003d\u003d metadata.user_id).where("},{"line_number":43,"context_line":"                    new_metadata_table.c.project_id \u003d\u003d"},{"line_number":44,"context_line":"                    metadata.tenant_id).values(data\u003djson.dumps(data))"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            q \u003d new_metadata_table.insert().values("},{"line_number":47,"context_line":"                user_id\u003dmetadata.user_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FgSw%3D","line":44,"in_reply_to":"AAAAPH%2F%2FgUc%3D","updated":"2013-05-31 17:44:06.000000000","message":"Wow, so looks like the \"and\" is being ignored?","commit_id":"87dd116aea6e3c8d9d436ce6b5bf1fbbe0ff0788"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"69fc88eac0057f3a15a004166c0d85218bdb1ab9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            q \u003d new_metadata_table.update().where("},{"line_number":42,"context_line":"                new_metadata_table.c.user_id \u003d\u003d metadata.user_id).where("},{"line_number":43,"context_line":"                    new_metadata_table.c.project_id \u003d\u003d"},{"line_number":44,"context_line":"                    metadata.tenant_id).values(data\u003djson.dumps(data))"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            q \u003d new_metadata_table.insert().values("},{"line_number":47,"context_line":"                user_id\u003dmetadata.user_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FgUc%3D","line":44,"in_reply_to":"AAAAPH%2F%2Fhjk%3D","updated":"2013-05-31 17:29:39.000000000","message":"From the bug report:\n\nThis generates the sql:\n\n    UPDATE user_project_metadata SET data\u003d%s WHERE user_project_metadata.user_id \u003d %s\n\nrather than the obviously intended:\n\n    UPDATE user_project_metadata SET data\u003d%s WHERE user_project_metadata.user_id \u003d %s AND user_project_metadata.project_id \u003d %s","commit_id":"87dd116aea6e3c8d9d436ce6b5bf1fbbe0ff0788"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"5ee570fa332b9983735d2276af1c5569616b004b","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        session.execute(q)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    session.commit()"},{"line_number":54,"context_line":"    old_metadata_table.drop()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FhjM%3D","line":53,"updated":"2013-05-31 09:50:22.000000000","message":"Just checking you have tested this against sqlite, mysql and postgresql....every time we change something like this we need to check due to differences in the support for the various engines.","commit_id":"87dd116aea6e3c8d9d436ce6b5bf1fbbe0ff0788"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"da67381e1ad6c9f355d1bbd10eef087304721eaf","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        session.execute(q)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    session.commit()"},{"line_number":54,"context_line":"    old_metadata_table.drop()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fg70%3D","line":53,"in_reply_to":"AAAAPH%2F%2FhjM%3D","updated":"2013-05-31 13:58:08.000000000","message":"Yes.  It has been tested against all of them.","commit_id":"87dd116aea6e3c8d9d436ce6b5bf1fbbe0ff0788"}]}