)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c1807840eee09388aba5ee92846635e4f061b1a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a122d0e_0cc0dd7b","updated":"2016-05-03 05:35:17.000000000","message":"reference bug https://bugs.launchpad.net/keystone/+bug/1576315","commit_id":"8236897f0e1f4697ebd308319bfab3ff3b2c4c62"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"716bdf20762bfa781d1aacd5080ff6fbc410801d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"An outcome of some of the token discussions in Austin was that when Fernet is"},{"line_number":10,"context_line":"the configured token provider, Keystone should fail on start up if there are no"},{"line_number":11,"context_line":"keys in the key repository or if the repository doesn\u0027t exist."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0351dddc49da5908f46e09e22467f6fb112593dd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_3d5a0af3","line":12,"updated":"2016-05-03 19:03:45.000000000","message":"you forgot to reference the bug :P","commit_id":"9143687fe1749eefa2150c7b0255d79bc498a281"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"86459fc0aa40b84a95752bfdf06ca2af4297116f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"An outcome of some of the token discussions in Austin was that when Fernet is"},{"line_number":10,"context_line":"the configured token provider, Keystone should fail on start up if there are no"},{"line_number":11,"context_line":"keys in the key repository or if the repository doesn\u0027t exist."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0351dddc49da5908f46e09e22467f6fb112593dd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_a1b6d9f6","line":12,"in_reply_to":"1a122d0e_3d5a0af3","updated":"2016-05-04 13:22:22.000000000","message":"Done","commit_id":"9143687fe1749eefa2150c7b0255d79bc498a281"}],"keystone/token/providers/fernet/core.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c1807840eee09388aba5ee92846635e4f061b1a8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            # bail here because we can\u0027t do anything without keys"},{"line_number":40,"context_line":"            subs \u003d {\u0027key_repo\u0027: CONF.fernet_tokens.key_repository}"},{"line_number":41,"context_line":"            raise SystemExit(_(\u0027%(key_repo)s does not contain keys, use \u0027"},{"line_number":42,"context_line":"                               \u0027keystone-manage fernet_setup to create \u0027"},{"line_number":43,"context_line":"                               \u0027Fernet keys.\u0027) % subs)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.token_formatter \u003d tf.TokenFormatter()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_cccd45b9","line":42,"range":{"start_line":42,"start_character":32,"end_line":42,"end_character":60},"updated":"2016-05-03 05:35:17.000000000","message":"put these in backticks ``","commit_id":"8236897f0e1f4697ebd308319bfab3ff3b2c4c62"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e0ad978395b03132b8edb27abc830695c9eb962b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        # keystone and just 500 because we can\u0027t do anything with an empty or"},{"line_number":38,"context_line":"        # non-existant key repository."},{"line_number":39,"context_line":"        if not os.path.exists(CONF.fernet_tokens.key_repository):"},{"line_number":40,"context_line":"            subs \u003d {\u0027key_repo\u0027: CONF.fernet_tokens.key_repository}"},{"line_number":41,"context_line":"            raise SystemExit(_(\u0027%(key_repo)s does not exist\u0027) % subs)"},{"line_number":42,"context_line":"        if not os.listdir(CONF.fernet_tokens.key_repository):"},{"line_number":43,"context_line":"            subs \u003d {\u0027key_repo\u0027: CONF.fernet_tokens.key_repository}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_49739ab4","line":40,"range":{"start_line":40,"start_character":12,"end_line":40,"end_character":66},"updated":"2016-05-04 18:03:27.000000000","message":"I think subs should be defined outside the ifs so you can add a debug log saying that it was possible to find the fernet keys","commit_id":"ed74e19f5aa10b5b9c53e4a2e97e3922d70218e4"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e0ad978395b03132b8edb27abc830695c9eb962b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            raise SystemExit(_(\u0027%(key_repo)s does not contain keys, use \u0027"},{"line_number":45,"context_line":"                               \u0027keystone-manage fernet_setup to create \u0027"},{"line_number":46,"context_line":"                               \u0027Fernet keys.\u0027) % subs)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.token_formatter \u003d tf.TokenFormatter()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def needs_persistence(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_499a7ac6","line":47,"updated":"2016-05-04 18:03:27.000000000","message":"log here that the fernet keys were found","commit_id":"ed74e19f5aa10b5b9c53e4a2e97e3922d70218e4"}]}