)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"efcd54daf6787dcfd8ba583d46c24539758c2d38","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Listing all users is not practical for large organizations."},{"line_number":10,"context_line":"Since we have to keep backwards compatibility, we created a"},{"line_number":11,"context_line":"config option to list all user without a filter."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Raildo Mascena \u003craildo@lsd.ufcg.edu.br\u003e"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a77a97e_4023d855","line":11,"range":{"start_line":11,"start_character":26,"end_line":11,"end_character":30},"updated":"2016-11-19 19:59:19.000000000","message":"users","commit_id":"ba8d852d992950d866ed230d0665b4640651de72"}],"etc/keystone.conf.sample":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4340841d3a0f11eae5528a66d25444a3609b1c20","unresolved":false,"context_lines":[{"line_number":904,"context_line":""},{"line_number":905,"context_line":"# Disable users list without a filter. This feature is disabled by default."},{"line_number":906,"context_line":"# set to true to enable. (boolean value)"},{"line_number":907,"context_line":"#disable_user_list_without_filter \u003d false"},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"[identity_mapping]"},{"line_number":910,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dab17558_4c4d003d","line":907,"updated":"2016-05-17 21:05:06.000000000","message":"This file doesn\u0027t need to be updated manually - we have a job that will propose a change with the updated version.","commit_id":"ece895af03d79fe0e627be567d30dc5813822d29"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"d98468125e5d2cc74f61e7fbc72f52db69a41b62","unresolved":false,"context_lines":[{"line_number":904,"context_line":""},{"line_number":905,"context_line":"# Disable users list without a filter. This feature is disabled by default."},{"line_number":906,"context_line":"# set to true to enable. (boolean value)"},{"line_number":907,"context_line":"#disable_user_list_without_filter \u003d false"},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"[identity_mapping]"},{"line_number":910,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7aa08908_9466e8ea","line":907,"in_reply_to":"dab17558_4c4d003d","updated":"2016-06-08 20:56:37.000000000","message":"++","commit_id":"ece895af03d79fe0e627be567d30dc5813822d29"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"92875caf006ca0bff6fb10491f59c130b1f2e422","unresolved":false,"context_lines":[{"line_number":986,"context_line":""},{"line_number":987,"context_line":"# Disable users list without a filter. This feature is disabled by default."},{"line_number":988,"context_line":"# set to true to enable. (boolean value)"},{"line_number":989,"context_line":"#disable_user_list_without_filter \u003d false"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"[identity_mapping]"},{"line_number":992,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"ba5da102_081ab317","line":989,"updated":"2016-11-05 01:59:05.000000000","message":"Edit conf/default.py instead and undo changes to this file.","commit_id":"430c670f10fb2778183866cafd2d28c1ed18993f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f0b37a93a7f27d6c14c003e2ba92f993630b5b3d","unresolved":false,"context_lines":[{"line_number":986,"context_line":""},{"line_number":987,"context_line":"# Disable users list without a filter. This feature is disabled by default."},{"line_number":988,"context_line":"# set to true to enable. (boolean value)"},{"line_number":989,"context_line":"#disable_user_list_without_filter \u003d false"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"[identity_mapping]"},{"line_number":992,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"ba5da102_485f4b75","line":989,"in_reply_to":"ba5da102_081ab317","updated":"2016-11-05 02:55:23.000000000","message":"++ do not edit the sample\n\nactually, you probably want to edit keystone/conf/identity.py","commit_id":"430c670f10fb2778183866cafd2d28c1ed18993f"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"ff5a5819d3d6f9940851a6fcfa378d65cc90004b","unresolved":false,"context_lines":[{"line_number":986,"context_line":""},{"line_number":987,"context_line":"# Disable users list without a filter. This feature is disabled by default."},{"line_number":988,"context_line":"# set to true to enable. (boolean value)"},{"line_number":989,"context_line":"#disable_user_list_without_filter \u003d false"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"[identity_mapping]"},{"line_number":992,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"9a629dbe_984e1fc0","line":989,"in_reply_to":"ba5da102_485f4b75","updated":"2016-11-07 17:35:03.000000000","message":"Done","commit_id":"430c670f10fb2778183866cafd2d28c1ed18993f"}],"keystone/common/config.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4340841d3a0f11eae5528a66d25444a3609b1c20","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        cfg.BoolOpt(\u0027disable_user_list_without_filter\u0027,"},{"line_number":209,"context_line":"                    default\u003dFalse,"},{"line_number":210,"context_line":"                    help\u003d\u0027In v3 API, disable users list without a filter. \u0027"},{"line_number":211,"context_line":"                         \u0027This feature is disabled by default. \u0027"},{"line_number":212,"context_line":"                         \u0027set to true to enable.\u0027)"},{"line_number":213,"context_line":"    ],"},{"line_number":214,"context_line":"    \u0027identity_mapping\u0027: ["}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_2c1d1c0f","line":211,"updated":"2016-05-17 21:05:06.000000000","message":"nit: I\u0027d suggest giving a little more information about the behavior of this option. The fact that the option defaults to False will be documented in the sample config.","commit_id":"ece895af03d79fe0e627be567d30dc5813822d29"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"d98468125e5d2cc74f61e7fbc72f52db69a41b62","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                    default\u003dFalse,"},{"line_number":210,"context_line":"                    help\u003d\u0027In v3 API, disable users list without a filter. \u0027"},{"line_number":211,"context_line":"                         \u0027This feature is disabled by default. \u0027"},{"line_number":212,"context_line":"                         \u0027set to true to enable.\u0027)"},{"line_number":213,"context_line":"    ],"},{"line_number":214,"context_line":"    \u0027identity_mapping\u0027: ["},{"line_number":215,"context_line":"        cfg.StrOpt(\u0027driver\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_b4b2044a","line":212,"range":{"start_line":212,"start_character":26,"end_line":212,"end_character":48},"updated":"2016-06-08 20:56:37.000000000","message":"this isn\u0027t needed","commit_id":"ece895af03d79fe0e627be567d30dc5813822d29"}],"keystone/conf/identity.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a638308c0a56ec9dc6eccb2d438e7f410e6edd0c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"list_users_without_filter \u003d cfg.BoolOpt("},{"line_number":113,"context_line":"    \u0027list_users_without_filter\u0027,"},{"line_number":114,"context_line":"    default\u003dTrue,"},{"line_number":115,"context_line":"    help\u003d\u0027In v3 API, enable list users without a filter.\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"GROUP_NAME \u003d __name__.split(\u0027.\u0027)[-1]"},{"line_number":118,"context_line":"ALL_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_ac8e922b","line":115,"range":{"start_line":115,"start_character":10,"end_line":115,"end_character":19},"updated":"2016-11-11 01:55:14.000000000","message":"So its only v3? I think its probably better to add this as a separate sentence after the description.","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a638308c0a56ec9dc6eccb2d438e7f410e6edd0c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"list_users_without_filter \u003d cfg.BoolOpt("},{"line_number":113,"context_line":"    \u0027list_users_without_filter\u0027,"},{"line_number":114,"context_line":"    default\u003dTrue,"},{"line_number":115,"context_line":"    help\u003d\u0027In v3 API, enable list users without a filter.\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"GROUP_NAME \u003d __name__.split(\u0027.\u0027)[-1]"},{"line_number":118,"context_line":"ALL_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_ec288a35","line":115,"range":{"start_line":115,"start_character":28,"end_line":115,"end_character":32},"updated":"2016-11-11 01:55:14.000000000","message":"listing of","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"efcd54daf6787dcfd8ba583d46c24539758c2d38","unresolved":false,"context_lines":[{"line_number":112,"context_line":"list_users_without_filter \u003d cfg.BoolOpt("},{"line_number":113,"context_line":"    \u0027list_users_without_filter\u0027,"},{"line_number":114,"context_line":"    default\u003dTrue,"},{"line_number":115,"context_line":"    help\u003d\u0027In v3 API, enable list users without a filter.\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"GROUP_NAME \u003d __name__.split(\u0027.\u0027)[-1]"},{"line_number":118,"context_line":"ALL_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_0025605a","line":115,"range":{"start_line":115,"start_character":10,"end_line":115,"end_character":21},"updated":"2016-11-19 19:59:19.000000000","message":"Its better to put as an after-note.  \"Note, this config option applies to the v3 API only.\"","commit_id":"ba8d852d992950d866ed230d0665b4640651de72"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"dc8747664532082d01f43956e335156d48ebcb63","unresolved":false,"context_lines":[{"line_number":112,"context_line":"list_users_without_filter \u003d cfg.BoolOpt("},{"line_number":113,"context_line":"    \u0027list_users_without_filter\u0027,"},{"line_number":114,"context_line":"    default\u003dTrue,"},{"line_number":115,"context_line":"    help\u003d\u0027In v3 API, enable list users without a filter.\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"GROUP_NAME \u003d __name__.split(\u0027.\u0027)[-1]"},{"line_number":118,"context_line":"ALL_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_060bb87d","line":115,"range":{"start_line":115,"start_character":10,"end_line":115,"end_character":55},"updated":"2016-11-20 04:47:25.000000000","message":"suggested wording:\n\n\u0027If set to \"True\", attempt to list all users when no filter (\"domain_id\", \"enabled\", \"name\") is used. If set to \"False\", a \"ValidationError\" will be raised if no filter is used. Note, this option will only affect the v3 API for listing users.\u0027","commit_id":"ba8d852d992950d866ed230d0665b4640651de72"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"58dfbf534e7a90f557bd0bedbd64d88aee9d5ec7","unresolved":false,"context_lines":[{"line_number":112,"context_line":"list_users_without_filter \u003d cfg.BoolOpt("},{"line_number":113,"context_line":"    \u0027list_users_without_filter\u0027,"},{"line_number":114,"context_line":"    default\u003dTrue,"},{"line_number":115,"context_line":"    help\u003d\u0027In v3 API, enable list users without a filter.\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"GROUP_NAME \u003d __name__.split(\u0027.\u0027)[-1]"},{"line_number":118,"context_line":"ALL_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_c48b2c67","line":115,"range":{"start_line":115,"start_character":10,"end_line":115,"end_character":55},"in_reply_to":"7a77a97e_060bb87d","updated":"2016-12-20 01:45:09.000000000","message":"++","commit_id":"ba8d852d992950d866ed230d0665b4640651de72"}],"keystone/identity/controllers.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"ba24acd2a1798a32b388448c6783f25124d8d477","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    @controller.filterprotected(\u0027domain_id\u0027, \u0027enabled\u0027, \u0027name\u0027)"},{"line_number":225,"context_line":"    def list_users(self, context, filters):"},{"line_number":226,"context_line":"        if CONF.identity.disable_user_list_without_filter:"},{"line_number":227,"context_line":"            if len(context[\u0027query_string\u0027]) \u003d\u003d 0:"},{"line_number":228,"context_line":"                msg \u003d _(\"Can\u0027t use user list api without a filter.\")"},{"line_number":229,"context_line":"                raise exception.ValidationError(message\u003dmsg)"},{"line_number":230,"context_line":"        hints \u003d UserV3.build_driver_hints(context, filters)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_5710fb4d","line":227,"updated":"2016-05-17 16:30:37.000000000","message":"This should be a \u0027and\u0027 if conf... and if len(...)","commit_id":"ece895af03d79fe0e627be567d30dc5813822d29"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4340841d3a0f11eae5528a66d25444a3609b1c20","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    @controller.filterprotected(\u0027domain_id\u0027, \u0027enabled\u0027, \u0027name\u0027)"},{"line_number":225,"context_line":"    def list_users(self, context, filters):"},{"line_number":226,"context_line":"        if CONF.identity.disable_user_list_without_filter:"},{"line_number":227,"context_line":"            if len(context[\u0027query_string\u0027]) \u003d\u003d 0:"},{"line_number":228,"context_line":"                msg \u003d _(\"Can\u0027t use user list api without a filter.\")"},{"line_number":229,"context_line":"                raise exception.ValidationError(message\u003dmsg)"},{"line_number":230,"context_line":"        hints \u003d UserV3.build_driver_hints(context, filters)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_6cc1e44d","line":227,"in_reply_to":"dab17558_5710fb4d","updated":"2016-05-17 21:05:06.000000000","message":"What about: \n\n    if CONF.identity.disable_user_list_without_filter and not context[\u0027query_string\u0027]:","commit_id":"ece895af03d79fe0e627be567d30dc5813822d29"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"d98468125e5d2cc74f61e7fbc72f52db69a41b62","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    def list_users(self, context, filters):"},{"line_number":226,"context_line":"        if CONF.identity.disable_user_list_without_filter:"},{"line_number":227,"context_line":"            if len(context[\u0027query_string\u0027]) \u003d\u003d 0:"},{"line_number":228,"context_line":"                msg \u003d _(\"Can\u0027t use user list api without a filter.\")"},{"line_number":229,"context_line":"                raise exception.ValidationError(message\u003dmsg)"},{"line_number":230,"context_line":"        hints \u003d UserV3.build_driver_hints(context, filters)"},{"line_number":231,"context_line":"        refs \u003d self.identity_api.list_users("}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_34ec5429","line":228,"range":{"start_line":228,"start_character":25,"end_line":228,"end_character":66},"updated":"2016-06-08 20:56:37.000000000","message":"What about \"Can\u0027t list users without a filter.\" ? Does it seem better for you?","commit_id":"ece895af03d79fe0e627be567d30dc5813822d29"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4340841d3a0f11eae5528a66d25444a3609b1c20","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    def list_users(self, context, filters):"},{"line_number":226,"context_line":"        if CONF.identity.disable_user_list_without_filter:"},{"line_number":227,"context_line":"            if len(context[\u0027query_string\u0027]) \u003d\u003d 0:"},{"line_number":228,"context_line":"                msg \u003d _(\"Can\u0027t use user list api without a filter.\")"},{"line_number":229,"context_line":"                raise exception.ValidationError(message\u003dmsg)"},{"line_number":230,"context_line":"        hints \u003d UserV3.build_driver_hints(context, filters)"},{"line_number":231,"context_line":"        refs \u003d self.identity_api.list_users("}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_6c98c475","line":228,"updated":"2016-05-17 21:05:06.000000000","message":"nit: use \u0027 instead of \" to be consistent with other messages in this module.","commit_id":"ece895af03d79fe0e627be567d30dc5813822d29"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f0b37a93a7f27d6c14c003e2ba92f993630b5b3d","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    def list_users(self, request, filters):"},{"line_number":226,"context_line":"        if (CONF.identity.disable_user_list_without_filter"},{"line_number":227,"context_line":"            and not context[\u0027query_string\u0027]):"},{"line_number":228,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter.\")"},{"line_number":229,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":230,"context_line":"        hints \u003d UserV3.build_driver_hints(request, filters)"},{"line_number":231,"context_line":"        domain \u003d self._get_domain_id_for_list_request(request)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_a85e2774","line":228,"range":{"start_line":228,"start_character":21,"end_line":228,"end_character":26},"updated":"2016-11-05 02:55:23.000000000","message":"Cannot*","commit_id":"430c670f10fb2778183866cafd2d28c1ed18993f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f0b37a93a7f27d6c14c003e2ba92f993630b5b3d","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    def list_users(self, request, filters):"},{"line_number":226,"context_line":"        if (CONF.identity.disable_user_list_without_filter"},{"line_number":227,"context_line":"            and not context[\u0027query_string\u0027]):"},{"line_number":228,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter.\")"},{"line_number":229,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":230,"context_line":"        hints \u003d UserV3.build_driver_hints(request, filters)"},{"line_number":231,"context_line":"        domain \u003d self._get_domain_id_for_list_request(request)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_c8535b6b","line":228,"range":{"start_line":228,"start_character":21,"end_line":228,"end_character":54},"updated":"2016-11-05 02:55:23.000000000","message":"maybe say what are some of the supported filters in the error message?","commit_id":"430c670f10fb2778183866cafd2d28c1ed18993f"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"ff5a5819d3d6f9940851a6fcfa378d65cc90004b","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    def list_users(self, request, filters):"},{"line_number":226,"context_line":"        if (CONF.identity.disable_user_list_without_filter"},{"line_number":227,"context_line":"            and not context[\u0027query_string\u0027]):"},{"line_number":228,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter.\")"},{"line_number":229,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":230,"context_line":"        hints \u003d UserV3.build_driver_hints(request, filters)"},{"line_number":231,"context_line":"        domain \u003d self._get_domain_id_for_list_request(request)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a629dbe_385fd373","line":228,"range":{"start_line":228,"start_character":21,"end_line":228,"end_character":54},"in_reply_to":"ba5da102_c8535b6b","updated":"2016-11-07 17:35:03.000000000","message":"Done","commit_id":"430c670f10fb2778183866cafd2d28c1ed18993f"}],"keystone/identity/core.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9f561391da87ff48c247f8042a83b9c6a525d8d7","unresolved":false,"context_lines":[{"line_number":918,"context_line":"            # We are effectively satisfying any domain_id filter by the above"},{"line_number":919,"context_line":"            # driver selection, so remove any such filter."},{"line_number":920,"context_line":"            self._mark_domain_id_filter_satisfied(hints)"},{"line_number":921,"context_line":"        if not CONF.identity.list_users_without_filter and not hints.filters:"},{"line_number":922,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter, You should disable the \""},{"line_number":923,"context_line":"                    \"config option to filter users without filter or use some \""},{"line_number":924,"context_line":"                    \"filter like domain_id, enabled or name\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_c61d1568","line":921,"range":{"start_line":921,"start_character":11,"end_line":921,"end_character":76},"updated":"2016-11-07 17:51:02.000000000","message":"we want hints to exist when list_users_without_filter is enabled, right? So I guess it is:\n  \n  if CONF.identity.list_users_without_filter and not hints.filters:","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"3f2a7e4c0a7b3fb99d82f0818e3a837fb69285aa","unresolved":false,"context_lines":[{"line_number":918,"context_line":"            # We are effectively satisfying any domain_id filter by the above"},{"line_number":919,"context_line":"            # driver selection, so remove any such filter."},{"line_number":920,"context_line":"            self._mark_domain_id_filter_satisfied(hints)"},{"line_number":921,"context_line":"        if not CONF.identity.list_users_without_filter and not hints.filters:"},{"line_number":922,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter, You should disable the \""},{"line_number":923,"context_line":"                    \"config option to filter users without filter or use some \""},{"line_number":924,"context_line":"                    \"filter like domain_id, enabled or name\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_e2a100ab","line":921,"range":{"start_line":921,"start_character":11,"end_line":921,"end_character":76},"in_reply_to":"9a629dbe_c61d1568","updated":"2016-11-08 13:01:27.000000000","message":"hmmm actually the config is phrased in the other way around I had imagined :)\n\nguess the condition is correct.","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"91b0d0d2d423719d1684ebbc073027da2f9dff38","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            # driver selection, so remove any such filter."},{"line_number":920,"context_line":"            self._mark_domain_id_filter_satisfied(hints)"},{"line_number":921,"context_line":"        if not CONF.identity.list_users_without_filter and not hints.filters:"},{"line_number":922,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter, You should disable the \""},{"line_number":923,"context_line":"                    \"config option to filter users without filter or use some \""},{"line_number":924,"context_line":"                    \"filter like domain_id, enabled or name\")"},{"line_number":925,"context_line":"            raise exception.ValidationError(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_6609972c","line":922,"range":{"start_line":922,"start_character":67,"end_line":922,"end_character":74},"updated":"2016-11-08 05:41:21.000000000","message":"I think you mean \"enable\" here....","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"58ffbd28d98ff88a0e79ef2c884544b30d5e938a","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            # driver selection, so remove any such filter."},{"line_number":920,"context_line":"            self._mark_domain_id_filter_satisfied(hints)"},{"line_number":921,"context_line":"        if not CONF.identity.list_users_without_filter and not hints.filters:"},{"line_number":922,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter, You should disable the \""},{"line_number":923,"context_line":"                    \"config option to filter users without filter or use some \""},{"line_number":924,"context_line":"                    \"filter like domain_id, enabled or name\")"},{"line_number":925,"context_line":"            raise exception.ValidationError(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_9ef0f6ca","line":922,"range":{"start_line":922,"start_character":67,"end_line":922,"end_character":74},"in_reply_to":"9a629dbe_6609972c","updated":"2016-11-19 16:47:34.000000000","message":"Done","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"91b0d0d2d423719d1684ebbc073027da2f9dff38","unresolved":false,"context_lines":[{"line_number":920,"context_line":"            self._mark_domain_id_filter_satisfied(hints)"},{"line_number":921,"context_line":"        if not CONF.identity.list_users_without_filter and not hints.filters:"},{"line_number":922,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter, You should disable the \""},{"line_number":923,"context_line":"                    \"config option to filter users without filter or use some \""},{"line_number":924,"context_line":"                    \"filter like domain_id, enabled or name\")"},{"line_number":925,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":926,"context_line":"        elif CONF.identity.list_users_without_filter or hints:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_a613af5b","line":923,"range":{"start_line":923,"start_character":38,"end_line":923,"end_character":44},"updated":"2016-11-08 05:41:21.000000000","message":"I think you mean \"list\" here","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a638308c0a56ec9dc6eccb2d438e7f410e6edd0c","unresolved":false,"context_lines":[{"line_number":920,"context_line":"            self._mark_domain_id_filter_satisfied(hints)"},{"line_number":921,"context_line":"        if not CONF.identity.list_users_without_filter and not hints.filters:"},{"line_number":922,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter, You should disable the \""},{"line_number":923,"context_line":"                    \"config option to filter users without filter or use some \""},{"line_number":924,"context_line":"                    \"filter like domain_id, enabled or name\")"},{"line_number":925,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":926,"context_line":"        elif CONF.identity.list_users_without_filter or hints:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_acd93259","line":923,"range":{"start_line":923,"start_character":59,"end_line":923,"end_character":65},"updated":"2016-11-11 01:55:14.000000000","message":"a filter","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"58ffbd28d98ff88a0e79ef2c884544b30d5e938a","unresolved":false,"context_lines":[{"line_number":920,"context_line":"            self._mark_domain_id_filter_satisfied(hints)"},{"line_number":921,"context_line":"        if not CONF.identity.list_users_without_filter and not hints.filters:"},{"line_number":922,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter, You should disable the \""},{"line_number":923,"context_line":"                    \"config option to filter users without filter or use some \""},{"line_number":924,"context_line":"                    \"filter like domain_id, enabled or name\")"},{"line_number":925,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":926,"context_line":"        elif CONF.identity.list_users_without_filter or hints:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_bec21251","line":923,"range":{"start_line":923,"start_character":59,"end_line":923,"end_character":65},"in_reply_to":"9a629dbe_acd93259","updated":"2016-11-19 16:47:34.000000000","message":"Done","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a638308c0a56ec9dc6eccb2d438e7f410e6edd0c","unresolved":false,"context_lines":[{"line_number":921,"context_line":"        if not CONF.identity.list_users_without_filter and not hints.filters:"},{"line_number":922,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter, You should disable the \""},{"line_number":923,"context_line":"                    \"config option to filter users without filter or use some \""},{"line_number":924,"context_line":"                    \"filter like domain_id, enabled or name\")"},{"line_number":925,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":926,"context_line":"        elif CONF.identity.list_users_without_filter or hints:"},{"line_number":927,"context_line":"            ref_list \u003d driver.list_users(hints)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_ecdfaa37","line":924,"range":{"start_line":924,"start_character":44,"end_line":924,"end_character":51},"updated":"2016-11-11 01:55:14.000000000","message":"enabled,","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"58ffbd28d98ff88a0e79ef2c884544b30d5e938a","unresolved":false,"context_lines":[{"line_number":921,"context_line":"        if not CONF.identity.list_users_without_filter and not hints.filters:"},{"line_number":922,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter, You should disable the \""},{"line_number":923,"context_line":"                    \"config option to filter users without filter or use some \""},{"line_number":924,"context_line":"                    \"filter like domain_id, enabled or name\")"},{"line_number":925,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":926,"context_line":"        elif CONF.identity.list_users_without_filter or hints:"},{"line_number":927,"context_line":"            ref_list \u003d driver.list_users(hints)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_1e986669","line":924,"range":{"start_line":924,"start_character":44,"end_line":924,"end_character":51},"in_reply_to":"9a629dbe_ecdfaa37","updated":"2016-11-19 16:47:34.000000000","message":"I\u0027m not sure, if it\u0027s correct to use a common before a \u0027or\u0027","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"58dfbf534e7a90f557bd0bedbd64d88aee9d5ec7","unresolved":false,"context_lines":[{"line_number":972,"context_line":"            # We are effectively satisfying any domain_id filter by the above"},{"line_number":973,"context_line":"            # driver selection, so remove any such filter."},{"line_number":974,"context_line":"            self._mark_domain_id_filter_satisfied(hints)"},{"line_number":975,"context_line":"        if not CONF.identity.list_users_without_filter and not hints.filters:"},{"line_number":976,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter, You should enabled \""},{"line_number":977,"context_line":"                    \"the config option to list users without a filter or use \""},{"line_number":978,"context_line":"                    \"some filter like domain_id, enabled or name\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_043a8498","line":975,"range":{"start_line":975,"start_character":11,"end_line":975,"end_character":76},"updated":"2016-12-20 01:45:09.000000000","message":"this is not right. it does not allow people to list all users as they do today. this is backwards incompatible.","commit_id":"ba8d852d992950d866ed230d0665b4640651de72"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"efcd54daf6787dcfd8ba583d46c24539758c2d38","unresolved":false,"context_lines":[{"line_number":973,"context_line":"            # driver selection, so remove any such filter."},{"line_number":974,"context_line":"            self._mark_domain_id_filter_satisfied(hints)"},{"line_number":975,"context_line":"        if not CONF.identity.list_users_without_filter and not hints.filters:"},{"line_number":976,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter, You should enabled \""},{"line_number":977,"context_line":"                    \"the config option to list users without a filter or use \""},{"line_number":978,"context_line":"                    \"some filter like domain_id, enabled or name\")"},{"line_number":979,"context_line":"            raise exception.ValidationError(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_a0fd8cb2","line":976,"range":{"start_line":976,"start_character":21,"end_line":976,"end_character":26},"updated":"2016-11-19 19:59:19.000000000","message":"Unable to","commit_id":"ba8d852d992950d866ed230d0665b4640651de72"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"efcd54daf6787dcfd8ba583d46c24539758c2d38","unresolved":false,"context_lines":[{"line_number":973,"context_line":"            # driver selection, so remove any such filter."},{"line_number":974,"context_line":"            self._mark_domain_id_filter_satisfied(hints)"},{"line_number":975,"context_line":"        if not CONF.identity.list_users_without_filter and not hints.filters:"},{"line_number":976,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter, You should enabled \""},{"line_number":977,"context_line":"                    \"the config option to list users without a filter or use \""},{"line_number":978,"context_line":"                    \"some filter like domain_id, enabled or name\")"},{"line_number":979,"context_line":"            raise exception.ValidationError(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_60f7f4d2","line":976,"range":{"start_line":976,"start_character":67,"end_line":976,"end_character":74},"updated":"2016-11-19 19:59:19.000000000","message":"enable","commit_id":"ba8d852d992950d866ed230d0665b4640651de72"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"efcd54daf6787dcfd8ba583d46c24539758c2d38","unresolved":false,"context_lines":[{"line_number":975,"context_line":"        if not CONF.identity.list_users_without_filter and not hints.filters:"},{"line_number":976,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter, You should enabled \""},{"line_number":977,"context_line":"                    \"the config option to list users without a filter or use \""},{"line_number":978,"context_line":"                    \"some filter like domain_id, enabled or name\")"},{"line_number":979,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":980,"context_line":"        elif CONF.identity.list_users_without_filter or hints:"},{"line_number":981,"context_line":"            ref_list \u003d driver.list_users(hints)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_800250b2","line":978,"range":{"start_line":978,"start_character":49,"end_line":978,"end_character":56},"updated":"2016-11-19 19:59:19.000000000","message":"enabled,","commit_id":"ba8d852d992950d866ed230d0665b4640651de72"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"dc8747664532082d01f43956e335156d48ebcb63","unresolved":false,"context_lines":[{"line_number":973,"context_line":"            # driver selection, so remove any such filter."},{"line_number":974,"context_line":"            self._mark_domain_id_filter_satisfied(hints)"},{"line_number":975,"context_line":"        if not CONF.identity.list_users_without_filter and not hints.filters:"},{"line_number":976,"context_line":"            msg \u003d _(\"Can\u0027t list users without a filter, You should enabled \""},{"line_number":977,"context_line":"                    \"the config option to list users without a filter or use \""},{"line_number":978,"context_line":"                    \"some filter like domain_id, enabled or name\")"},{"line_number":979,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":980,"context_line":"        elif CONF.identity.list_users_without_filter or hints:"},{"line_number":981,"context_line":"            ref_list \u003d driver.list_users(hints)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_861fc8b5","line":978,"range":{"start_line":976,"start_character":21,"end_line":978,"end_character":64},"updated":"2016-11-20 04:47:25.000000000","message":"suggested wording:\n\n\"Unable to list users without a filter. Either enable `[identity] list_users_without_filter` or use a filter (domain_id, enabled, name).\"","commit_id":"ba8d852d992950d866ed230d0665b4640651de72"}],"keystone/tests/unit/test_v3_identity.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4340841d3a0f11eae5528a66d25444a3609b1c20","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                                   disable_user_list_without_filter\u003dTrue)"},{"line_number":226,"context_line":"        resource_url \u003d \u0027/users\u0027"},{"line_number":227,"context_line":"        self.get(resource_url, expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_list_head_users(self):"},{"line_number":230,"context_line":"        \"\"\"Call ``GET \u0026 HEAD /users``.\"\"\""},{"line_number":231,"context_line":"        resource_url \u003d \u0027/users\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_4c7ea019","line":228,"updated":"2016-05-17 21:05:06.000000000","message":"Do we have a test that ensures we can still list users *with* filters?","commit_id":"ece895af03d79fe0e627be567d30dc5813822d29"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"d98468125e5d2cc74f61e7fbc72f52db69a41b62","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                                   disable_user_list_without_filter\u003dTrue)"},{"line_number":226,"context_line":"        resource_url \u003d \u0027/users\u0027"},{"line_number":227,"context_line":"        self.get(resource_url, expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_list_head_users(self):"},{"line_number":230,"context_line":"        \"\"\"Call ``GET \u0026 HEAD /users``.\"\"\""},{"line_number":231,"context_line":"        resource_url \u003d \u0027/users\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_14d6784e","line":228,"in_reply_to":"bab6814e_c5340ee0","updated":"2016-06-08 20:56:37.000000000","message":"I agree with Henry\u0027s suggestion","commit_id":"ece895af03d79fe0e627be567d30dc5813822d29"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"6d3f426788e8aeef3545897388a9f73c23fe6e0e","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                                   disable_user_list_without_filter\u003dTrue)"},{"line_number":226,"context_line":"        resource_url \u003d \u0027/users\u0027"},{"line_number":227,"context_line":"        self.get(resource_url, expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_list_head_users(self):"},{"line_number":230,"context_line":"        \"\"\"Call ``GET \u0026 HEAD /users``.\"\"\""},{"line_number":231,"context_line":"        resource_url \u003d \u0027/users\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_c5340ee0","line":228,"in_reply_to":"dab17558_4c7ea019","updated":"2016-05-18 09:37:38.000000000","message":"Perhaps it would be best if this test first ensures that you CAN list the users without a filter with the default config option setting (i.e. disabled), then change the config and try again, showing that it fails.","commit_id":"ece895af03d79fe0e627be567d30dc5813822d29"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f0b37a93a7f27d6c14c003e2ba92f993630b5b3d","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                        \"DEFaUlT\"}},"},{"line_number":240,"context_line":"                  expected_status\u003dhttp_client.NOT_FOUND)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def test_list_user_without_filter(self):"},{"line_number":243,"context_line":"        \"\"\"Call ``GET \u0026 HEAD /users`` without filter.\"\"\""},{"line_number":244,"context_line":"        self.config_fixture.config(group\u003d\u0027identity\u0027,"},{"line_number":245,"context_line":"                                   disable_user_list_without_filter\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_284bf7b1","line":242,"range":{"start_line":242,"start_character":8,"end_line":242,"end_character":37},"updated":"2016-11-05 02:55:23.000000000","message":"you need more tests showing that it does work with a valid filter... and an invalid filter","commit_id":"430c670f10fb2778183866cafd2d28c1ed18993f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f0b37a93a7f27d6c14c003e2ba92f993630b5b3d","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                  expected_status\u003dhttp_client.NOT_FOUND)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def test_list_user_without_filter(self):"},{"line_number":243,"context_line":"        \"\"\"Call ``GET \u0026 HEAD /users`` without filter.\"\"\""},{"line_number":244,"context_line":"        self.config_fixture.config(group\u003d\u0027identity\u0027,"},{"line_number":245,"context_line":"                                   disable_user_list_without_filter\u003dTrue)"},{"line_number":246,"context_line":"        resource_url \u003d \u0027/users\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_084e33c1","line":243,"range":{"start_line":243,"start_character":24,"end_line":243,"end_character":28},"updated":"2016-11-05 02:55:23.000000000","message":"we don\u0027t call HEAD here","commit_id":"430c670f10fb2778183866cafd2d28c1ed18993f"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"ff5a5819d3d6f9940851a6fcfa378d65cc90004b","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                  expected_status\u003dhttp_client.NOT_FOUND)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def test_list_user_without_filter(self):"},{"line_number":243,"context_line":"        \"\"\"Call ``GET \u0026 HEAD /users`` without filter.\"\"\""},{"line_number":244,"context_line":"        self.config_fixture.config(group\u003d\u0027identity\u0027,"},{"line_number":245,"context_line":"                                   disable_user_list_without_filter\u003dTrue)"},{"line_number":246,"context_line":"        resource_url \u003d \u0027/users\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a629dbe_d8edf78f","line":243,"range":{"start_line":243,"start_character":24,"end_line":243,"end_character":28},"in_reply_to":"ba5da102_084e33c1","updated":"2016-11-07 17:35:03.000000000","message":"Done","commit_id":"430c670f10fb2778183866cafd2d28c1ed18993f"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9f561391da87ff48c247f8042a83b9c6a525d8d7","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                        \"DEFaUlT\"}},"},{"line_number":240,"context_line":"                  expected_status\u003dhttp_client.NOT_FOUND)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def test_list_user_without_filter(self):"},{"line_number":243,"context_line":"        \"\"\"Call ``GET /users`` without filter.\"\"\""},{"line_number":244,"context_line":"        resource_url \u003d \u0027/users\u0027"},{"line_number":245,"context_line":"        self.config_fixture.config(group\u003d\u0027identity\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_eb7e62ad","line":242,"range":{"start_line":242,"start_character":8,"end_line":242,"end_character":37},"updated":"2016-11-07 17:51:02.000000000","message":"maybe: test_list_users_without_filter_fails","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"58ffbd28d98ff88a0e79ef2c884544b30d5e938a","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                        \"DEFaUlT\"}},"},{"line_number":240,"context_line":"                  expected_status\u003dhttp_client.NOT_FOUND)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def test_list_user_without_filter(self):"},{"line_number":243,"context_line":"        \"\"\"Call ``GET /users`` without filter.\"\"\""},{"line_number":244,"context_line":"        resource_url \u003d \u0027/users\u0027"},{"line_number":245,"context_line":"        self.config_fixture.config(group\u003d\u0027identity\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_5e981e78","line":242,"range":{"start_line":242,"start_character":8,"end_line":242,"end_character":37},"in_reply_to":"9a629dbe_eb7e62ad","updated":"2016-11-19 16:47:34.000000000","message":"Done","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9f561391da87ff48c247f8042a83b9c6a525d8d7","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                                   list_users_without_filter\u003dFalse)"},{"line_number":250,"context_line":"        self.get(resource_url, expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def test_list_user_filter_sucess(self):"},{"line_number":253,"context_line":"        \"\"\"Call ``GET /users`` without filter.\"\"\""},{"line_number":254,"context_line":"        resource_url \u003d \u0027/users?domain_id\u003d%s\u0027 % self.domain_id"},{"line_number":255,"context_line":"        self.config_fixture.config(group\u003d\u0027identity\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_cb58be59","line":252,"range":{"start_line":252,"start_character":18,"end_line":252,"end_character":22},"updated":"2016-11-07 17:51:02.000000000","message":"users","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"58ffbd28d98ff88a0e79ef2c884544b30d5e938a","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                                   list_users_without_filter\u003dFalse)"},{"line_number":250,"context_line":"        self.get(resource_url, expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def test_list_user_filter_sucess(self):"},{"line_number":253,"context_line":"        \"\"\"Call ``GET /users`` without filter.\"\"\""},{"line_number":254,"context_line":"        resource_url \u003d \u0027/users?domain_id\u003d%s\u0027 % self.domain_id"},{"line_number":255,"context_line":"        self.config_fixture.config(group\u003d\u0027identity\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_be705241","line":252,"range":{"start_line":252,"start_character":18,"end_line":252,"end_character":22},"in_reply_to":"9a629dbe_cb58be59","updated":"2016-11-19 16:47:34.000000000","message":"Done","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9f561391da87ff48c247f8042a83b9c6a525d8d7","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        self.get(resource_url, expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def test_list_user_filter_sucess(self):"},{"line_number":253,"context_line":"        \"\"\"Call ``GET /users`` without filter.\"\"\""},{"line_number":254,"context_line":"        resource_url \u003d \u0027/users?domain_id\u003d%s\u0027 % self.domain_id"},{"line_number":255,"context_line":"        self.config_fixture.config(group\u003d\u0027identity\u0027,"},{"line_number":256,"context_line":"                                   list_users_without_filter\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_4be82e7d","line":253,"range":{"start_line":253,"start_character":31,"end_line":253,"end_character":38},"updated":"2016-11-07 17:51:02.000000000","message":"using a filter?","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"58ffbd28d98ff88a0e79ef2c884544b30d5e938a","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        self.get(resource_url, expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def test_list_user_filter_sucess(self):"},{"line_number":253,"context_line":"        \"\"\"Call ``GET /users`` without filter.\"\"\""},{"line_number":254,"context_line":"        resource_url \u003d \u0027/users?domain_id\u003d%s\u0027 % self.domain_id"},{"line_number":255,"context_line":"        self.config_fixture.config(group\u003d\u0027identity\u0027,"},{"line_number":256,"context_line":"                                   list_users_without_filter\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_de918e48","line":253,"range":{"start_line":253,"start_character":31,"end_line":253,"end_character":38},"in_reply_to":"9a629dbe_4be82e7d","updated":"2016-11-19 16:47:34.000000000","message":"Done","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"dc8747664532082d01f43956e335156d48ebcb63","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    def test_list_users_filter_sucess(self):"},{"line_number":253,"context_line":"        \"\"\"Call ``GET /users`` using a filter.\"\"\""},{"line_number":254,"context_line":"        resource_url \u003d \u0027/users?domain_id\u003d%s\u0027 % self.domain_id"},{"line_number":255,"context_line":"        self.config_fixture.config(group\u003d\u0027identity\u0027,"},{"line_number":256,"context_line":"                                   list_users_without_filter\u003dTrue)"},{"line_number":257,"context_line":"        self.get(resource_url, expected_status\u003dhttp_client.OK)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def test_list_head_users(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_268514ce","line":256,"range":{"start_line":255,"start_character":8,"end_line":256,"end_character":66},"updated":"2016-11-20 04:47:25.000000000","message":"include the test where this is set to False and listing with a filter still works, you\u0027re right there!","commit_id":"ba8d852d992950d866ed230d0665b4640651de72"}],"releasenotes/notes/config-option-list-users-without-filter-d6284d9a72d88534.yaml":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9f561391da87ff48c247f8042a83b9c6a525d8d7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Listing all users is not practical for large organizations,"},{"line_number":4,"context_line":"    so we decided to creates a config option `list_users_without_filter`"},{"line_number":5,"context_line":"    to enabled/disable list users without a filter. The default value"},{"line_number":6,"context_line":"    will be `True`."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a629dbe_ebf9024f","line":4,"range":{"start_line":4,"start_character":21,"end_line":4,"end_character":28},"updated":"2016-11-07 17:51:02.000000000","message":"create","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"91b0d0d2d423719d1684ebbc073027da2f9dff38","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Listing all users is not practical for large organizations,"},{"line_number":4,"context_line":"    so we decided to creates a config option `list_users_without_filter`"},{"line_number":5,"context_line":"    to enabled/disable list users without a filter. The default value"},{"line_number":6,"context_line":"    will be `True`."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a629dbe_a641ef3b","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":17},"updated":"2016-11-08 05:41:21.000000000","message":"this isn\u0027t the normal style we wrote release notes in....just state that a new option is now supported..","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"58ffbd28d98ff88a0e79ef2c884544b30d5e938a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Listing all users is not practical for large organizations,"},{"line_number":4,"context_line":"    so we decided to creates a config option `list_users_without_filter`"},{"line_number":5,"context_line":"    to enabled/disable list users without a filter. The default value"},{"line_number":6,"context_line":"    will be `True`."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_7e7a3a25","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":17},"in_reply_to":"9a629dbe_a641ef3b","updated":"2016-11-19 16:47:34.000000000","message":"OK, I\u0027ll improve this state","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a638308c0a56ec9dc6eccb2d438e7f410e6edd0c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Listing all users is not practical for large organizations,"},{"line_number":4,"context_line":"    so we decided to creates a config option `list_users_without_filter`"},{"line_number":5,"context_line":"    to enabled/disable list users without a filter. The default value"},{"line_number":6,"context_line":"    will be `True`."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a629dbe_8ca46eba","line":6,"range":{"start_line":6,"start_character":13,"end_line":6,"end_character":17},"updated":"2016-11-11 01:55:14.000000000","message":"Default value in a conf file is true not True. In Python it would be True.","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9f561391da87ff48c247f8042a83b9c6a525d8d7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Listing all users is not practical for large organizations,"},{"line_number":4,"context_line":"    so we decided to creates a config option `list_users_without_filter`"},{"line_number":5,"context_line":"    to enabled/disable list users without a filter. The default value"},{"line_number":6,"context_line":"    will be `True`."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a629dbe_6ba41257","line":6,"range":{"start_line":6,"start_character":12,"end_line":6,"end_character":18},"updated":"2016-11-07 17:51:02.000000000","message":"this is not backward compatible. The default value should be false.","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"2b0aa457ec61a2e8cb14b538cd1f2401963c248f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Listing all users is not practical for large organizations,"},{"line_number":4,"context_line":"    so we decided to creates a config option `list_users_without_filter`"},{"line_number":5,"context_line":"    to enabled/disable list users without a filter. The default value"},{"line_number":6,"context_line":"    will be `True`."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a629dbe_55da174d","line":6,"range":{"start_line":6,"start_character":12,"end_line":6,"end_character":18},"in_reply_to":"9a629dbe_6ba41257","updated":"2016-11-09 21:19:05.000000000","message":"++","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a638308c0a56ec9dc6eccb2d438e7f410e6edd0c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Listing all users is not practical for large organizations,"},{"line_number":4,"context_line":"    so we decided to creates a config option `list_users_without_filter`"},{"line_number":5,"context_line":"    to enabled/disable list users without a filter. The default value"},{"line_number":6,"context_line":"    will be `True`."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a629dbe_2c944241","line":6,"range":{"start_line":6,"start_character":12,"end_line":6,"end_character":18},"in_reply_to":"9a629dbe_6ba41257","updated":"2016-11-11 01:55:14.000000000","message":"Hmm, I think this is correct, no?  We already allow calling getUsers with no filter.","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"58ffbd28d98ff88a0e79ef2c884544b30d5e938a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Listing all users is not practical for large organizations,"},{"line_number":4,"context_line":"    so we decided to creates a config option `list_users_without_filter`"},{"line_number":5,"context_line":"    to enabled/disable list users without a filter. The default value"},{"line_number":6,"context_line":"    will be `True`."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_5e7f3e14","line":6,"range":{"start_line":6,"start_character":13,"end_line":6,"end_character":17},"in_reply_to":"9a629dbe_8ca46eba","updated":"2016-11-19 16:47:34.000000000","message":"Actually, as Eric said, we already filter users without filter. \n\nI\u0027ll change it do \u0027true\u0027","commit_id":"e19448f0e5d44bbb5a965a767677c849885931b6"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"dc8747664532082d01f43956e335156d48ebcb63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7a77a97e_2637d44d","updated":"2016-11-20 04:47:25.000000000","message":"suggested wording:\n\nfeatures:\n  - \u003e\n    [`bug 1211586 \u003chttps://bugs.launchpad.net/keystone/+bug/1211586\u003e`_]\n    New configuration option ``[identity] list_users_without_filter``\n    defaults to ``True``) has been created. When set to ``False``,\n    a `ValidationError` is raised if no filter (``domain_id``,\n    ``enabled``, ``name``)is used when attempting to list all\n    users via the `GET /v3/users` API.","commit_id":"ba8d852d992950d866ed230d0665b4640651de72"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"dc8747664532082d01f43956e335156d48ebcb63","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Create a config option `list_users_without_filter` to enabled/disable"},{"line_number":4,"context_line":"    list users without a filter. The default value will be `true`."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7a77a97e_c62d40ff","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2016-11-20 04:47:25.000000000","message":"there is a new config option, so call it a feature","commit_id":"ba8d852d992950d866ed230d0665b4640651de72"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"efcd54daf6787dcfd8ba583d46c24539758c2d38","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Create a config option `list_users_without_filter` to enabled/disable"},{"line_number":4,"context_line":"    list users without a filter. The default value will be `true`."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7a77a97e_e03144a3","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":10},"updated":"2016-11-19 19:59:19.000000000","message":"Created","commit_id":"ba8d852d992950d866ed230d0665b4640651de72"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"efcd54daf6787dcfd8ba583d46c24539758c2d38","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Create a config option `list_users_without_filter` to enabled/disable"},{"line_number":4,"context_line":"    list users without a filter. The default value will be `true`."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7a77a97e_c02e0842","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":8},"updated":"2016-11-19 19:59:19.000000000","message":"listing","commit_id":"ba8d852d992950d866ed230d0665b4640651de72"}]}