)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a0e646aba617d85cd2dd708eeae010b0d8ac2779","unresolved":false,"context_lines":[{"line_number":10,"context_line":" Accept: application/xml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"To share code, moved assertEqualXML from test_serializer"},{"line_number":13,"context_line":"to keystone.test."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I92e28a9167d0c77fc7efbd1eda2893ec1128354f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPH%2F%2FbwY%3D","line":13,"updated":"2013-06-04 01:55:59.000000000","message":"Should this have a link to the bug that the patch that depends on this one fixes?","commit_id":"a3d05032dc9082eedee8075080e15e7762b49ace"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2696dc0085652e90dd86692e9e9b1cbba356e2ea","unresolved":false,"context_lines":[{"line_number":10,"context_line":" Accept: application/xml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"To share code, moved assertEqualXML from test_serializer"},{"line_number":13,"context_line":"to keystone.test."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I92e28a9167d0c77fc7efbd1eda2893ec1128354f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPX%2F%2F%2BIg%3D","line":13,"in_reply_to":"AAAAPH%2F%2FbwY%3D","updated":"2013-06-04 21:20:26.000000000","message":"This change doesn\u0027t fix the bug, and I don\u0027t think that adding a testcase to cover existing behavior requires justification. So I don\u0027t plan to change this unless others want the bug referenced in the commit message.","commit_id":"a3d05032dc9082eedee8075080e15e7762b49ace"}],"tests/test_versions.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"05589c191d9c793edbd59db83d3908da01789773","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    \u003c/links\u003e"},{"line_number":300,"context_line":"  \u003c/version\u003e"},{"line_number":301,"context_line":"\u003c/versions\u003e"},{"line_number":302,"context_line":"\"\"\" % dict(port\u003dCONF.public_port)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        self.assertEqualXML(resp_xml, exp_response_xml)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F%2F0g%3D","line":302,"updated":"2013-06-04 06:19:14.000000000","message":"Fantastic that we are adding some XML tests: +1 !!\n\nHow important do we think it is to add xml tests for the other test cases done with json in this class?  If we plan to do that, then we should look at breaking the xml responses down into sub blocks (like is done for json) so that we can more easily create these tests without duplication of expected response data.","commit_id":"a3d05032dc9082eedee8075080e15e7762b49ace"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2696dc0085652e90dd86692e9e9b1cbba356e2ea","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    \u003c/links\u003e"},{"line_number":300,"context_line":"  \u003c/version\u003e"},{"line_number":301,"context_line":"\u003c/versions\u003e"},{"line_number":302,"context_line":"\"\"\" % dict(port\u003dCONF.public_port)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        self.assertEqualXML(resp_xml, exp_response_xml)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F%2BIU%3D","line":302,"in_reply_to":"AAAAPX%2F%2F%2F0g%3D","updated":"2013-06-04 21:20:26.000000000","message":"Moving the pieces out seems like a pretty easy refactoring to me, and since it\u0027s not being used just yet (there\u0027s only the one test) I\u0027d rather leave that work to the time when it\u0027s actually needed (if ever).\n\nThat said, I\u0027ll look into adding the other tests.","commit_id":"a3d05032dc9082eedee8075080e15e7762b49ace"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"7067dee441537a4dc24276fa03cc0b47e776450e","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        data \u003d jsonutils.loads(resp.body)"},{"line_number":258,"context_line":"        self.assertEqual(data, v2_only_response)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def test_xml(self):"},{"line_number":261,"context_line":"        # This is what the version response looks like when request XML."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        headers \u003d {\u0027Accept\u0027: \u0027application/xml\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2Fvjc%3D","line":260,"updated":"2013-06-11 15:28:21.000000000","message":"this would be more appropriately named as test_public_versions_xml given the naming convention used by other tests","commit_id":"75f426dac8d1ebe7820c9e3b010cca212e3e81f1"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"972b224acd83eec7315957728fb96298842d53bc","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                          v3_VERSION_DATA +"},{"line_number":312,"context_line":"                          v2_VERSION_DATA + \"\"\""},{"line_number":313,"context_line":"\u003c/versions\u003e"},{"line_number":314,"context_line":"\"\"\") % dict(namespace\u003dXML_NAMESPACE_ATTR, v3_namespace\u003d\u0027\u0027, v2_namespace\u003d\u0027\u0027))"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    def setUp(self):"},{"line_number":317,"context_line":"        super(XmlVersionTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2Fmo0%3D","line":314,"updated":"2013-06-14 15:18:52.000000000","message":"308-314 are pretty hard to read :(","commit_id":"dc7fdb031a41f2c8e8f7479dc8e9d232a8da86de"}]}