)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8559e3e57dabcd78c0bfe68cdbccd92a5c17fb35","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Invalidate token cache after token delete"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After deleting a token, the token cache needs to be invalidated."},{"line_number":10,"context_line":"This was only hapenning for persistent tokens."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch pulls the token cachec invalidation to the token provider"},{"line_number":13,"context_line":"so that it happens regardless the token is persistent or not."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_15ad0b84","line":10,"updated":"2016-05-16 16:57:08.000000000","message":"happening*","commit_id":"7067fb31b547c71c9b6a99a1328e54c71bdd3388"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"0f67a3f3074e6155d77c73fdca3f210d371a20eb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Invalidate token cache after token delete"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After deleting a token, the token cache needs to be invalidated."},{"line_number":10,"context_line":"This was only hapenning for persistent tokens."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch pulls the token cachec invalidation to the token provider"},{"line_number":13,"context_line":"so that it happens regardless the token is persistent or not."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_d1d753bd","line":10,"in_reply_to":"dab17558_15ad0b84","updated":"2016-05-31 00:44:18.000000000","message":"Done","commit_id":"7067fb31b547c71c9b6a99a1328e54c71bdd3388"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8559e3e57dabcd78c0bfe68cdbccd92a5c17fb35","unresolved":false,"context_lines":[{"line_number":9,"context_line":"After deleting a token, the token cache needs to be invalidated."},{"line_number":10,"context_line":"This was only hapenning for persistent tokens."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch pulls the token cachec invalidation to the token provider"},{"line_number":13,"context_line":"so that it happens regardless the token is persistent or not."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I496531a30559f0cf021c4478404093a99f2fbe3d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_55cb1353","line":12,"updated":"2016-05-16 16:57:08.000000000","message":"cache*","commit_id":"7067fb31b547c71c9b6a99a1328e54c71bdd3388"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"0f67a3f3074e6155d77c73fdca3f210d371a20eb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"After deleting a token, the token cache needs to be invalidated."},{"line_number":10,"context_line":"This was only hapenning for persistent tokens."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch pulls the token cachec invalidation to the token provider"},{"line_number":13,"context_line":"so that it happens regardless the token is persistent or not."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I496531a30559f0cf021c4478404093a99f2fbe3d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_31e7bfb1","line":12,"in_reply_to":"dab17558_55cb1353","updated":"2016-05-31 00:44:18.000000000","message":"Done","commit_id":"7067fb31b547c71c9b6a99a1328e54c71bdd3388"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8559e3e57dabcd78c0bfe68cdbccd92a5c17fb35","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This was only hapenning for persistent tokens."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch pulls the token cachec invalidation to the token provider"},{"line_number":13,"context_line":"so that it happens regardless the token is persistent or not."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I496531a30559f0cf021c4478404093a99f2fbe3d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_b5307f57","line":13,"updated":"2016-05-16 16:57:08.000000000","message":"nit: regardless of the token provider being used or if the token has actually been persisted.","commit_id":"7067fb31b547c71c9b6a99a1328e54c71bdd3388"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"0f67a3f3074e6155d77c73fdca3f210d371a20eb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This was only hapenning for persistent tokens."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch pulls the token cachec invalidation to the token provider"},{"line_number":13,"context_line":"so that it happens regardless the token is persistent or not."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I496531a30559f0cf021c4478404093a99f2fbe3d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_11e27b9f","line":13,"in_reply_to":"dab17558_b5307f57","updated":"2016-05-31 00:44:18.000000000","message":"Done","commit_id":"7067fb31b547c71c9b6a99a1328e54c71bdd3388"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"6aba758fb22bf1af383cba50eeaaf69f3d6c6af8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Invalidate token cache after token delete"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After deleting a token, the token cache needs to be invalidated."},{"line_number":10,"context_line":"This was only happenning for persistent tokens."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch also calls the token cache invalidation on the token provider"},{"line_number":13,"context_line":"so that it happens regardless of the token provider being used or if the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aa78d24_1cdd730e","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":47},"updated":"2016-07-05 16:58:46.000000000","message":"Is this still part of this patch? I\u0027m not sure it\u0027s needed anyway, since these are caught by is_valid_token()","commit_id":"5d86a597e85ce394aa7e286ac77b6d7ba0c77efd"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"cc9cb7a79d9c7c052f9b26ca7c9356678317023f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Invalidate token cache after token delete"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After deleting a token, the token cache needs to be invalidated."},{"line_number":10,"context_line":"This was only happenning for persistent tokens."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch also calls the token cache invalidation on the token provider"},{"line_number":13,"context_line":"so that it happens regardless of the token provider being used or if the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_cdd3465e","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":47},"in_reply_to":"1aa78d24_1cdd730e","updated":"2016-08-09 16:23:04.000000000","message":"Yes it\u0027s caught by the revocation list. But I think it\u0027s worth it to invalidate for non-persistent tokens too.","commit_id":"5d86a597e85ce394aa7e286ac77b6d7ba0c77efd"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cac7bdfe74d42b4c1df2396f19bdaf03c770ba63","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Samuel de Medeiros Queiroz \u003csamueldmq@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-07 11:14:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Invalidate token cache after token delete"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After deleting a token, the token cache needs to be invalidated."},{"line_number":10,"context_line":"This was only happenning for persistent tokens."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a6eadb0_72602d36","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":41},"updated":"2016-12-20 17:38:55.000000000","message":"\"Always invalid token after delete, regardless of persistence\"","commit_id":"fd13637f9c839a90f1a97b649b71a9bd268971bd"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"58a66edcb4db7a7d166195b03167a1eb0aaae0e4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Invalidate token cache after token delete"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After deleting a token, the token cache needs to be invalidated."},{"line_number":10,"context_line":"This was only happenning for persistent tokens."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch also calls the token cache invalidation on the token provider"},{"line_number":13,"context_line":"so that it happens regardless of the token provider being used or if the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a6eadb0_9298691d","line":10,"updated":"2016-12-20 17:41:31.000000000","message":"Hmm - I\u0027m surprised this wasn\u0027t caught by tests.","commit_id":"fd13637f9c839a90f1a97b649b71a9bd268971bd"}],"keystone/token/persistence/core.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"8341a5fafecc31d67f2ac6736d1936c13835ac60","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        # invalidated? We maintain a cached revocation list, which should be"},{"line_number":190,"context_line":"        # consulted before accepting a token as valid.  For now we will"},{"line_number":191,"context_line":"        # do the explicit individual token invalidation."},{"line_number":192,"context_line":"        self._get_token.invalidate(self, token_id)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"@dependency.requires(\u0027token_provider_api\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_9738ff3e","line":192,"updated":"2016-05-31 12:27:53.000000000","message":"Is this method might be unnecessary after this change?","commit_id":"f42caf817e66bfff43c58b8b66c43df24b4eef2f"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"21dafc07dd99797aebe5e57b9e26e16152ac94d8","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        # invalidated? We maintain a cached revocation list, which should be"},{"line_number":190,"context_line":"        # consulted before accepting a token as valid.  For now we will"},{"line_number":191,"context_line":"        # do the explicit individual token invalidation."},{"line_number":192,"context_line":"        self._get_token.invalidate(self, token_id)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"@dependency.requires(\u0027token_provider_api\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_36f120ce","line":192,"in_reply_to":"9abb7d3a_9738ff3e","updated":"2016-06-08 11:47:51.000000000","message":"It is necessary to invalidate _get_token cache, which is a private method to the persistence layer","commit_id":"f42caf817e66bfff43c58b8b66c43df24b4eef2f"}],"keystone/token/provider.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"ba28add70cce7df24060c9375b5f190ca9cf1f6e","unresolved":false,"context_lines":[{"line_number":468,"context_line":"        if CONF.token.revoke_by_id and self._needs_persistence:"},{"line_number":469,"context_line":"            self._persistence.delete_token(token_id\u003dtoken_id)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        self.invalidate_individual_token_cache(token_id)"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"    def list_revoked_tokens(self):"},{"line_number":474,"context_line":"        return self._persistence.list_revoked_tokens()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_f31c6d79","line":471,"updated":"2016-06-20 12:30:23.000000000","message":"the comment in the other file also applies here","commit_id":"f42caf817e66bfff43c58b8b66c43df24b4eef2f"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"9aaa2432e788a7b3ab2a5c2a8adbd9ac982e6de3","unresolved":false,"context_lines":[{"line_number":468,"context_line":"        if CONF.token.revoke_by_id and self._needs_persistence:"},{"line_number":469,"context_line":"            self._persistence.delete_token(token_id\u003dtoken_id)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        # FIXME(morganfainberg): Does this cache actually need to be"},{"line_number":472,"context_line":"        # invalidated? We maintain a cached revocation list, which should be"},{"line_number":473,"context_line":"        # consulted before accepting a token as valid.  For now we will"},{"line_number":474,"context_line":"        # do the explicit individual token invalidation."}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_34b49280","line":471,"range":{"start_line":471,"start_character":16,"end_line":471,"end_character":30},"updated":"2016-07-06 14:43:21.000000000","message":"I thought you are is samueldmq :)","commit_id":"5d86a597e85ce394aa7e286ac77b6d7ba0c77efd"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"cc9cb7a79d9c7c052f9b26ca7c9356678317023f","unresolved":false,"context_lines":[{"line_number":468,"context_line":"        if CONF.token.revoke_by_id and self._needs_persistence:"},{"line_number":469,"context_line":"            self._persistence.delete_token(token_id\u003dtoken_id)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        # FIXME(morganfainberg): Does this cache actually need to be"},{"line_number":472,"context_line":"        # invalidated? We maintain a cached revocation list, which should be"},{"line_number":473,"context_line":"        # consulted before accepting a token as valid.  For now we will"},{"line_number":474,"context_line":"        # do the explicit individual token invalidation."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_edba8ae0","line":471,"range":{"start_line":471,"start_character":16,"end_line":471,"end_character":30},"in_reply_to":"1aa78d24_34b49280","updated":"2016-08-09 16:23:04.000000000","message":"Indeed I am :)\n\nI am keeping morgan\u0027s name as it\u0027s his comment from _invalidate_individual_token_cache in keystone/token/persistence/core.py","commit_id":"5d86a597e85ce394aa7e286ac77b6d7ba0c77efd"}]}