)]}'
{"keystone/auth/controllers.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"fefea59a5fbb6900e7d0b117d6ee27c668abe31b","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                # Till we change th spec which issues a project-scoped token"},{"line_number":465,"context_line":"                # if the default_project_id is a domain, this should be"},{"line_number":466,"context_line":"                # be treated as project does not exist."},{"line_number":467,"context_line":"                raise exception.ProjectNotFound(project_id\u003ddefault_project_id)"},{"line_number":468,"context_line":"            default_project_domain_ref \u003d self.resource_api.get_domain("},{"line_number":469,"context_line":"                default_project_ref[\u0027domain_id\u0027])"},{"line_number":470,"context_line":"            if (default_project_ref.get(\u0027enabled\u0027, True) and"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_932ffef5","line":467,"updated":"2016-05-18 02:49:37.000000000","message":"Don\u0027t do it this way. Prevent the user from setting this in the first place. This is weird the way it is written.","commit_id":"d43b8511cab2f160ff00244ffc11065ed6786710"}],"keystone/identity/core.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"8298ceb0fff06837f94380a043b23fb2a834189d","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        return self._set_domain_id_and_mapping("},{"line_number":829,"context_line":"            ref, domain_id, driver, mapping.EntityType.USER)"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    def _assert_default_project_id_is_not_domain(self, user_ref):"},{"line_number":832,"context_line":"        default_project_id \u003d user_ref.get(\u0027default_project_id\u0027)"},{"line_number":833,"context_line":"        if default_project_id:"},{"line_number":834,"context_line":"            # make sure project is not a domain"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_4fd5691a","line":831,"range":{"start_line":831,"start_character":54,"end_line":831,"end_character":63},"updated":"2016-05-20 01:33:36.000000000","message":"suggest just taking an id here instead, don\u0027t pull it out of the user_ref in this method, do that in the calling method.","commit_id":"21698f481c81051a4d0e05ef2a5cfd0fa9c0c742"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"a5a1b5a0703f6a3d92c01a24be8f78389b3c4faa","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        return self._set_domain_id_and_mapping("},{"line_number":829,"context_line":"            ref, domain_id, driver, mapping.EntityType.USER)"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    def _assert_default_project_id_is_not_domain(self, user_ref):"},{"line_number":832,"context_line":"        default_project_id \u003d user_ref.get(\u0027default_project_id\u0027)"},{"line_number":833,"context_line":"        if default_project_id:"},{"line_number":834,"context_line":"            # make sure project is not a domain"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_39564c5c","line":831,"range":{"start_line":831,"start_character":54,"end_line":831,"end_character":63},"in_reply_to":"bab6814e_4fd5691a","updated":"2016-05-20 16:25:50.000000000","message":"Done","commit_id":"21698f481c81051a4d0e05ef2a5cfd0fa9c0c742"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"2826854ccaad6e2fdf35f3415520d33817593b94","unresolved":false,"context_lines":[{"line_number":835,"context_line":"            try:"},{"line_number":836,"context_line":"                project_ref \u003d self.resource_api.get_project(default_project_id)"},{"line_number":837,"context_line":"                if project_ref[\u0027is_domain\u0027] is True:"},{"line_number":838,"context_line":"                    msg \u003d _(\u0027Default project cannot be a domain\u0027)"},{"line_number":839,"context_line":"                    raise exception.ValidationError(message\u003dmsg)"},{"line_number":840,"context_line":"            except exception.ProjectNotFound:"},{"line_number":841,"context_line":"                # should be idempotent if project is not found so that it is"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_b61b6c72","line":838,"range":{"start_line":838,"start_character":29,"end_line":838,"end_character":63},"updated":"2016-05-20 15:03:34.000000000","message":"suggest to add something clearer here","commit_id":"21698f481c81051a4d0e05ef2a5cfd0fa9c0c742"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"a5a1b5a0703f6a3d92c01a24be8f78389b3c4faa","unresolved":false,"context_lines":[{"line_number":835,"context_line":"            try:"},{"line_number":836,"context_line":"                project_ref \u003d self.resource_api.get_project(default_project_id)"},{"line_number":837,"context_line":"                if project_ref[\u0027is_domain\u0027] is True:"},{"line_number":838,"context_line":"                    msg \u003d _(\u0027Default project cannot be a domain\u0027)"},{"line_number":839,"context_line":"                    raise exception.ValidationError(message\u003dmsg)"},{"line_number":840,"context_line":"            except exception.ProjectNotFound:"},{"line_number":841,"context_line":"                # should be idempotent if project is not found so that it is"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_d95c607f","line":838,"range":{"start_line":838,"start_character":29,"end_line":838,"end_character":63},"in_reply_to":"bab6814e_b61b6c72","updated":"2016-05-20 16:25:50.000000000","message":"Done","commit_id":"21698f481c81051a4d0e05ef2a5cfd0fa9c0c742"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"8298ceb0fff06837f94380a043b23fb2a834189d","unresolved":false,"context_lines":[{"line_number":837,"context_line":"                if project_ref[\u0027is_domain\u0027] is True:"},{"line_number":838,"context_line":"                    msg \u003d _(\u0027Default project cannot be a domain\u0027)"},{"line_number":839,"context_line":"                    raise exception.ValidationError(message\u003dmsg)"},{"line_number":840,"context_line":"            except exception.ProjectNotFound:"},{"line_number":841,"context_line":"                # should be idempotent if project is not found so that it is"},{"line_number":842,"context_line":"                # backward compatible"},{"line_number":843,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_effeddac","line":840,"updated":"2016-05-20 01:33:36.000000000","message":"Raise a validation error out instead please. and make sure this is telling the user \"project is a domain\". This shouldn\u0027t be a 404.","commit_id":"21698f481c81051a4d0e05ef2a5cfd0fa9c0c742"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"2826854ccaad6e2fdf35f3415520d33817593b94","unresolved":false,"context_lines":[{"line_number":837,"context_line":"                if project_ref[\u0027is_domain\u0027] is True:"},{"line_number":838,"context_line":"                    msg \u003d _(\u0027Default project cannot be a domain\u0027)"},{"line_number":839,"context_line":"                    raise exception.ValidationError(message\u003dmsg)"},{"line_number":840,"context_line":"            except exception.ProjectNotFound:"},{"line_number":841,"context_line":"                # should be idempotent if project is not found so that it is"},{"line_number":842,"context_line":"                # backward compatible"},{"line_number":843,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_f6ea140e","line":840,"in_reply_to":"bab6814e_effeddac","updated":"2016-05-20 15:03:34.000000000","message":"isn\u0027t it doing that already? it only falls in this case if the project_id doesn\u0027t exist (being a domain or not)","commit_id":"21698f481c81051a4d0e05ef2a5cfd0fa9c0c742"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"a5a1b5a0703f6a3d92c01a24be8f78389b3c4faa","unresolved":false,"context_lines":[{"line_number":837,"context_line":"                if project_ref[\u0027is_domain\u0027] is True:"},{"line_number":838,"context_line":"                    msg \u003d _(\u0027Default project cannot be a domain\u0027)"},{"line_number":839,"context_line":"                    raise exception.ValidationError(message\u003dmsg)"},{"line_number":840,"context_line":"            except exception.ProjectNotFound:"},{"line_number":841,"context_line":"                # should be idempotent if project is not found so that it is"},{"line_number":842,"context_line":"                # backward compatible"},{"line_number":843,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_196c2834","line":840,"in_reply_to":"bab6814e_f6ea140e","updated":"2016-05-20 16:25:50.000000000","message":"right, that\u0027s already done. This is just to make it idempotent.","commit_id":"21698f481c81051a4d0e05ef2a5cfd0fa9c0c742"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"58eafd317707f3e46bf96a006d5e626e427255ba","unresolved":false,"context_lines":[{"line_number":834,"context_line":"            try:"},{"line_number":835,"context_line":"                project_ref \u003d self.resource_api.get_project(default_project_id)"},{"line_number":836,"context_line":"                if project_ref[\u0027is_domain\u0027] is True:"},{"line_number":837,"context_line":"                    msg \u003d _(\"User\u0027s default project ID cannot be a domain ID.\")"},{"line_number":838,"context_line":"                    raise exception.ValidationError(message\u003dmsg)"},{"line_number":839,"context_line":"            except exception.ProjectNotFound:"},{"line_number":840,"context_line":"                # should be idempotent if project is not found so that it is"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_15dfbd0d","line":837,"updated":"2016-05-20 22:27:09.000000000","message":"In a follow-up, pass on the information for what the ID was.","commit_id":"8a7133f9506e0675ee5e5da9372d9be671eaaddf"}]}