)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"26421391cd3c200608e5b335d7bda4ba41955bce","unresolved":false,"context_lines":[{"line_number":10,"context_line":"federated service provider. Environment variables are specified"},{"line_number":11,"context_line":"in local.conf to distinguish between the k2k-idp and sp."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"More documentation is available in /devstack/README.rst"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8c416f4d19011d643768759a64c2d70de10fe9e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9abb7d3a_70f6e58f","line":13,"updated":"2016-06-01 21:11:50.000000000","message":"I think breton has a patch up against the specs repository that sounds very familiar to this. Maybe incorporate it or link to it once it\u0027s merged?","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"1dec2cf68bb5909205a380ac8b80ade034bfd4d9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"federated service provider. Environment variables are specified"},{"line_number":11,"context_line":"in local.conf to distinguish between the k2k-idp and sp."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"More documentation is available in /devstack/README.rst"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8c416f4d19011d643768759a64c2d70de10fe9e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9abb7d3a_6bc27886","line":13,"in_reply_to":"9abb7d3a_70f6e58f","updated":"2016-06-01 21:25:32.000000000","message":"Yes, this actually implements that spec.","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e3c20807911e50e7521788704c00cb832b64de9d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Devstack plugin for Federation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Devstack plugin for setting up a k2k identity provider or a"},{"line_number":10,"context_line":"federated service provider. Environment variables are specified"},{"line_number":11,"context_line":"in local.conf to distinguish between the k2k-idp and sp."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7aa08908_a07389b0","line":9,"range":{"start_line":9,"start_character":54,"end_line":9,"end_character":58},"updated":"2016-06-06 15:15:42.000000000","message":"and/or right? I can setup both if I want to?","commit_id":"f51c2da5e6c5b695d4b7e5ba6f19a5ec57a311a1"}],"devstack/README.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"29b191b714d08e3820d5a9be3a3d502b2d4d28da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9abb7d3a_4a756596","updated":"2016-05-31 05:56:01.000000000","message":"clean up the white spaces here too:\n\ni think these docs still need a bit more content, are both steps required? how will tests run against this setup?","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"a629df1065859ee76f85d68980e53be7a666ec23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9abb7d3a_2bad2288","in_reply_to":"9abb7d3a_4a756596","updated":"2016-06-01 16:06:17.000000000","message":"Fixed the whitespace. Updated the documentation.","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"26421391cd3c200608e5b335d7bda4ba41955bce","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This DevStack plugin automates the process of setting up a federated Keystone,"},{"line_number":6,"context_line":"either as an Identity Provider or as a Service Provider. These functions can"},{"line_number":7,"context_line":"either be enabled on the same DevStack or on separate ones depending on use"},{"line_number":8,"context_line":"case."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9abb7d3a_706b851e","line":6,"updated":"2016-06-01 21:11:50.000000000","message":"Does it automate setting keystone up as both?","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"1dec2cf68bb5909205a380ac8b80ade034bfd4d9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This DevStack plugin automates the process of setting up a federated Keystone,"},{"line_number":6,"context_line":"either as an Identity Provider or as a Service Provider. These functions can"},{"line_number":7,"context_line":"either be enabled on the same DevStack or on separate ones depending on use"},{"line_number":8,"context_line":"case."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9abb7d3a_cbbd6403","line":6,"in_reply_to":"9abb7d3a_706b851e","updated":"2016-06-01 21:25:32.000000000","message":"Yes.","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"ede47e0f651402f6d8df8e22f4b9518cac2535ac","unresolved":false,"context_lines":[{"line_number":15,"context_line":".. code-block:: bash"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    # local.conf"},{"line_number":18,"context_line":"    enable_plugin keystone $KEYSTONE_REPO"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"K2K Identity Provider"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9abb7d3a_8e6df7ce","line":18,"range":{"start_line":18,"start_character":27,"end_line":18,"end_character":41},"updated":"2016-06-02 16:27:55.000000000","message":"just change it to upstream keystone repo. Anonymous https would be enough.","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"a60d5d7c23107d0d19155c51ac3913137f0d412d","unresolved":false,"context_lines":[{"line_number":15,"context_line":".. code-block:: bash"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    # local.conf"},{"line_number":18,"context_line":"    enable_plugin keystone $KEYSTONE_REPO"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"K2K Identity Provider"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9abb7d3a_f14584b3","line":18,"range":{"start_line":18,"start_character":27,"end_line":18,"end_character":41},"in_reply_to":"9abb7d3a_8e6df7ce","updated":"2016-06-02 16:46:48.000000000","message":"I\u0027m not entirely sure. In the case where you want to pull a specific keystone review you overwrite KEYSTONE_REPO and KEYSTONE_BRANCH in local.conf. I\u0027m not sure if DevStack clones the plugins from git before cloning keystone/nova/etc., in that case it would clone the current master for keystone instead of the one containing the review.","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"54b593e0d77a13051bf19e7dc470a7a522bb70d0","unresolved":false,"context_lines":[{"line_number":15,"context_line":".. code-block:: bash"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    # local.conf"},{"line_number":18,"context_line":"    enable_plugin keystone $KEYSTONE_REPO"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"K2K Identity Provider"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9abb7d3a_d4ae6ee6","line":18,"range":{"start_line":18,"start_character":27,"end_line":18,"end_character":41},"in_reply_to":"9abb7d3a_f14584b3","updated":"2016-06-02 16:55:28.000000000","message":"i think that i read somewhere that in the gates $KEYSTONE_REPO is ignored and is uploaded from some cache... maybe i misunderstood something. OK, lets leave this as a note to check in the future.","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"26421391cd3c200608e5b335d7bda4ba41955bce","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    enable_service federation-sp"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Then, set the following variables so that DevStack can configure shibboleth"},{"line_number":63,"context_line":"and register the Identity Provider (sample values provided for K2K):"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9abb7d3a_7000a534","line":62,"updated":"2016-06-01 21:11:50.000000000","message":"nit: Shibboleth*","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"26421391cd3c200608e5b335d7bda4ba41955bce","unresolved":false,"context_lines":[{"line_number":75,"context_line":"Keystone 2 Keystone"},{"line_number":76,"context_line":"-------------------"},{"line_number":77,"context_line":"For testing K2K, one DevStack can be set up as the Identity Provider and"},{"line_number":78,"context_line":"another one as the Service Provider. K2K-specific Tempest tests can then be"},{"line_number":79,"context_line":"run on the Identity Provider."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatively, one DevStack can also perform both functions."}],"source_content_type":"text/x-rst","patch_set":9,"id":"9abb7d3a_908c29db","line":78,"updated":"2016-06-01 21:11:50.000000000","message":"Are the tempest tests smart enough to figure out where the service provider and identity provider are? This isn\u0027t something the user has to tell tempest is it?","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"1dec2cf68bb5909205a380ac8b80ade034bfd4d9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"Keystone 2 Keystone"},{"line_number":76,"context_line":"-------------------"},{"line_number":77,"context_line":"For testing K2K, one DevStack can be set up as the Identity Provider and"},{"line_number":78,"context_line":"another one as the Service Provider. K2K-specific Tempest tests can then be"},{"line_number":79,"context_line":"run on the Identity Provider."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatively, one DevStack can also perform both functions."}],"source_content_type":"text/x-rst","patch_set":9,"id":"9abb7d3a_ab4f4032","line":78,"in_reply_to":"9abb7d3a_908c29db","updated":"2016-06-01 21:25:32.000000000","message":"Yes, the service provider list is present in the catalog and token information. The identity provider will be the one tempest is set up against as usually.","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e3c20807911e50e7521788704c00cb832b64de9d","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This DevStack plugin automates the process of setting up a federated Keystone,"},{"line_number":6,"context_line":"either as an Identity Provider or as a Service Provider. These functions can"},{"line_number":7,"context_line":"either be enabled on the same DevStack or on separate ones depending on use"},{"line_number":8,"context_line":"case."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Setup"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_0097fd90","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":38},"updated":"2016-06-06 15:15:42.000000000","message":"Devstack","commit_id":"f51c2da5e6c5b695d4b7e5ba6f19a5ec57a311a1"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e3c20807911e50e7521788704c00cb832b64de9d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    enable_plugin keystone $KEYSTONE_REPO"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"K2K Identity Provider"},{"line_number":22,"context_line":"---------------------"},{"line_number":23,"context_line":"To set up Keystone as an Identity Provider enable the `k2k-idp` service by"},{"line_number":24,"context_line":"adding the following line to `local.conf`:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_20b7993a","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":3},"updated":"2016-06-06 15:15:42.000000000","message":"Keystone-to-keystone (K2K) Identity Provider","commit_id":"f51c2da5e6c5b695d4b7e5ba6f19a5ec57a311a1"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e3c20807911e50e7521788704c00cb832b64de9d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    enable_service k2k-idp"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"After the setup is done, register the federated Keystone service providers"},{"line_number":34,"context_line":"through the command line:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. code-block:: bash"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_208e7978","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":25},"updated":"2016-06-06 15:15:42.000000000","message":"is this not going to be automated?","commit_id":"f51c2da5e6c5b695d4b7e5ba6f19a5ec57a311a1"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"e67a06196ab0147c8326e97736026f878c9bec53","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    enable_service k2k-idp"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"After the setup is done, register the federated Keystone service providers"},{"line_number":34,"context_line":"through the command line:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. code-block:: bash"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_551c1e13","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":25},"in_reply_to":"7aa08908_208e7978","updated":"2016-06-06 17:45:34.000000000","message":"It can be automated, but the IdP doesn\u0027t need to know about the SP before hand, so leaving it as a step to be done after stack.sh leaves some room for flexibility.","commit_id":"f51c2da5e6c5b695d4b7e5ba6f19a5ec57a311a1"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e3c20807911e50e7521788704c00cb832b64de9d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    enable_service federation-sp"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Then, set the following variables so that DevStack can configure shibboleth"},{"line_number":63,"context_line":"and register the Identity Provider (sample values provided for K2K):"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":".. code-block:: bash"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_20bcb904","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":68},"updated":"2016-06-06 15:15:42.000000000","message":"again, not automated?","commit_id":"f51c2da5e6c5b695d4b7e5ba6f19a5ec57a311a1"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"e67a06196ab0147c8326e97736026f878c9bec53","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    enable_service federation-sp"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Then, set the following variables so that DevStack can configure shibboleth"},{"line_number":63,"context_line":"and register the Identity Provider (sample values provided for K2K):"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":".. code-block:: bash"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_75967a4d","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":68},"in_reply_to":"7aa08908_20bcb904","updated":"2016-06-06 17:45:34.000000000","message":"These variables are set in local.conf prior to running stack.sh. I will update the Readme to better reflect that.","commit_id":"f51c2da5e6c5b695d4b7e5ba6f19a5ec57a311a1"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e3c20807911e50e7521788704c00cb832b64de9d","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Testing"},{"line_number":75,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":76,"context_line":"Keystone 2 Keystone"},{"line_number":77,"context_line":"-------------------"},{"line_number":78,"context_line":"For testing K2K, one DevStack can be set up as the Identity Provider and"},{"line_number":79,"context_line":"another one as the Service Provider. K2K-specific Tempest tests can then be"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_e048f12f","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":19},"updated":"2016-06-06 15:15:42.000000000","message":"Keystone-to-keystone","commit_id":"f51c2da5e6c5b695d4b7e5ba6f19a5ec57a311a1"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e3c20807911e50e7521788704c00cb832b64de9d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"another one as the Service Provider. K2K-specific Tempest tests can then be"},{"line_number":80,"context_line":"run on the Identity Provider."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Alternatively, one DevStack can also perform both functions."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_a0e26901","line":82,"range":{"start_line":82,"start_character":15,"end_line":82,"end_character":60},"updated":"2016-06-06 15:15:42.000000000","message":"a single Devstack setup can also perform both functions.","commit_id":"f51c2da5e6c5b695d4b7e5ba6f19a5ec57a311a1"}],"devstack/files/apache_shib.txt":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e3c20807911e50e7521788704c00cb832b64de9d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    SetHandler shib"},{"line_number":3,"context_line":"\u003c/Location\u003e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\u003cLocationMatch /v3/OS-FEDERATION/identity_providers/.*?/protocols/saml2/auth\u003e"},{"line_number":6,"context_line":"    ShibRequestSetting requireSession 1"},{"line_number":7,"context_line":"    AuthType shibboleth"},{"line_number":8,"context_line":"    ShibExportAssertion Off"}],"source_content_type":"text/plain","patch_set":10,"id":"7aa08908_e0a0f192","line":5,"range":{"start_line":5,"start_character":52,"end_line":5,"end_character":55},"updated":"2016-06-06 15:15:42.000000000","message":"this wild card is not safe [1], think would be good to add a comment stating that (some ppl might copy this configs to their own setups)\n\n[1] http://lists.openstack.org/pipermail/openstack-dev/2015-April/061919.html","commit_id":"f51c2da5e6c5b695d4b7e5ba6f19a5ec57a311a1"}],"devstack/files/attribute-map.xml":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"29b191b714d08e3820d5a9be3a3d502b2d4d28da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9abb7d3a_affea335","updated":"2016-05-31 05:56:01.000000000","message":"clean up the white space issues here,\n\nalso, do you want to delete the commented out attributes that are going unused?","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"a629df1065859ee76f85d68980e53be7a666ec23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9abb7d3a_c8e57c09","in_reply_to":"9abb7d3a_affea335","updated":"2016-06-01 16:06:17.000000000","message":"Done","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e3c20807911e50e7521788704c00cb832b64de9d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    usually want to uncomment or map the names for both SAML versions as a unit."},{"line_number":8,"context_line":"    --\u003e"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    \u003cAttribute id\u003d\"openstack_project\" name\u003d\"openstack_project\"/\u003e"},{"line_number":11,"context_line":"    \u003cAttribute id\u003d\"openstack_roles\" name\u003d\"openstack_roles\"/\u003e"},{"line_number":12,"context_line":"    \u003cAttribute id\u003d\"openstack_user\" name\u003d\"openstack_user\"/\u003e"},{"line_number":13,"context_line":""}],"source_content_type":"application/xml","patch_set":10,"id":"7aa08908_80792dff","line":10,"updated":"2016-06-06 15:15:42.000000000","message":"suggest add the new attributes: https://github.com/openstack/keystone/blob/master/keystone/federation/idp.py#L168-L191\n\nopenstack-project-domain\nopenstack-user-domain","commit_id":"f51c2da5e6c5b695d4b7e5ba6f19a5ec57a311a1"}],"devstack/files/mapping.txt":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"29b191b714d08e3820d5a9be3a3d502b2d4d28da","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    {"},{"line_number":3,"context_line":"        \"local\": ["},{"line_number":4,"context_line":"            {"},{"line_number":5,"context_line":"                \"user\": {"},{"line_number":6,"context_line":"                    \"name\": \"federated_user\","},{"line_number":7,"context_line":"                    \"domain\": {"},{"line_number":8,"context_line":"                        \"id\": \"default\""},{"line_number":9,"context_line":"                    }"},{"line_number":10,"context_line":"                },"},{"line_number":11,"context_line":"                \"group\": {"},{"line_number":12,"context_line":"                    \"name\": \"federated_group\","},{"line_number":13,"context_line":"                    \"domain\": {"}],"source_content_type":"text/plain","patch_set":8,"id":"9abb7d3a_efe1cb9b","line":10,"range":{"start_line":5,"start_character":16,"end_line":10,"end_character":18},"updated":"2016-05-31 05:56:01.000000000","message":"is this block needed?","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"a629df1065859ee76f85d68980e53be7a666ec23","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    {"},{"line_number":3,"context_line":"        \"local\": ["},{"line_number":4,"context_line":"            {"},{"line_number":5,"context_line":"                \"user\": {"},{"line_number":6,"context_line":"                    \"name\": \"federated_user\","},{"line_number":7,"context_line":"                    \"domain\": {"},{"line_number":8,"context_line":"                        \"id\": \"default\""},{"line_number":9,"context_line":"                    }"},{"line_number":10,"context_line":"                },"},{"line_number":11,"context_line":"                \"group\": {"},{"line_number":12,"context_line":"                    \"name\": \"federated_group\","},{"line_number":13,"context_line":"                    \"domain\": {"}],"source_content_type":"text/plain","patch_set":8,"id":"9abb7d3a_2676f93d","line":10,"range":{"start_line":5,"start_character":16,"end_line":10,"end_character":18},"in_reply_to":"9abb7d3a_efe1cb9b","updated":"2016-06-01 16:06:17.000000000","message":"I\u0027m not entirely sure. Will do some testing.","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"ede47e0f651402f6d8df8e22f4b9518cac2535ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9abb7d3a_eeff63a8","side":"PARENT","updated":"2016-06-02 16:27:55.000000000","message":"it should be mapping.json, not mapping.txt","commit_id":"a991d9edfeac14bc2c565a779dde6e3c51158ede"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"a60d5d7c23107d0d19155c51ac3913137f0d412d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9abb7d3a_f11c64c3","side":"PARENT","in_reply_to":"9abb7d3a_eeff63a8","updated":"2016-06-02 16:46:48.000000000","message":"Right.","commit_id":"a991d9edfeac14bc2c565a779dde6e3c51158ede"}],"devstack/files/shibboleth2.xml":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"29b191b714d08e3820d5a9be3a3d502b2d4d28da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9abb7d3a_cfdcc7e6","updated":"2016-05-31 05:56:01.000000000","message":"clean up the white spaces here","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"a629df1065859ee76f85d68980e53be7a666ec23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9abb7d3a_c3c72494","in_reply_to":"9abb7d3a_cfdcc7e6","updated":"2016-06-01 16:06:17.000000000","message":"Done.","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"54b593e0d77a13051bf19e7dc470a7a522bb70d0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    --\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    \u003c!-- The ApplicationDefaults element is where most of Shibboleth\u0027s SAML bits are defined. --\u003e"},{"line_number":18,"context_line":"    \u003cApplicationDefaults entityID\u003d\"https://sp.example.org/shibboleth\" REMOTE_USER\u003d\"eppn persistent-id targeted-id\"\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"        \u003c!--"},{"line_number":21,"context_line":"        Controls session lifetimes, address checks, cookie handling, and the protocol handlers."}],"source_content_type":"application/xml","patch_set":9,"id":"9abb7d3a_31c0ace0","line":18,"range":{"start_line":18,"start_character":35,"end_line":18,"end_character":68},"updated":"2016-06-02 16:55:28.000000000","message":"this should probably be configurable","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"ede47e0f651402f6d8df8e22f4b9518cac2535ac","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    --\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    \u003c!-- The ApplicationDefaults element is where most of Shibboleth\u0027s SAML bits are defined. --\u003e"},{"line_number":18,"context_line":"    \u003cApplicationDefaults entityID\u003d\"https://sp.example.org/shibboleth\" REMOTE_USER\u003d\"eppn persistent-id targeted-id\"\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"        \u003c!--"},{"line_number":21,"context_line":"        Controls session lifetimes, address checks, cookie handling, and the protocol handlers."}],"source_content_type":"application/xml","patch_set":9,"id":"9abb7d3a_6ee1b3fe","line":18,"range":{"start_line":18,"start_character":70,"end_line":18,"end_character":114},"updated":"2016-06-02 16:27:55.000000000","message":"ugh. Will it work with this?","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"a60d5d7c23107d0d19155c51ac3913137f0d412d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    --\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    \u003c!-- The ApplicationDefaults element is where most of Shibboleth\u0027s SAML bits are defined. --\u003e"},{"line_number":18,"context_line":"    \u003cApplicationDefaults entityID\u003d\"https://sp.example.org/shibboleth\" REMOTE_USER\u003d\"eppn persistent-id targeted-id\"\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"        \u003c!--"},{"line_number":21,"context_line":"        Controls session lifetimes, address checks, cookie handling, and the protocol handlers."}],"source_content_type":"application/xml","patch_set":9,"id":"9abb7d3a_71b874e6","line":18,"range":{"start_line":18,"start_character":70,"end_line":18,"end_character":114},"in_reply_to":"9abb7d3a_6ee1b3fe","updated":"2016-06-02 16:46:48.000000000","message":"It has worked for me. I just pulled it from a working test setup. Please feel free to change it if you\u0027re more familiar with shibboleth configuration. :)","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"}],"devstack/plugin.sh":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"29b191b714d08e3820d5a9be3a3d502b2d4d28da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9abb7d3a_cf4047a8","updated":"2016-05-31 05:56:01.000000000","message":"you could add this to the `bashate` style checker here: https://github.com/openstack/keystone/blob/master/tox.ini#L59\n\nif you are inclined, not a big deal","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"a629df1065859ee76f85d68980e53be7a666ec23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9abb7d3a_7d409507","in_reply_to":"9abb7d3a_cf4047a8","updated":"2016-06-01 16:06:17.000000000","message":"Done.","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"29b191b714d08e3820d5a9be3a3d502b2d4d28da","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    iniset $KEYSTONE_CONF saml certfile \"/etc/keystone/ssl/certs/ca.pem\""},{"line_number":30,"context_line":"    iniset $KEYSTONE_CONF saml keyfile \"/etc/keystone/ssl/private/cakey.pem\""},{"line_number":31,"context_line":"    iniset $KEYSTONE_CONF saml idp_entity_id \"http://$HOST_IP:5000/v3/OS-FEDERATION/saml2/idp\""},{"line_number":32,"context_line":"    iniset $KEYSTONE_CONF saml idp_sso_endpoint \"http://$HOST_IP:5000/v3/OS-FEDERATION/saml2/sso\""},{"line_number":33,"context_line":"    iniset $KEYSTONE_CONF saml idp_metadata_path \"/etc/keystone/keystone_idp_metadata.xml\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    keystone-manage pki_setup"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9abb7d3a_6f103ba9","line":32,"range":{"start_line":32,"start_character":31,"end_line":32,"end_character":47},"updated":"2016-05-31 05:56:01.000000000","message":"is the SSO endpoint used?","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"a629df1065859ee76f85d68980e53be7a666ec23","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    iniset $KEYSTONE_CONF saml certfile \"/etc/keystone/ssl/certs/ca.pem\""},{"line_number":30,"context_line":"    iniset $KEYSTONE_CONF saml keyfile \"/etc/keystone/ssl/private/cakey.pem\""},{"line_number":31,"context_line":"    iniset $KEYSTONE_CONF saml idp_entity_id \"http://$HOST_IP:5000/v3/OS-FEDERATION/saml2/idp\""},{"line_number":32,"context_line":"    iniset $KEYSTONE_CONF saml idp_sso_endpoint \"http://$HOST_IP:5000/v3/OS-FEDERATION/saml2/sso\""},{"line_number":33,"context_line":"    iniset $KEYSTONE_CONF saml idp_metadata_path \"/etc/keystone/keystone_idp_metadata.xml\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    keystone-manage pki_setup"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9abb7d3a_7dc9b5ab","line":32,"range":{"start_line":32,"start_character":31,"end_line":32,"end_character":47},"in_reply_to":"9abb7d3a_6f103ba9","updated":"2016-06-01 16:06:17.000000000","message":"Not in the K2K setup.","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"29b191b714d08e3820d5a9be3a3d502b2d4d28da","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    if is_ubuntu; then"},{"line_number":43,"context_line":"        install_package libapache2-mod-shib2"},{"line_number":44,"context_line":"    elif is_fedora; then"},{"line_number":45,"context_line":"        sudo dnf config-manager --add-repo \\"},{"line_number":46,"context_line":"            http://download.opensuse.org/repositories/security://shibboleth/CentOS_7/security:shibboleth.repo"},{"line_number":47,"context_line":"        install_package mod_ssl shibboleth"},{"line_number":48,"context_line":"    fi"},{"line_number":49,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9abb7d3a_ef4a6bab","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":109},"updated":"2016-05-31 05:56:01.000000000","message":"eww","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"a629df1065859ee76f85d68980e53be7a666ec23","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    if is_ubuntu; then"},{"line_number":43,"context_line":"        install_package libapache2-mod-shib2"},{"line_number":44,"context_line":"    elif is_fedora; then"},{"line_number":45,"context_line":"        sudo dnf config-manager --add-repo \\"},{"line_number":46,"context_line":"            http://download.opensuse.org/repositories/security://shibboleth/CentOS_7/security:shibboleth.repo"},{"line_number":47,"context_line":"        install_package mod_ssl shibboleth"},{"line_number":48,"context_line":"    fi"},{"line_number":49,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9abb7d3a_7214444c","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":109},"in_reply_to":"9abb7d3a_ef4a6bab","updated":"2016-06-01 16:06:17.000000000","message":"I know","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"29b191b714d08e3820d5a9be3a3d502b2d4d28da","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    local federated_user\u003d$(get_or_create_user federated_user)"},{"line_number":82,"context_line":"    local federated_project\u003d$(get_or_create_project federated_project)"},{"line_number":83,"context_line":"    local federated_group\u003d$(get_or_create_group federated_group default)"},{"line_number":84,"context_line":"    local member_role\u003d$(get_or_create_role _member_)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    openstack role add --project $federated_project --user $federated_user $member_role"},{"line_number":87,"context_line":"    openstack role add --project $federated_project --group $federated_group $member_role"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9abb7d3a_ef738b13","line":84,"range":{"start_line":84,"start_character":43,"end_line":84,"end_character":51},"updated":"2016-05-31 05:56:01.000000000","message":"use \"member\" here, not \"_member_\"","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"a629df1065859ee76f85d68980e53be7a666ec23","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    local federated_user\u003d$(get_or_create_user federated_user)"},{"line_number":82,"context_line":"    local federated_project\u003d$(get_or_create_project federated_project)"},{"line_number":83,"context_line":"    local federated_group\u003d$(get_or_create_group federated_group default)"},{"line_number":84,"context_line":"    local member_role\u003d$(get_or_create_role _member_)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    openstack role add --project $federated_project --user $federated_user $member_role"},{"line_number":87,"context_line":"    openstack role add --project $federated_project --group $federated_group $member_role"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9abb7d3a_78b3830a","line":84,"range":{"start_line":84,"start_character":43,"end_line":84,"end_character":51},"in_reply_to":"9abb7d3a_ef738b13","updated":"2016-06-01 16:06:17.000000000","message":"Done.","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"29b191b714d08e3820d5a9be3a3d502b2d4d28da","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    local federated_group\u003d$(get_or_create_group federated_group default)"},{"line_number":84,"context_line":"    local member_role\u003d$(get_or_create_role _member_)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    openstack role add --project $federated_project --user $federated_user $member_role"},{"line_number":87,"context_line":"    openstack role add --project $federated_project --group $federated_group $member_role"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    openstack --os-identity-api-version 3 identity provider create \\"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9abb7d3a_2f647347","line":86,"range":{"start_line":86,"start_character":4,"end_line":86,"end_character":87},"updated":"2016-05-31 05:56:01.000000000","message":"i think you want to add the user to the group instead","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"a629df1065859ee76f85d68980e53be7a666ec23","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    local federated_group\u003d$(get_or_create_group federated_group default)"},{"line_number":84,"context_line":"    local member_role\u003d$(get_or_create_role _member_)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    openstack role add --project $federated_project --user $federated_user $member_role"},{"line_number":87,"context_line":"    openstack role add --project $federated_project --group $federated_group $member_role"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    openstack --os-identity-api-version 3 identity provider create \\"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9abb7d3a_f8c77361","line":86,"range":{"start_line":86,"start_character":4,"end_line":86,"end_character":87},"in_reply_to":"9abb7d3a_2f647347","updated":"2016-06-01 16:06:17.000000000","message":"Right, done.","commit_id":"f888c8fe0dc7b831357d0b8be8b43a0a3ff18861"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"407bb85608851845cbf055a6507fe8c5fc15aaf1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"function configure_sp {"},{"line_number":52,"context_line":"    if is_ubuntu; then"},{"line_number":53,"context_line":"        sudo shib-keygen -f"},{"line_number":54,"context_line":"    elif is_fedora; then"},{"line_number":55,"context_line":"        sudo /etc/shibboleth/keygen.sh -f"},{"line_number":56,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"9abb7d3a_74e182fe","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":27},"updated":"2016-06-02 17:05:10.000000000","message":"this is actually not necessary","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"407bb85608851845cbf055a6507fe8c5fc15aaf1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \" -i /etc/shibboleth/shibboleth2.xml"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    iniset $KEYSTONE_CONF auth methods \"external,password,token,oauth1,saml2\""},{"line_number":72,"context_line":"    iniset $KEYSTONE_CONF auth saml2 \"keystone.auth.plugins.mapped.Mapped\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    if is_ubuntu; then"},{"line_number":75,"context_line":"        sudo a2enmod shib2"}],"source_content_type":"text/x-sh","patch_set":9,"id":"9abb7d3a_54b55ece","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":74},"updated":"2016-06-02 17:05:10.000000000","message":"this is not necessary","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"407bb85608851845cbf055a6507fe8c5fc15aaf1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    restart_apache_server"},{"line_number":79,"context_line":"    restart_service shibd"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    local federated_user\u003d$(get_or_create_user federated_user)"},{"line_number":82,"context_line":"    local federated_project\u003d$(get_or_create_project federated_project)"},{"line_number":83,"context_line":"    local federated_group\u003d$(get_or_create_group federated_group default)"},{"line_number":84,"context_line":"    local member_role\u003d$(get_or_create_role member)"}],"source_content_type":"text/x-sh","patch_set":9,"id":"9abb7d3a_d43e6e28","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":61},"updated":"2016-06-02 17:05:10.000000000","message":"i think that the user needs to be ephemeral. I think it\u0027s a more common setup and needs to be tested better.","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"26421391cd3c200608e5b335d7bda4ba41955bce","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"post-config\" ]]; then"},{"line_number":124,"context_line":"    if is_service_enabled k2k-idp; then"},{"line_number":125,"context_line":"        configure_idp"},{"line_number":126,"context_line":"    fi"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    if is_service_enabled federation-sp; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"9abb7d3a_b0520d33","line":125,"updated":"2016-06-01 21:11:50.000000000","message":"Do these have to be separate from the above if statements? If we `install_idp` what\u0027s to stop us from running `configure_idp` in the same if statement?","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"ede47e0f651402f6d8df8e22f4b9518cac2535ac","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"post-config\" ]]; then"},{"line_number":124,"context_line":"    if is_service_enabled k2k-idp; then"},{"line_number":125,"context_line":"        configure_idp"},{"line_number":126,"context_line":"    fi"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    if is_service_enabled federation-sp; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"9abb7d3a_8e98576c","line":125,"in_reply_to":"9abb7d3a_6b93985b","updated":"2016-06-02 16:27:55.000000000","message":"Yep, that\u0027s right.","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"1dec2cf68bb5909205a380ac8b80ade034bfd4d9","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"post-config\" ]]; then"},{"line_number":124,"context_line":"    if is_service_enabled k2k-idp; then"},{"line_number":125,"context_line":"        configure_idp"},{"line_number":126,"context_line":"    fi"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    if is_service_enabled federation-sp; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"9abb7d3a_6b93985b","line":125,"in_reply_to":"9abb7d3a_b0520d33","updated":"2016-06-01 21:25:32.000000000","message":"They are called by DevStack in separate phases. The install phase installs the dependencies. In the post-config phase all services are installed and running, so we can query and configure Keystone.\n\nIt\u0027s DevStack that is calling the plugin, not us manually.","commit_id":"0b465f5e6d7b9252199a1778b9647d346c7400e0"}]}