)]}'
{"keystone/contrib/stats/core.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"b28f5e731834496d89705609e721c061f001d5b3","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        return super(StatsMiddleware, self).__init__(*args, **kwargs)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _resolve_api(self, host):"},{"line_number":128,"context_line":"        if self.re_admin.search(host):"},{"line_number":129,"context_line":"            return \u0027admin\u0027"},{"line_number":130,"context_line":"        elif self.re_public.search(host):"},{"line_number":131,"context_line":"            return \u0027public\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2FyjU%3D","line":128,"updated":"2013-06-10 16:50:17.000000000","message":"from the look of it you don\u0027t need a regexp but just a :\n\nhost.endswsith(\u0027:%s\u0027 % (CONF.admin_port))\n\nstring comparaison may be more CPU friendly for such used module (if installed in the pipeline) compared to a regexp.","commit_id":"204c1d62c128b99065bba7295ea1974c61c4dd17"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"b28f5e731834496d89705609e721c061f001d5b3","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def _resolve_api(self, host):"},{"line_number":128,"context_line":"        if self.re_admin.search(host):"},{"line_number":129,"context_line":"            return \u0027admin\u0027"},{"line_number":130,"context_line":"        elif self.re_public.search(host):"},{"line_number":131,"context_line":"            return \u0027public\u0027"},{"line_number":132,"context_line":"        else:"},{"line_number":133,"context_line":"            # NOTE(dolph): I don\u0027t think this is actually reachable, but hey"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2FyjI%3D","line":130,"updated":"2013-06-10 16:50:17.000000000","message":"same comment as before but with :\n\nhost.endswsith(\u0027:%s\u0027 % (CONF.public_port))","commit_id":"204c1d62c128b99065bba7295ea1974c61c4dd17"}],"tests/test_contrib_stats_core.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"225e26809c0c5971c218923ccddd2e80894fb7aa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                         self.stats_middleware._resolve_api(host_admin))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_public_request(self):"},{"line_number":37,"context_line":"        host_public \u003d \"127.0.0.1:%s\" % CONF.public_port"},{"line_number":38,"context_line":"        self.assertEqual(\"public\","},{"line_number":39,"context_line":"                         self.stats_middleware._resolve_api(host_public))"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPX%2F%2FwVk%3D","line":37,"updated":"2013-06-11 10:29:18.000000000","message":"nitpick: i would have used another ip to show a public req than 127.0.0.1","commit_id":"8b73171b9e321041f73317b3903b853ead6c8795"},{"author":{"_account_id":6282,"name":"Wu Wenxiang","email":"wu.wenxiang@algoblu.com","username":"wu-wenxiang"},"change_message_id":"3ad27ecb7b313bcbe6f073c20bc6a4bc965ac960","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                         self.stats_middleware._resolve_api(host_admin))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_public_request(self):"},{"line_number":37,"context_line":"        host_public \u003d \"127.0.0.1:%s\" % CONF.public_port"},{"line_number":38,"context_line":"        self.assertEqual(\"public\","},{"line_number":39,"context_line":"                         self.stats_middleware._resolve_api(host_public))"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPX%2F%2FvMY%3D","line":37,"in_reply_to":"AAAAPX%2F%2FwVk%3D","updated":"2013-06-11 17:30:39.000000000","message":"I think public ip addr would not affect this test case.","commit_id":"8b73171b9e321041f73317b3903b853ead6c8795"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"17920eda2fd676e7af64dfc41f399364b798ecae","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        host_public \u003d \"127.0.0.1:%s\" % CONF.public_port"},{"line_number":43,"context_line":"        host_other \u003d host_public + \"1\""},{"line_number":44,"context_line":"        self.assertEqual(host_other,"},{"line_number":45,"context_line":"                         self.stats_middleware._resolve_api(host_other))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPX%2F%2Fv98%3D","line":45,"updated":"2013-06-11 13:09:02.000000000","message":"Should we be making sure this is displaying a warning here? Or doesn\u0027t that matter since we can assume the warning is logged once the host is returned?","commit_id":"8b73171b9e321041f73317b3903b853ead6c8795"},{"author":{"_account_id":6282,"name":"Wu Wenxiang","email":"wu.wenxiang@algoblu.com","username":"wu-wenxiang"},"change_message_id":"3ad27ecb7b313bcbe6f073c20bc6a4bc965ac960","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        host_public \u003d \"127.0.0.1:%s\" % CONF.public_port"},{"line_number":43,"context_line":"        host_other \u003d host_public + \"1\""},{"line_number":44,"context_line":"        self.assertEqual(host_other,"},{"line_number":45,"context_line":"                         self.stats_middleware._resolve_api(host_other))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPX%2F%2FvMI%3D","line":45,"in_reply_to":"AAAAPX%2F%2Fv98%3D","updated":"2013-06-11 17:30:39.000000000","message":"Bug 1189118, I prefer simply removing this warning info here.","commit_id":"8b73171b9e321041f73317b3903b853ead6c8795"}]}