)]}'
{"keystone/common/sql/core.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"6add2dd854544c206f24a553350167783d88e123","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    # If we satisfied all the filters, set an upper limit if supplied"},{"line_number":373,"context_line":"    if hints.limit:"},{"line_number":374,"context_line":"        original_len \u003d query.count()"},{"line_number":375,"context_line":"        query \u003d query.limit(hints.limit[\u0027limit\u0027])"},{"line_number":376,"context_line":"        limited_len \u003d query.count()"},{"line_number":377,"context_line":"        if limited_len \u003c original_len:"},{"line_number":378,"context_line":"            hints.limit[\u0027truncated\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_8e2b1794","line":375,"range":{"start_line":375,"start_character":8,"end_line":375,"end_character":13},"updated":"2016-06-21 04:01:36.000000000","message":"consider changing this variable name since it has the same name as the original query, and I thought original_len and limited_len were the same result for a second :)","commit_id":"e3f32793ebc515ba5b7499d6377794119292271c"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"a8268c4d13c249f97e8dae3ec203eb6bd6b93c5e","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    # If we satisfied all the filters, set an upper limit if supplied"},{"line_number":373,"context_line":"    if hints.limit:"},{"line_number":374,"context_line":"        original_len \u003d query.count()"},{"line_number":375,"context_line":"        query \u003d query.limit(hints.limit[\u0027limit\u0027])"},{"line_number":376,"context_line":"        limited_len \u003d query.count()"},{"line_number":377,"context_line":"        if limited_len \u003c original_len:"},{"line_number":378,"context_line":"            hints.limit[\u0027truncated\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_bb03f375","line":375,"range":{"start_line":375,"start_character":8,"end_line":375,"end_character":13},"in_reply_to":"5a9d85d2_8e2b1794","updated":"2016-06-21 17:48:47.000000000","message":"Done","commit_id":"e3f32793ebc515ba5b7499d6377794119292271c"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"1c6bba03f93d76a6c13ecc7a4bfe0dc12a2b6665","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    # If we satisfied all the filters, set an upper limit if supplied"},{"line_number":373,"context_line":"    if hints.limit:"},{"line_number":374,"context_line":"        original_len \u003d query.count()"},{"line_number":375,"context_line":"        limit_query \u003d query.limit(hints.limit[\u0027limit\u0027])"},{"line_number":376,"context_line":"        if limit_query.count() \u003c original_len:"},{"line_number":377,"context_line":"            hints.limit[\u0027truncated\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_9b96e292","line":374,"range":{"start_line":374,"start_character":8,"end_line":374,"end_character":20},"updated":"2016-06-22 01:12:17.000000000","message":"this should be the filtered len as filter has already been applied at this point. Anyway, I am also good with this.","commit_id":"6a9a9f002f44c15d40cf890eefd03a4ab6172b0b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"974206ff9a941638d0ebe4dd84803a5f48f22b4a","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        limit_query \u003d query.limit(hints.limit[\u0027limit\u0027])"},{"line_number":376,"context_line":"        if limit_query.count() \u003c original_len:"},{"line_number":377,"context_line":"            hints.limit[\u0027truncated\u0027] \u003d True"},{"line_number":378,"context_line":"            query \u003d limit_query"},{"line_number":379,"context_line":"    return query"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_380c1794","line":378,"range":{"start_line":378,"start_character":12,"end_line":378,"end_character":31},"updated":"2016-06-21 23:18:02.000000000","message":"could do `return limit_query` here,\n\nnot sure which convention is more appropriate","commit_id":"6a9a9f002f44c15d40cf890eefd03a4ab6172b0b"}],"keystone/tests/unit/test_v3_catalog.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"6add2dd854544c206f24a553350167783d88e123","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def test_filter_list_services_by_name_with_list_limit(self):"},{"line_number":365,"context_line":"        \"\"\"Call ``GET /services?name\u003d\u003csome name\u003e``.\"\"\""},{"line_number":366,"context_line":"        self.config_fixture.config(list_limit\u003d2)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        self.test_filter_list_services_by_name()"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_390a2f22","line":366,"range":{"start_line":366,"start_character":35,"end_line":366,"end_character":47},"updated":"2016-06-21 04:01:36.000000000","message":"you could use 1 here","commit_id":"e3f32793ebc515ba5b7499d6377794119292271c"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"a8268c4d13c249f97e8dae3ec203eb6bd6b93c5e","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def test_filter_list_services_by_name_with_list_limit(self):"},{"line_number":365,"context_line":"        \"\"\"Call ``GET /services?name\u003d\u003csome name\u003e``.\"\"\""},{"line_number":366,"context_line":"        self.config_fixture.config(list_limit\u003d2)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        self.test_filter_list_services_by_name()"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_fbfd7b6f","line":366,"range":{"start_line":366,"start_character":35,"end_line":366,"end_character":47},"in_reply_to":"5a9d85d2_390a2f22","updated":"2016-06-21 17:48:47.000000000","message":"Done","commit_id":"e3f32793ebc515ba5b7499d6377794119292271c"}]}