)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"2db1cfd7a3913c986c1d9cf14aa659278aa47f0e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch allows the password column to be null which is the expected"},{"line_number":10,"context_line":"behavior."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Note: We do have tests in place that should have caught this. However,"},{"line_number":13,"context_line":"the SQL model for Password did not explicitly set the nullable column"},{"line_number":14,"context_line":"attribute, so it defaulted to true, even though the migration set it to"},{"line_number":15,"context_line":"false."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1595819"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_afb92ace","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":6},"updated":"2016-06-24 19:26:22.000000000","message":"Nice, I also added details on why it was passing on master as a comment in the bug report : https://bugs.launchpad.net/keystone/+bug/1595819","commit_id":"e04c5614377a7209bde7904a37ac80e6d98bc620"}],"keystone/identity/backends/sql_model.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"7de32610237743d0049501d2fd296e45369a24e8","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    id \u003d sql.Column(sql.Integer, primary_key\u003dTrue)"},{"line_number":155,"context_line":"    local_user_id \u003d sql.Column(sql.Integer, sql.ForeignKey(\u0027local_user.id\u0027,"},{"line_number":156,"context_line":"                               ondelete\u003d\u0027CASCADE\u0027))"},{"line_number":157,"context_line":"    password \u003d sql.Column(sql.String(128), nullable\u003dTrue)"},{"line_number":158,"context_line":"    # created_at default set here to safe guard in case it gets missed"},{"line_number":159,"context_line":"    created_at \u003d sql.Column(sql.DateTime, nullable\u003dFalse,"},{"line_number":160,"context_line":"                            default\u003ddatetime.datetime.utcnow)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_74c275ea","line":157,"range":{"start_line":157,"start_character":41,"end_line":157,"end_character":56},"updated":"2016-06-24 19:10:01.000000000","message":"Nullable is true by default, right ? It\u0027s just about setting it explicitly","commit_id":"9b49e92597fef3fa80baca79577b7db70aaccbc2"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"f53d24770791a6c82627ea8c3f495c6a6e1a2862","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    id \u003d sql.Column(sql.Integer, primary_key\u003dTrue)"},{"line_number":155,"context_line":"    local_user_id \u003d sql.Column(sql.Integer, sql.ForeignKey(\u0027local_user.id\u0027,"},{"line_number":156,"context_line":"                               ondelete\u003d\u0027CASCADE\u0027))"},{"line_number":157,"context_line":"    password \u003d sql.Column(sql.String(128), nullable\u003dTrue)"},{"line_number":158,"context_line":"    # created_at default set here to safe guard in case it gets missed"},{"line_number":159,"context_line":"    created_at \u003d sql.Column(sql.DateTime, nullable\u003dFalse,"},{"line_number":160,"context_line":"                            default\u003ddatetime.datetime.utcnow)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_8f88ae72","line":157,"range":{"start_line":157,"start_character":41,"end_line":157,"end_character":56},"in_reply_to":"3aaa91ec_74c275ea","updated":"2016-06-24 19:16:21.000000000","message":"Yes, this wasn\u0027t set, so it was nullable by default.","commit_id":"9b49e92597fef3fa80baca79577b7db70aaccbc2"}],"keystone/tests/unit/test_backend_sql.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"7de32610237743d0049501d2fd296e45369a24e8","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        with sql.session_for_read() as session:"},{"line_number":235,"context_line":"            new_user_ref \u003d self.identity_api._get_user(session,"},{"line_number":236,"context_line":"                                                       new_user_dict[\u0027id\u0027])"},{"line_number":237,"context_line":"            self.assertIsNone(new_user_ref.password)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def test_update_user_with_null_password(self):"},{"line_number":240,"context_line":"        user_dict \u003d unit.new_user_ref("}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_7469d5f8","line":237,"range":{"start_line":237,"start_character":17,"end_line":237,"end_character":29},"updated":"2016-06-24 19:10:01.000000000","message":"Does this make any difference on the tests or it is just about making things more correct ?","commit_id":"9b49e92597fef3fa80baca79577b7db70aaccbc2"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"f53d24770791a6c82627ea8c3f495c6a6e1a2862","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        with sql.session_for_read() as session:"},{"line_number":235,"context_line":"            new_user_ref \u003d self.identity_api._get_user(session,"},{"line_number":236,"context_line":"                                                       new_user_dict[\u0027id\u0027])"},{"line_number":237,"context_line":"            self.assertIsNone(new_user_ref.password)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def test_update_user_with_null_password(self):"},{"line_number":240,"context_line":"        user_dict \u003d unit.new_user_ref("}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_6f90e295","line":237,"range":{"start_line":237,"start_character":17,"end_line":237,"end_character":29},"in_reply_to":"3aaa91ec_7469d5f8","updated":"2016-06-24 19:16:21.000000000","message":"Making things more correct and it also highlights the tests we currently have in place.","commit_id":"9b49e92597fef3fa80baca79577b7db70aaccbc2"}]}