)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2de8df2291ffcf971eada674d21b4c532d3cc493","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The common setup was taken from the BaseLDAPIdentity class as it holds"},{"line_number":10,"context_line":"the setup for almost all of the LDAP tests. The goal is to make the"},{"line_number":11,"context_line":"setup easier to follow. Currently it\u0027s hard to tell when happens during"},{"line_number":12,"context_line":"setup...for instance, why is load_backends() called twice for some test"},{"line_number":13,"context_line":"cases and three times for other?"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_c19246f6","line":11,"updated":"2016-06-27 16:17:20.000000000","message":"what*?","commit_id":"a0ffa50cd01a1a3ae089a6a6d24775d158b64582"}],"keystone/tests/unit/test_backend_ldap.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"ab499db6a442977f6145f3da0746ac06d352df85","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            \u0027N/A: LDAP does not support multiple domains\u0027)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"class LDAPTestSetup(unit.TestCase):"},{"line_number":302,"context_line":"    \"\"\"Common setup for LDAP tests.\"\"\""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_964ff390","line":301,"range":{"start_line":301,"start_character":6,"end_line":301,"end_character":19},"updated":"2016-06-27 12:00:08.000000000","message":"Where else is this being used ? The commit message says it\u0027s common setup but I only see it being used in a single place","commit_id":"987f052c3f1c40700558726b75bc1aceba217408"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"14f5c2fd4b90e5d952758cb2fe7718a6146f09b2","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            \u0027N/A: LDAP does not support multiple domains\u0027)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"class LDAPTestSetup(unit.TestCase):"},{"line_number":302,"context_line":"    \"\"\"Common setup for LDAP tests.\"\"\""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_ecfcab74","line":301,"range":{"start_line":301,"start_character":6,"end_line":301,"end_character":19},"in_reply_to":"3aaa91ec_964ff390","updated":"2016-06-27 12:04:50.000000000","message":"Looks like this and self.ldapdb below are used in the followup patch. This is not clear when first looking at this patch.","commit_id":"987f052c3f1c40700558726b75bc1aceba217408"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"63854b4abba4e67e3919f3306b99c4e93de91bde","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            \u0027N/A: LDAP does not support multiple domains\u0027)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"class LDAPTestSetup(unit.TestCase):"},{"line_number":302,"context_line":"    \"\"\"Common setup for LDAP tests.\"\"\""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_d585ee07","line":301,"range":{"start_line":301,"start_character":6,"end_line":301,"end_character":19},"in_reply_to":"3aaa91ec_ecfcab74","updated":"2016-06-27 12:54:50.000000000","message":"Updating the commit message","commit_id":"987f052c3f1c40700558726b75bc1aceba217408"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"ab499db6a442977f6145f3da0746ac06d352df85","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def setUp(self):"},{"line_number":305,"context_line":"        super(LDAPTestSetup, self).setUp()"},{"line_number":306,"context_line":"        self.ldapdb \u003d self.useFixture(ldapdb.LDAPDatabase())"},{"line_number":307,"context_line":"        self.load_backends()"},{"line_number":308,"context_line":"        self.load_fixtures(default_fixtures)"},{"line_number":309,"context_line":"        self.config_fixture.config(group\u003d\u0027os_inherit\u0027, enabled\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_4cba1f0c","line":306,"range":{"start_line":306,"start_character":8,"end_line":306,"end_character":22},"updated":"2016-06-27 12:00:08.000000000","message":"I don\u0027t see a need to store this as an attribute","commit_id":"987f052c3f1c40700558726b75bc1aceba217408"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"ab499db6a442977f6145f3da0746ac06d352df85","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        self.ldapdb \u003d self.useFixture(ldapdb.LDAPDatabase())"},{"line_number":307,"context_line":"        self.load_backends()"},{"line_number":308,"context_line":"        self.load_fixtures(default_fixtures)"},{"line_number":309,"context_line":"        self.config_fixture.config(group\u003d\u0027os_inherit\u0027, enabled\u003dFalse)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"class BaseLDAPIdentity(IdentityTests, AssignmentTests, ResourceTests):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_cc5baff5","line":309,"range":{"start_line":309,"start_character":8,"end_line":309,"end_character":69},"updated":"2016-06-27 12:00:08.000000000","message":"Where did this come from ?","commit_id":"987f052c3f1c40700558726b75bc1aceba217408"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"63854b4abba4e67e3919f3306b99c4e93de91bde","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        self.ldapdb \u003d self.useFixture(ldapdb.LDAPDatabase())"},{"line_number":307,"context_line":"        self.load_backends()"},{"line_number":308,"context_line":"        self.load_fixtures(default_fixtures)"},{"line_number":309,"context_line":"        self.config_fixture.config(group\u003d\u0027os_inherit\u0027, enabled\u003dFalse)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"class BaseLDAPIdentity(IdentityTests, AssignmentTests, ResourceTests):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_d5ae8e97","line":309,"range":{"start_line":309,"start_character":8,"end_line":309,"end_character":69},"in_reply_to":"3aaa91ec_0cf49785","updated":"2016-06-27 12:54:50.000000000","message":"I don\u0027t think it\u0027s need, but it\u0027s included in the setup of virtually all of the ldap tests. See line 320.","commit_id":"987f052c3f1c40700558726b75bc1aceba217408"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"14f5c2fd4b90e5d952758cb2fe7718a6146f09b2","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        self.ldapdb \u003d self.useFixture(ldapdb.LDAPDatabase())"},{"line_number":307,"context_line":"        self.load_backends()"},{"line_number":308,"context_line":"        self.load_fixtures(default_fixtures)"},{"line_number":309,"context_line":"        self.config_fixture.config(group\u003d\u0027os_inherit\u0027, enabled\u003dFalse)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"class BaseLDAPIdentity(IdentityTests, AssignmentTests, ResourceTests):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_0cf49785","line":309,"range":{"start_line":309,"start_character":8,"end_line":309,"end_character":69},"in_reply_to":"3aaa91ec_cc5baff5","updated":"2016-06-27 12:04:50.000000000","message":"I still don\u0027t see why we need to add this","commit_id":"987f052c3f1c40700558726b75bc1aceba217408"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"2c8f95703a8166b0a07892b0828c00636ad5d6b4","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        self.config_fixture.config(group\u003d\u0027os_inherit\u0027, enabled\u003dFalse)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"class BaseLDAPIdentity(IdentityTests, AssignmentTests, ResourceTests):"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def setUp(self):"},{"line_number":315,"context_line":"        super(BaseLDAPIdentity, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_743c3593","line":312,"updated":"2016-06-30 15:47:33.000000000","message":"I think this class can be treated the same way.","commit_id":"56dd227155c818b28ddf7b58874da56b99d0fcd4"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"4a742faf62464d11f3bd6c65e676d563d72ffb73","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        self.config_fixture.config(group\u003d\u0027os_inherit\u0027, enabled\u003dFalse)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"class BaseLDAPIdentity(IdentityTests, AssignmentTests, ResourceTests):"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def setUp(self):"},{"line_number":315,"context_line":"        super(BaseLDAPIdentity, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_b0b72d85","line":312,"in_reply_to":"3aaa91ec_743c3593","updated":"2016-07-05 14:48:20.000000000","message":"Yep, one thing at a time","commit_id":"56dd227155c818b28ddf7b58874da56b99d0fcd4"}]}