)]}'
{"keystone/auth/token_factory.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ae09e4de1532b08a55faedc01c643bf654bc6844","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Token Factory\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":"import sys"},{"line_number":22,"context_line":"import uuid"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F2y0%3D","line":19,"updated":"2013-06-19 17:56:28.000000000","message":"Same comment here on the extra line?","commit_id":"2d6d5aa58bce413f17359327a2ea5bf146df30c6"},{"author":{"_account_id":7708,"name":"Sergey Vilgelm","username":"svilgelm","inactive":true},"change_message_id":"970cd77ac698f8e96496b2ddfe143fae799232b4","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Token Factory\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":"import sys"},{"line_number":22,"context_line":"import uuid"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F0dk%3D","line":19,"in_reply_to":"AAAAPn%2F%2F2y0%3D","updated":"2013-06-20 13:59:45.000000000","message":"ditto","commit_id":"2d6d5aa58bce413f17359327a2ea5bf146df30c6"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2a5243151417d8c2482d5202d489c8714df86111","unresolved":false,"context_lines":[{"line_number":341,"context_line":"                    trust_id\u003dtrust[\u0027id\u0027] if trust else None)"},{"line_number":342,"context_line":"        token_api.create_token(context, token_id, data)"},{"line_number":343,"context_line":"    except Exception:"},{"line_number":344,"context_line":"        exc_info \u003d sys.exc_info()"},{"line_number":345,"context_line":"        # an identical token may have been created already."},{"line_number":346,"context_line":"        # if so, return the token_data as it is also identical"},{"line_number":347,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FwkA%3D","line":344,"updated":"2013-06-21 22:01:14.000000000","message":"nova has a handy save_and_reraise_exception , can we get that in Keystone?","commit_id":"2d6d5aa58bce413f17359327a2ea5bf146df30c6"},{"author":{"_account_id":7708,"name":"Sergey Vilgelm","username":"svilgelm","inactive":true},"change_message_id":"21d40678271ba1affb4061596b4a35fdfc342270","unresolved":false,"context_lines":[{"line_number":341,"context_line":"                    trust_id\u003dtrust[\u0027id\u0027] if trust else None)"},{"line_number":342,"context_line":"        token_api.create_token(context, token_id, data)"},{"line_number":343,"context_line":"    except Exception:"},{"line_number":344,"context_line":"        exc_info \u003d sys.exc_info()"},{"line_number":345,"context_line":"        # an identical token may have been created already."},{"line_number":346,"context_line":"        # if so, return the token_data as it is also identical"},{"line_number":347,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FuuA%3D","line":344,"in_reply_to":"AAAAPn%2F%2FwkA%3D","updated":"2013-06-25 15:09:28.000000000","message":"If not change the logic and use save_and_reraise_exception it will look like this:\nexcept Exception:\n    try:\n        with excutils.save_and_reraise_exception():\n            token_api.get_token(context\u003dcontext, token_id\u003dtoken_id)\n    except exception.TokenNotFound:\n        raise\n\nIt does not look much better, to do so?","commit_id":"2d6d5aa58bce413f17359327a2ea5bf146df30c6"}],"keystone/exception.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ae09e4de1532b08a55faedc01c643bf654bc6844","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import re"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from keystone.common import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F2y8%3D","line":17,"updated":"2013-06-19 17:56:28.000000000","message":"Why the whitespace add? Pep8?","commit_id":"2d6d5aa58bce413f17359327a2ea5bf146df30c6"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2a5243151417d8c2482d5202d489c8714df86111","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import re"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from keystone.common import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FwkE%3D","line":17,"in_reply_to":"AAAAPn%2F%2F0dw%3D","updated":"2013-06-21 22:01:14.000000000","message":"OpenStack guidelines suggest not mixing whitespace changes, see https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"2d6d5aa58bce413f17359327a2ea5bf146df30c6"},{"author":{"_account_id":7708,"name":"Sergey Vilgelm","username":"svilgelm","inactive":true},"change_message_id":"970cd77ac698f8e96496b2ddfe143fae799232b4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import re"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from keystone.common import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F0dw%3D","line":17,"in_reply_to":"AAAAPn%2F%2F2y8%3D","updated":"2013-06-20 13:59:45.000000000","message":"Not pep8. I for one think that\u0027s better for separating imports and comments.","commit_id":"2d6d5aa58bce413f17359327a2ea5bf146df30c6"},{"author":{"_account_id":7708,"name":"Sergey Vilgelm","username":"svilgelm","inactive":true},"change_message_id":"21d40678271ba1affb4061596b4a35fdfc342270","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import re"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from keystone.common import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Futo%3D","line":17,"in_reply_to":"AAAAPn%2F%2FwkE%3D","updated":"2013-06-25 15:09:28.000000000","message":"Done","commit_id":"2d6d5aa58bce413f17359327a2ea5bf146df30c6"}],"keystone/token/controllers.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ae09e4de1532b08a55faedc01c643bf654bc6844","unresolved":false,"context_lines":[{"line_number":12,"context_line":"from keystone import exception"},{"line_number":13,"context_line":"from keystone.openstack.common import timeutils"},{"line_number":14,"context_line":"from keystone.token import core"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"CONF \u003d config.CONF"},{"line_number":18,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F2zE%3D","line":15,"updated":"2013-06-19 17:56:28.000000000","message":"Why the whitespace add?","commit_id":"2d6d5aa58bce413f17359327a2ea5bf146df30c6"},{"author":{"_account_id":7708,"name":"Sergey Vilgelm","username":"svilgelm","inactive":true},"change_message_id":"970cd77ac698f8e96496b2ddfe143fae799232b4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"from keystone import exception"},{"line_number":13,"context_line":"from keystone.openstack.common import timeutils"},{"line_number":14,"context_line":"from keystone.token import core"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"CONF \u003d config.CONF"},{"line_number":18,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F0co%3D","line":15,"in_reply_to":"AAAAPn%2F%2F2zE%3D","updated":"2013-06-20 13:59:45.000000000","message":"For separating logical blocks.","commit_id":"2d6d5aa58bce413f17359327a2ea5bf146df30c6"}]}