)]}'
{"id":"openstack%2Fkeystone~336708","triplet_id":"openstack%2Fkeystone~master~Id0e7a8dd2773e6c31e3ad034a46e414230312db9","project":"openstack/keystone","branch":"master","hashtags":[],"change_id":"Id0e7a8dd2773e6c31e3ad034a46e414230312db9","subject":"Fixes hacking\u0027s handling of log hints","status":"MERGED","created":"2016-07-01 19:12:26.000000000","updated":"2016-07-05 20:59:40.000000000","submitted":"2016-07-05 20:59:39.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a48f406b004b0baf04915f519b4c992cdb9232d9","_number":336708,"virtual_id_number":336708,"owner":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-07-05 20:59:39.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-07-05 14:57:43.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":2,"date":"2016-07-05 17:57:45.000000000","_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":1,"date":"2016-07-05 17:57:45.000000000","_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-07-05 14:57:43.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2016-07-05 17:57:45.000000000","updated_by":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"reviewer":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"state":"REVIEWER"},{"updated":"2016-07-05 20:59:39.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"cf8da177e230d6007aefd5d5d509a00a5f4366b3","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2016-07-01 19:12:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"307648ca03899c61e80852580268b7e8be9673be","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2016-07-01 19:18:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"807353d4298a2f45d96d890f05ad2d64c7f14a80","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-01 23:42:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-keystone-docs http://docs-draft.openstack.org/08/336708/2/check/gate-keystone-docs/4e998af//doc/build/html/ : SUCCESS in 3m 57s\n- gate-keystone-pep8 http://logs.openstack.org/08/336708/2/check/gate-keystone-pep8/576d727/ : SUCCESS in 4m 01s\n- gate-keystone-python27-db http://logs.openstack.org/08/336708/2/check/gate-keystone-python27-db/d03961d/ : SUCCESS in 12m 14s\n- gate-keystone-python34-db http://logs.openstack.org/08/336708/2/check/gate-keystone-python34-db/d78647e/ : SUCCESS in 16m 17s\n- gate-tempest-dsvm-full http://logs.openstack.org/08/336708/2/check/gate-tempest-dsvm-full/d0dd447/ : SUCCESS in 59m 35s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/08/336708/2/check/gate-tempest-dsvm-postgres-full/a451b15/ : SUCCESS in 47m 25s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/08/336708/2/check/gate-tempest-dsvm-neutron-full/97423e5/ : SUCCESS in 1h 13m 08s\n- gate-grenade-dsvm http://logs.openstack.org/08/336708/2/check/gate-grenade-dsvm/a8ea9d7/ : SUCCESS in 31m 47s\n- gate-keystone-tox-db-legacy_drivers http://logs.openstack.org/08/336708/2/check/gate-keystone-tox-db-legacy_drivers/25d409b/ : SUCCESS in 9m 05s\n- gate-keystone-dsvm-functional http://logs.openstack.org/08/336708/2/check/gate-keystone-dsvm-functional/cbfb59a/ : SUCCESS in 24m 44s\n- gate-keystone-dsvm-functional-v3-only-nv http://logs.openstack.org/08/336708/2/check/gate-keystone-dsvm-functional-v3-only-nv/9173e1d/ : SUCCESS in 30m 02s (non-voting)\n- gate-tempest-dsvm-keystone-uwsgi-full-nv http://logs.openstack.org/08/336708/2/check/gate-tempest-dsvm-keystone-uwsgi-full-nv/9970a90/ : FAILURE in 1h 08m 54s (non-voting)\n- gate-tempest-dsvm-neutron-identity-v3-only-full-nv http://logs.openstack.org/08/336708/2/check/gate-tempest-dsvm-neutron-identity-v3-only-full-nv/8ab9529/ : SUCCESS in 1h 19m 46s (non-voting)\n- keystone-coverage-db http://logs.openstack.org/08/336708/2/check/keystone-coverage-db/850455d/ : SUCCESS in 21m 50s","accounts_in_message":[],"_revision_number":2},{"id":"203692c397f4da9d854522027127ebe26c2a7ee3","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2016-07-05 14:57:43.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"80f116abcb645ac7ddaad4a9474eca5ed889b549","author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"date":"2016-07-05 17:57:45.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nthanks, David","accounts_in_message":[],"_revision_number":2},{"id":"2a37f889e077610c29ef5c24e601b92b952254ca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-05 17:57:55.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"73e9e181a1c8fc417aff9c0dacad303c7c82a326","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-05 20:59:39.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-keystone-docs http://docs-draft.openstack.org/08/336708/2/gate/gate-keystone-docs/013a6d8//doc/build/html/ : SUCCESS in 4m 44s\n- gate-keystone-pep8 http://logs.openstack.org/08/336708/2/gate/gate-keystone-pep8/421a8fd/ : SUCCESS in 4m 53s\n- gate-keystone-python27-db http://logs.openstack.org/08/336708/2/gate/gate-keystone-python27-db/fb6e715/ : SUCCESS in 10m 17s\n- gate-keystone-python34-db http://logs.openstack.org/08/336708/2/gate/gate-keystone-python34-db/7f3630d/ : SUCCESS in 13m 24s\n- gate-tempest-dsvm-full http://logs.openstack.org/08/336708/2/gate/gate-tempest-dsvm-full/4f55ecf/ : SUCCESS in 47m 37s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/08/336708/2/gate/gate-tempest-dsvm-postgres-full/cc7912c/ : SUCCESS in 45m 14s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/08/336708/2/gate/gate-tempest-dsvm-neutron-full/33764ea/ : SUCCESS in 1h 02m 28s\n- gate-grenade-dsvm http://logs.openstack.org/08/336708/2/gate/gate-grenade-dsvm/e77bcf6/ : SUCCESS in 40m 12s\n- gate-keystone-dsvm-functional http://logs.openstack.org/08/336708/2/gate/gate-keystone-dsvm-functional/4c9c4b9/ : SUCCESS in 23m 12s\n- gate-keystone-tox-db-legacy_drivers http://logs.openstack.org/08/336708/2/gate/gate-keystone-tox-db-legacy_drivers/3bc9a0b/ : SUCCESS in 7m 20s","accounts_in_message":[],"_revision_number":2},{"id":"a48f406b004b0baf04915f519b4c992cdb9232d9","date":"2016-07-05 20:59:40.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"cd343ef70e8d7b47ac24cbd313a5815ac7bcb15f","revisions":{"755638845bb82da66273b4061128d7f1dcb70133":{"kind":"REWORK","_number":1,"created":"2016-07-01 19:12:26.000000000","uploader":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"ref":"refs/changes/08/336708/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/08/336708/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/08/336708/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/08/336708/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/08/336708/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/08/336708/1"}}},"commit":{"parents":[{"commit":"f1519a97f20b90ebc3c92fb3dbb2ad83b6a2445c","subject":"Merge \"Improve keystone.conf [identity] documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/f1519a97f20b90ebc3c92fb3dbb2ad83b6a2445c"}]}],"author":{"name":"David Stanek","email":"dstanek@dstanek.com","date":"2016-07-01 19:07:25.000000000","tz":0},"committer":{"name":"David Stanek","email":"dstanek@dstanek.com","date":"2016-07-01 19:12:06.000000000","tz":0},"subject":"Fixes hacking\u0027s handling of log hints","message":"Fixes hacking\u0027s handling of log hints\n\nOur hacking check was being a little too specific when ensuring we are\nusing the proper hints. This code fails because we are expecting that\nour code will not use a kwarg in the a raise case:\n\n  msg \u003d _(\u0027***\u0027)\n  LOG.warning(msg)\n  raise Exception(message\u003dmsg)\n\nHacking was forcing that msg used _LW(). This check accounts for kwargs\nand allows the above code to work.\n\nChange-Id: Id0e7a8dd2773e6c31e3ad034a46e414230312db9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/755638845bb82da66273b4061128d7f1dcb70133"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/755638845bb82da66273b4061128d7f1dcb70133"}]},"branch":"refs/heads/master"},"cd343ef70e8d7b47ac24cbd313a5815ac7bcb15f":{"kind":"REWORK","_number":2,"created":"2016-07-01 19:18:58.000000000","uploader":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"ref":"refs/changes/08/336708/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/08/336708/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/08/336708/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/08/336708/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/08/336708/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/08/336708/2"}}},"commit":{"parents":[{"commit":"f1519a97f20b90ebc3c92fb3dbb2ad83b6a2445c","subject":"Merge \"Improve keystone.conf [identity] documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/f1519a97f20b90ebc3c92fb3dbb2ad83b6a2445c"}]}],"author":{"name":"David Stanek","email":"dstanek@dstanek.com","date":"2016-07-01 19:07:25.000000000","tz":0},"committer":{"name":"David Stanek","email":"dstanek@dstanek.com","date":"2016-07-01 19:18:46.000000000","tz":0},"subject":"Fixes hacking\u0027s handling of log hints","message":"Fixes hacking\u0027s handling of log hints\n\nOur hacking check was being a little too specific when ensuring we are\nusing the proper hints. This code fails because we are expecting that\nour code will not use a kwarg in the a raise case:\n\n  msg \u003d _(\u0027***\u0027)\n  LOG.warning(msg)\n  raise Exception(message\u003dmsg)\n\nHacking was forcing that msg used _LW(). This check accounts for kwargs\nand allows the above code to work.\n\nChange-Id: Id0e7a8dd2773e6c31e3ad034a46e414230312db9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/cd343ef70e8d7b47ac24cbd313a5815ac7bcb15f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/cd343ef70e8d7b47ac24cbd313a5815ac7bcb15f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}