)]}'
{"keystone/assignment/role_backends/sql.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"0bf0afaf4729ddc2c26926caab96643cd0bba45b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        # filter_limit_query() below, which will remove the filter from the"},{"line_number":44,"context_line":"        # hints (hence ensuring our substitution is not exposed to the caller)."},{"line_number":45,"context_line":"        for f in hints.filters:"},{"line_number":46,"context_line":"            if f[\u0027name\u0027] \u003d\u003d \u0027domain_id\u0027:"},{"line_number":47,"context_line":"                break"},{"line_number":48,"context_line":"        else:"},{"line_number":49,"context_line":"            hints.add_filter(\u0027domain_id\u0027, NULL_DOMAIN_ID)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_1f6c17cf","line":47,"range":{"start_line":46,"start_character":12,"end_line":47,"end_character":21},"updated":"2016-07-06 12:36:55.000000000","message":"no, this won\u0027t work, since if the user has explcitely set domain\u003dNone, we still need to patch this to be NULL_DOMAIN_ID","commit_id":"376b4471c174e5d34d512e58e3f9a6ec2f16bb87"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"b12f18d10918feed6ffe4d9dce1c5f2b2a508d25","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        # filter_limit_query() below, which will remove the filter from the"},{"line_number":44,"context_line":"        # hints (hence ensuring our substitution is not exposed to the caller)."},{"line_number":45,"context_line":"        for f in hints.filters:"},{"line_number":46,"context_line":"            if f[\u0027name\u0027] \u003d\u003d \u0027domain_id\u0027:"},{"line_number":47,"context_line":"                break"},{"line_number":48,"context_line":"        else:"},{"line_number":49,"context_line":"            hints.add_filter(\u0027domain_id\u0027, NULL_DOMAIN_ID)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_124fc537","line":47,"range":{"start_line":46,"start_character":12,"end_line":47,"end_character":21},"in_reply_to":"1aa78d24_1f6c17cf","updated":"2016-07-07 03:41:10.000000000","message":"woops, that\u0027s just a mistake, there would need to be an additional \n\nif value is None:\n   value \u003d NULL_DOMAIN_ID","commit_id":"376b4471c174e5d34d512e58e3f9a6ec2f16bb87"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"0bf0afaf4729ddc2c26926caab96643cd0bba45b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            if f[\u0027name\u0027] \u003d\u003d \u0027domain_id\u0027:"},{"line_number":47,"context_line":"                break"},{"line_number":48,"context_line":"        else:"},{"line_number":49,"context_line":"            hints.add_filter(\u0027domain_id\u0027, NULL_DOMAIN_ID)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        with sql.session_for_read() as session:"},{"line_number":52,"context_line":"            query \u003d session.query(RoleTable)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_7fb43b34","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":57},"updated":"2016-07-06 12:36:55.000000000","message":"if we add this here, how would I ever ask for all roles, whether global or not?","commit_id":"376b4471c174e5d34d512e58e3f9a6ec2f16bb87"}]}