)]}'
{"keystone/common/controller.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f886471c65a18cfb385fb0d6de6902b7fb4b9906","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # see if auth context has already been created. If so use it."},{"line_number":83,"context_line":"    if (\u0027environment\u0027 in context and"},{"line_number":84,"context_line":"            authorization.AUTH_CONTEXT_ENV in context[\u0027environment\u0027]):"},{"line_number":85,"context_line":"        LOG.debug(\u0027RBAC: using auth context from the request environment\u0027)"},{"line_number":86,"context_line":"        return context[\u0027environment\u0027].get(authorization.AUTH_CONTEXT_ENV)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_57a36d9e","side":"PARENT","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":68},"updated":"2016-07-11 03:21:53.000000000","message":"it would be good to still check that it\u0027s there and log what to do if it\u0027s not","commit_id":"187490fd7ec80b8c8c932d897408e5e185705dfa"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"60f45ee39e49b33c701382239eabf16200c3aee4","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # see if auth context has already been created. If so use it."},{"line_number":83,"context_line":"    if (\u0027environment\u0027 in context and"},{"line_number":84,"context_line":"            authorization.AUTH_CONTEXT_ENV in context[\u0027environment\u0027]):"},{"line_number":85,"context_line":"        LOG.debug(\u0027RBAC: using auth context from the request environment\u0027)"},{"line_number":86,"context_line":"        return context[\u0027environment\u0027].get(authorization.AUTH_CONTEXT_ENV)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_94f6265b","side":"PARENT","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":68},"in_reply_to":"1aa78d24_57a36d9e","updated":"2016-07-12 10:24:33.000000000","message":"I think this is covered because the only way it isn\u0027t present is if auth_context is not in the pipeline and in that case the warnings in the protected methods will be triggered.","commit_id":"187490fd7ec80b8c8c932d897408e5e185705dfa"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"d4d5d9aa5e79f113595aca0fd3a3a748391bf457","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \u0027action\u0027: action,"},{"line_number":80,"context_line":"        \u0027kwargs\u0027: kwargs_str})"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    return context[\u0027environment\u0027].get(authorization.AUTH_CONTEXT_ENV, {})"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def protected(callback\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_b2568827","line":82,"updated":"2016-07-13 14:54:51.000000000","message":"Wow!  This looks much nicer than than the code that was there before :-)","commit_id":"1d7c96d6a3e839dc64ae590da08cbee4b2108273"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"d4d5d9aa5e79f113595aca0fd3a3a748391bf457","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def wrapper(f):"},{"line_number":99,"context_line":"        @functools.wraps(f)"},{"line_number":100,"context_line":"        def inner(self, request, *args, **kwargs):"},{"line_number":101,"context_line":"            request.assert_authenticated()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"            if request.context.is_admin:"},{"line_number":104,"context_line":"                LOG.warning(_LW(\u0027RBAC: Bypassing authorization\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_722700ca","line":101,"updated":"2016-07-13 14:54:51.000000000","message":"Nice!","commit_id":"1d7c96d6a3e839dc64ae590da08cbee4b2108273"}],"keystone/middleware/auth.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a8b411b1bedf252fdbcef88e323572a6e367354","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                      \u0027context will be set.\u0027)"},{"line_number":205,"context_line":"            return"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        request_context.authenticated \u003d True"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        # The attributes of request_context are put into the logs. This is a"},{"line_number":210,"context_line":"        # common pattern for all the OpenStack services. In all the other"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_ad14029f","line":207,"range":{"start_line":207,"start_character":8,"end_line":207,"end_character":44},"updated":"2016-07-11 05:11:22.000000000","message":"add a comment here","commit_id":"dae292d5ac813bf12f2bde2e3c1fcebb660ed797"}],"keystone/tests/unit/test_v3_auth.py":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"d4d5d9aa5e79f113595aca0fd3a3a748391bf457","unresolved":false,"context_lines":[{"line_number":4698,"context_line":"            self.head(\u0027/auth/tokens\u0027, headers\u003dheaders,"},{"line_number":4699,"context_line":"                      expected_status\u003dhttp_client.FORBIDDEN)"},{"line_number":4700,"context_line":""},{"line_number":4701,"context_line":""},{"line_number":4702,"context_line":"class TestAuthContext(unit.TestCase):"},{"line_number":4703,"context_line":"    def setUp(self):"},{"line_number":4704,"context_line":"        super(TestAuthContext, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_a3c63c65","line":4701,"updated":"2016-07-13 14:54:51.000000000","message":"Well yes that test case just isn\u0027t \"exciting\" anymore. Or needed!","commit_id":"1d7c96d6a3e839dc64ae590da08cbee4b2108273"}]}