)]}'
{"keystone/catalog/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9c952d0a50a253e0b50ff53e1330b3ed8c7d51a1","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            self.driver.delete_endpoint_group_association_by_project("},{"line_number":255,"context_line":"                project_id)"},{"line_number":256,"context_line":"        except exception.NotImplemented:"},{"line_number":257,"context_line":"            # Some catalog drivers don\u0027t support this"},{"line_number":258,"context_line":"            pass"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def get_endpoint_groups_for_project(self, project_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_fb1d0467","line":257,"updated":"2016-07-11 15:30:06.000000000","message":"Do we want to log anything here?","commit_id":"511a86064881cdef9e9db2fab3bf02378bc2c704"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"92f3bd7d52328f847804d5d3de8ee0aa5f522ec2","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            self.driver.delete_endpoint_group_association_by_project("},{"line_number":255,"context_line":"                project_id)"},{"line_number":256,"context_line":"        except exception.NotImplemented:"},{"line_number":257,"context_line":"            # Some catalog drivers don\u0027t support this"},{"line_number":258,"context_line":"            pass"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def get_endpoint_groups_for_project(self, project_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_dd1b7771","line":257,"in_reply_to":"1aa78d24_40724512","updated":"2016-07-13 09:09:53.000000000","message":"So this method is not exposed to the API...we only call it from the controller when the controller catches a delete project notification. Previous the controller itself caught the exception that was raised from the driver...all this does is move this catching to the manager.","commit_id":"511a86064881cdef9e9db2fab3bf02378bc2c704"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"7d14845b0a1297a648e1131d276654cd102dc53f","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            self.driver.delete_endpoint_group_association_by_project("},{"line_number":255,"context_line":"                project_id)"},{"line_number":256,"context_line":"        except exception.NotImplemented:"},{"line_number":257,"context_line":"            # Some catalog drivers don\u0027t support this"},{"line_number":258,"context_line":"            pass"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def get_endpoint_groups_for_project(self, project_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_40724512","line":257,"in_reply_to":"1aa78d24_d6445fb8","updated":"2016-07-12 07:47:47.000000000","message":"Is there any possible for any user try to call this method when template backend in use? for any reason maybe just use call it by accident. Try to delete enpoint group associated with the project but just silently ignore the exception (previously, it will show you the exception), is that okay?","commit_id":"511a86064881cdef9e9db2fab3bf02378bc2c704"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"26fa8e9994782af01acea210b2f53717fcc2fcc7","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            self.driver.delete_endpoint_group_association_by_project("},{"line_number":255,"context_line":"                project_id)"},{"line_number":256,"context_line":"        except exception.NotImplemented:"},{"line_number":257,"context_line":"            # Some catalog drivers don\u0027t support this"},{"line_number":258,"context_line":"            pass"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def get_endpoint_groups_for_project(self, project_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_8bac09ee","line":257,"in_reply_to":"1aa78d24_dd1b7771","updated":"2016-07-13 09:50:15.000000000","message":"True, this method is not exposed to outside, I agree no log is needed here.","commit_id":"511a86064881cdef9e9db2fab3bf02378bc2c704"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"2df3aebd901306a0e41c59368fea314743d8f486","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            self.driver.delete_endpoint_group_association_by_project("},{"line_number":255,"context_line":"                project_id)"},{"line_number":256,"context_line":"        except exception.NotImplemented:"},{"line_number":257,"context_line":"            # Some catalog drivers don\u0027t support this"},{"line_number":258,"context_line":"            pass"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def get_endpoint_groups_for_project(self, project_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_d6445fb8","line":257,"in_reply_to":"1aa78d24_fb1d0467","updated":"2016-07-11 15:55:04.000000000","message":"I don\u0027t think there is a need for that - since those drivers that don\u0027t support this don\u0027t support the creating of the associations in the first place. So all that would happen is you would get a log entry everytime you deleted a project, for something that is expected for, say, the templates catalog.","commit_id":"511a86064881cdef9e9db2fab3bf02378bc2c704"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9c952d0a50a253e0b50ff53e1330b3ed8c7d51a1","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            self.driver.delete_association_by_endpoint(endpoint_id)"},{"line_number":323,"context_line":"        except exception.NotImplemented:"},{"line_number":324,"context_line":"            # Some catalog drivers don\u0027t support this"},{"line_number":325,"context_line":"            pass"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def delete_association_by_project(self, project_id):"},{"line_number":328,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_db2f6886","line":325,"updated":"2016-07-11 15:30:06.000000000","message":"Would it be useful to log anything here?","commit_id":"511a86064881cdef9e9db2fab3bf02378bc2c704"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"2df3aebd901306a0e41c59368fea314743d8f486","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            self.driver.delete_association_by_endpoint(endpoint_id)"},{"line_number":323,"context_line":"        except exception.NotImplemented:"},{"line_number":324,"context_line":"            # Some catalog drivers don\u0027t support this"},{"line_number":325,"context_line":"            pass"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def delete_association_by_project(self, project_id):"},{"line_number":328,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_1615479a","line":325,"in_reply_to":"1aa78d24_db2f6886","updated":"2016-07-11 15:55:04.000000000","message":"as above","commit_id":"511a86064881cdef9e9db2fab3bf02378bc2c704"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9c952d0a50a253e0b50ff53e1330b3ed8c7d51a1","unresolved":false,"context_lines":[{"line_number":329,"context_line":"            self.driver.delete_association_by_project(project_id)"},{"line_number":330,"context_line":"        except exception.NotImplemented:"},{"line_number":331,"context_line":"            # Some catalog drivers don\u0027t support this"},{"line_number":332,"context_line":"            pass"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"@versionutils.deprecated("}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_fb4b4457","line":332,"updated":"2016-07-11 15:30:06.000000000","message":"Would it be useful to log anything here?","commit_id":"511a86064881cdef9e9db2fab3bf02378bc2c704"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"2df3aebd901306a0e41c59368fea314743d8f486","unresolved":false,"context_lines":[{"line_number":329,"context_line":"            self.driver.delete_association_by_project(project_id)"},{"line_number":330,"context_line":"        except exception.NotImplemented:"},{"line_number":331,"context_line":"            # Some catalog drivers don\u0027t support this"},{"line_number":332,"context_line":"            pass"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"@versionutils.deprecated("}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_560fcf87","line":332,"in_reply_to":"1aa78d24_fb4b4457","updated":"2016-07-11 15:55:04.000000000","message":"as above","commit_id":"511a86064881cdef9e9db2fab3bf02378bc2c704"}]}
