)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"78c4a0f4ae70b33929e45d3ffb565ca030b81a73","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use URIOpt instead of StrOpt for SAML config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6708b41501c8672bdb6315e43d3817cc9ceec010"},{"line_number":10,"context_line":"Depends-On: I39d012b0b7ebeddf6067016487ac8258461dda30"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_6b7360e8","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":53},"updated":"2016-08-02 20:49:13.000000000","message":"Might want to change to commit Id7c54f98fce0e9775b12f7e78aa7810200f0ced5 or wait till it merges.","commit_id":"a216ee34fdbcf6ce17f2f6ce654e152e35eb831c"}],"keystone/conf/saml.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f6ebaaaece5fca5c4a1799f88e1195a283cc4f12","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"idp_entity_id \u003d cfg.StrOpt("},{"line_number":55,"context_line":"    \u0027idp_entity_id\u0027,"},{"line_number":56,"context_line":"    max_length\u003d1024,"},{"line_number":57,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":58,"context_line":"This is the unique entity identifier of the identity provider (keystone) to use"},{"line_number":59,"context_line":"when generating SAML assertions. This value is required to generate identity"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_35d8bdee","side":"PARENT","line":56,"updated":"2016-07-13 15:41:58.000000000","message":"We will either have to keep this as StrOpt or patch oslo.config\u0027s URIOpt to support max_length. \n\nhttp://logs.openstack.org/14/341514/2/check/gate-keystone-python27-db/f6b0bb6/console.html#_2016-07-13_13_47_00_327933\n\nI hit this locally yesterday, too.","commit_id":"dfac754aa50f3460352b68f52e9722fdc9f4e3d3"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"afdc93b03aa33ae7e120c9ea9ffeab0d6362be9e","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"idp_entity_id \u003d cfg.StrOpt("},{"line_number":55,"context_line":"    \u0027idp_entity_id\u0027,"},{"line_number":56,"context_line":"    max_length\u003d1024,"},{"line_number":57,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":58,"context_line":"This is the unique entity identifier of the identity provider (keystone) to use"},{"line_number":59,"context_line":"when generating SAML assertions. This value is required to generate identity"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_e05ae8f1","side":"PARENT","line":56,"in_reply_to":"1aa78d24_35d8bdee","updated":"2016-07-13 19:36:29.000000000","message":"I tossed up a patch to oslo.config for this. However it\u0027ll take a while to merge and release through g-r. For now, StrOpt is the only option for idp_entity_id.\n\nhttps://review.openstack.org/#/c/341763/","commit_id":"dfac754aa50f3460352b68f52e9722fdc9f4e3d3"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8f25feafb46ed1ca40adf8959cdac4d5e41d8083","unresolved":false,"context_lines":[{"line_number":51,"context_line":"contain a comma (`,`)."},{"line_number":52,"context_line":"\"\"\"))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"idp_entity_id \u003d cfg.URIOpt("},{"line_number":55,"context_line":"    \u0027idp_entity_id\u0027,"},{"line_number":56,"context_line":"    max_length\u003d1024,"},{"line_number":57,"context_line":"    help\u003dutils.fmt(\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_2a3a0a35","line":54,"updated":"2016-07-13 20:42:12.000000000","message":"I think this is still going to fail for the reasons noted in patch set 2. We could keep this as StrOpt until Eric\u0027s patch to oslo.config lands.","commit_id":"a216ee34fdbcf6ce17f2f6ce654e152e35eb831c"}]}