)]}'
{"keystone/federation/idp.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"df60795e0fb61fa0c43be0f7650c6bfe0ba40244","unresolved":false,"context_lines":[{"line_number":400,"context_line":"    :returns: XML \u003cAssertion\u003e object"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    \"\"\""},{"line_number":403,"context_line":"    # Validate certificate configuration."},{"line_number":404,"context_line":"    for option in (\u0027keyfile\u0027, \u0027certfile\u0027):"},{"line_number":405,"context_line":"        if \u0027,\u0027 in getattr(CONF.saml, option, \u0027\u0027):"},{"line_number":406,"context_line":"            raise exception.UnexpectedError(_LE("}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_af6aa37e","line":403,"updated":"2016-07-13 13:52:22.000000000","message":"think this comment can be more specific on why having commas are not ok - like it is done in the commit message","commit_id":"75da9db519798318d22d39ed5a2d7aff3ba45eee"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5cb138a6ccec42f9c607eb2b13bdfd6118b83fc6","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            raise exception.UnexpectedError(_LE("},{"line_number":407,"context_line":"                \u0027The configuration value in `keystone.conf [saml] %s` cannot \u0027"},{"line_number":408,"context_line":"                \u0027contain a comma (`,`). Please fix your configuration.\u0027),"},{"line_number":409,"context_line":"                option)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    # xmlsec1 --sign --privkey-pem privkey,cert --id-attr:ID \u003ctag\u003e \u003cfile\u003e"},{"line_number":412,"context_line":"    certificates \u003d \u0027%(idp_private_key)s,%(idp_public_key)s\u0027 % {"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_f5b0f5dd","line":409,"updated":"2016-07-13 15:40:13.000000000","message":"We could add a test for this to make sure we preserve good user-experience.","commit_id":"75da9db519798318d22d39ed5a2d7aff3ba45eee"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"6386da5d51d8884ad59717ef06891676ec2fced9","unresolved":false,"context_lines":[{"line_number":402,"context_line":"    \"\"\""},{"line_number":403,"context_line":"    # Ensure that the configured certificate paths do not contain any commas,"},{"line_number":404,"context_line":"    # before we string format a comma in between them and cause xmlsec1 to"},{"line_number":405,"context_line":"    # explode like a thousand fiery supernovas made entirely of unsigned SAML."},{"line_number":406,"context_line":"    for option in (\u0027keyfile\u0027, \u0027certfile\u0027):"},{"line_number":407,"context_line":"        if \u0027,\u0027 in getattr(CONF.saml, option, \u0027\u0027):"},{"line_number":408,"context_line":"            raise exception.UnexpectedError(_LE("}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_8dc6b866","line":405,"range":{"start_line":405,"start_character":21,"end_line":405,"end_character":47},"updated":"2016-07-13 20:57:15.000000000","message":"Love it!","commit_id":"459dd8b287fcad2dfb15ba833ae3090bc10d72d8"}]}