)]}'
{"keystone/conf/security_compliance.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"05fd0d9270ec364bfb7432603ec7824733c18f7a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"user account is locked for the number of seconds specified by"},{"line_number":38,"context_line":"`[security_compliance] lockout_duration`. Setting this value to zero (the"},{"line_number":39,"context_line":"default) disables this feature. This feature depends on the `sql` backend for"},{"line_number":40,"context_line":"the `[identity] driver`."},{"line_number":41,"context_line":"\"\"\"))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"lockout_duration \u003d cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_aabefa61","line":40,"updated":"2016-07-13 20:47:46.000000000","message":"Ron has some good information about lockout_failure_attempts proposed here, too\n\nhttps://review.openstack.org/#/c/340074/18/keystone/conf/security_compliance.py","commit_id":"8a4d15da60c28771d02ae1aa9fcef7b71699c2c1"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"e586267e2c5dce1f4a0ffe3114e7753acb013bb7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"user account is locked for the number of seconds specified by"},{"line_number":38,"context_line":"`[security_compliance] lockout_duration`. Setting this value to zero (the"},{"line_number":39,"context_line":"default) disables this feature. This feature depends on the `sql` backend for"},{"line_number":40,"context_line":"the `[identity] driver`."},{"line_number":41,"context_line":"\"\"\"))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"lockout_duration \u003d cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_2d46a421","line":40,"in_reply_to":"1aa78d24_aabefa61","updated":"2016-07-13 20:54:07.000000000","message":"+1 given that\u0027s part of a larger change that impacts the usage of this option, I\u0027ll leave it to solve in merge conflict later :-/","commit_id":"8a4d15da60c28771d02ae1aa9fcef7b71699c2c1"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"1d758b5e54ad8f69123c44ed47613b9ee4616275","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    min\u003d1,"},{"line_number":47,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":48,"context_line":"The number of seconds a user account will be locked when the maximum number of"},{"line_number":49,"context_line":"authentication attempts (as specified by `[security_compliance]"},{"line_number":50,"context_line":"lockout_failure_attempts`) is exceeded. Setting this option will have no effect"},{"line_number":51,"context_line":"unless you also set `[security_compliance] lockout_failure_attempts` to a"},{"line_number":52,"context_line":"non-zero value. This feature depends on the `sql` backend for"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_0ab46e80","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":14},"updated":"2016-07-13 20:49:42.000000000","message":"nit: failed authentication attempts...","commit_id":"8a4d15da60c28771d02ae1aa9fcef7b71699c2c1"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"e586267e2c5dce1f4a0ffe3114e7753acb013bb7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    min\u003d1,"},{"line_number":47,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":48,"context_line":"The number of seconds a user account will be locked when the maximum number of"},{"line_number":49,"context_line":"authentication attempts (as specified by `[security_compliance]"},{"line_number":50,"context_line":"lockout_failure_attempts`) is exceeded. Setting this option will have no effect"},{"line_number":51,"context_line":"unless you also set `[security_compliance] lockout_failure_attempts` to a"},{"line_number":52,"context_line":"non-zero value. This feature depends on the `sql` backend for"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_2daa24d3","line":49,"in_reply_to":"1aa78d24_0ab46e80","updated":"2016-07-13 20:54:07.000000000","message":"+1","commit_id":"8a4d15da60c28771d02ae1aa9fcef7b71699c2c1"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"1d758b5e54ad8f69123c44ed47613b9ee4616275","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":61,"context_line":"The number of days which a password will be considered valid before requiring"},{"line_number":62,"context_line":"the user to change it. Setting the value to zero (the default) disables this"},{"line_number":63,"context_line":"feature. This feature is only supported via the SQL backend driver for"},{"line_number":64,"context_line":"identity. This feature depends on the `sql` backend for the `[identity]"},{"line_number":65,"context_line":"driver`."},{"line_number":66,"context_line":"\"\"\"))"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_aa339a12","line":64,"range":{"start_line":63,"start_character":9,"end_line":64,"end_character":10},"updated":"2016-07-13 20:49:42.000000000","message":"You can remove this line now.","commit_id":"8a4d15da60c28771d02ae1aa9fcef7b71699c2c1"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"e586267e2c5dce1f4a0ffe3114e7753acb013bb7","unresolved":false,"context_lines":[{"line_number":61,"context_line":"The number of days which a password will be considered valid before requiring"},{"line_number":62,"context_line":"the user to change it. Setting the value to zero (the default) disables this"},{"line_number":63,"context_line":"feature. This feature is only supported via the SQL backend driver for"},{"line_number":64,"context_line":"identity. This feature depends on the `sql` backend for the `[identity]"},{"line_number":65,"context_line":"driver`."},{"line_number":66,"context_line":"\"\"\"))"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_cd98c0cf","line":64,"in_reply_to":"1aa78d24_aa339a12","updated":"2016-07-13 20:54:07.000000000","message":"Whoops, bad copy pasta.","commit_id":"8a4d15da60c28771d02ae1aa9fcef7b71699c2c1"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"05fd0d9270ec364bfb7432603ec7824733c18f7a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"the user to change it. Setting the value to zero (the default) disables this"},{"line_number":63,"context_line":"feature. This feature is only supported via the SQL backend driver for"},{"line_number":64,"context_line":"identity. This feature depends on the `sql` backend for the `[identity]"},{"line_number":65,"context_line":"driver`."},{"line_number":66,"context_line":"\"\"\"))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"unique_last_password_count \u003d cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_4a5cb64c","line":65,"updated":"2016-07-13 20:47:46.000000000","message":"These last two sentences are very similar. Could they be consolidated into one?","commit_id":"8a4d15da60c28771d02ae1aa9fcef7b71699c2c1"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"e586267e2c5dce1f4a0ffe3114e7753acb013bb7","unresolved":false,"context_lines":[{"line_number":62,"context_line":"the user to change it. Setting the value to zero (the default) disables this"},{"line_number":63,"context_line":"feature. This feature is only supported via the SQL backend driver for"},{"line_number":64,"context_line":"identity. This feature depends on the `sql` backend for the `[identity]"},{"line_number":65,"context_line":"driver`."},{"line_number":66,"context_line":"\"\"\"))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"unique_last_password_count \u003d cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_ad9d74bd","line":65,"in_reply_to":"1aa78d24_4a5cb64c","updated":"2016-07-13 20:54:07.000000000","message":"+1","commit_id":"8a4d15da60c28771d02ae1aa9fcef7b71699c2c1"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"66a64409d0a4fbbfe3a2fe52ffd01f0cafa705f4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":36,"context_line":"The maximum number of times that a user can fail to authenticate before the"},{"line_number":37,"context_line":"user account is locked for the number of seconds specified by"},{"line_number":38,"context_line":"`[security_compliance] lockout_duration`. Setting this value to zero (the"},{"line_number":39,"context_line":"default) disables this feature. This feature depends on the `sql` backend for"},{"line_number":40,"context_line":"the `[identity] driver`."},{"line_number":41,"context_line":"\"\"\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_c62a5590","line":38,"updated":"2016-07-14 04:20:58.000000000","message":"change in tense from above. \n\ndisabled by default; set any value to enable it \nvs\nSetting this value to zero (the default) disables this feature.","commit_id":"f48ab4f4642816162e03a255e98fd2b33be932a6"}]}