)]}'
{"keystone/tests/unit/test_v2.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"ba72826a6310625f83c807c0a8b90ee2eba3a644","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"        resp \u003d _admin_request(body, http_client.OK)"},{"line_number":1424,"context_line":"        self.assertFalse(resp.json[\u0027user\u0027][\u0027enabled\u0027])"},{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"        # Attributes other than `enabled` are not allowed."},{"line_number":1427,"context_line":"        body \u003d {"},{"line_number":1428,"context_line":"            \u0027user\u0027: {"},{"line_number":1429,"context_line":"                \u0027description\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_8358848b","line":1426,"updated":"2016-07-27 12:17:04.000000000","message":"would be nice to add \"enabled\" with a valid value in the body too. This way we know that it won\u0027t ignore other fields if enabled is passed.","commit_id":"4adf01b03b75af4bb1917f545dc71788fb07d5ea"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"df0b89f3679eea6aa5aeb16ac8ef0c1f5cb7f7d5","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"        resp \u003d _admin_request(body, http_client.OK)"},{"line_number":1424,"context_line":"        self.assertFalse(resp.json[\u0027user\u0027][\u0027enabled\u0027])"},{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"        # Attributes other than `enabled` are not allowed."},{"line_number":1427,"context_line":"        body \u003d {"},{"line_number":1428,"context_line":"            \u0027user\u0027: {"},{"line_number":1429,"context_line":"                \u0027description\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_2bf02f90","line":1426,"in_reply_to":"bacf61ea_46a5b102","updated":"2016-07-28 12:04:49.000000000","message":"Hi Dave, it is just another possibility for the \"other\" attributes case: \"other\" attributes -\u003e fail, \"other\" attributes + \"enabled\" -\u003e fail\n\nThe suggestion is only to cover all the possibilities in the test case","commit_id":"4adf01b03b75af4bb1917f545dc71788fb07d5ea"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"ea2a00cbcd09da06f1a804d75e1e00907eb62331","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"        resp \u003d _admin_request(body, http_client.OK)"},{"line_number":1424,"context_line":"        self.assertFalse(resp.json[\u0027user\u0027][\u0027enabled\u0027])"},{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"        # Attributes other than `enabled` are not allowed."},{"line_number":1427,"context_line":"        body \u003d {"},{"line_number":1428,"context_line":"            \u0027user\u0027: {"},{"line_number":1429,"context_line":"                \u0027description\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_46a5b102","line":1426,"in_reply_to":"dada55a8_8358848b","updated":"2016-07-28 01:38:27.000000000","message":"@Rodrigo, IMHO, this API is dedicated to enable a user, so I think the only accepted attribute is `enabled`, update other attributes in body should go to update user API instead of enabled user.\n\nAs to your comments, if `enabled` with other attributes is added into body, it will raise Bad request too.\n\nIt will not pass the testcase here, `enabled` added here won\u0027t give us any difference. What do you think?","commit_id":"4adf01b03b75af4bb1917f545dc71788fb07d5ea"}]}