)]}'
{"keystone/conf/token.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"9c760b68d965c48a3956f0a1441112b727d33b24","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"expiration_grace_period \u003d cfg.IntOpt("},{"line_number":60,"context_line":"    \u0027expiration_grace_period\u0027,"},{"line_number":61,"context_line":"    default\u003d7 * 24 * 60 * 60,"},{"line_number":62,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":63,"context_line":"After a token would normally be considered expired according to `[token]"},{"line_number":64,"context_line":"expiration`, the grace period defines an additional period of time which"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_5807b717","line":61,"range":{"start_line":61,"start_character":12,"end_line":61,"end_character":28},"updated":"2016-07-20 23:21:51.000000000","message":"I\u0027m not sure if the default should be 0 (i.e. no change to existing functionality at upgrade to N)","commit_id":"b7903a40e6466a543b5d08d6187ae2d1c6b4a49f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b7d1a030cae16c9326cdad404900abea9fa250ac","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"expiration_grace_period \u003d cfg.IntOpt("},{"line_number":60,"context_line":"    \u0027expiration_grace_period\u0027,"},{"line_number":61,"context_line":"    default\u003d7 * 24 * 60 * 60,"},{"line_number":62,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":63,"context_line":"After a token would normally be considered expired according to `[token]"},{"line_number":64,"context_line":"expiration`, the grace period defines an additional period of time which"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_9843ef41","line":61,"in_reply_to":"dada55a8_5807b717","updated":"2016-07-20 23:24:49.000000000","message":"I appreciate the concern, but I\u0027d rather that the default values in keystone.conf reflect the values that we recommend for deployers to use in production. If we\u0027re going to move forward with this, I don\u0027t want to do it without it being the recommended default.","commit_id":"b7903a40e6466a543b5d08d6187ae2d1c6b4a49f"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"38dba82d7d1495317e07580dd84acc57c32c8861","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"expiration_grace_period \u003d cfg.IntOpt("},{"line_number":60,"context_line":"    \u0027expiration_grace_period\u0027,"},{"line_number":61,"context_line":"    default\u003d7 * 24 * 60 * 60,"},{"line_number":62,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":63,"context_line":"After a token would normally be considered expired according to `[token]"},{"line_number":64,"context_line":"expiration`, the grace period defines an additional period of time which"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_a5caa26c","line":61,"in_reply_to":"dada55a8_9843ef41","updated":"2016-07-22 16:24:56.000000000","message":"I always like the good defaults argument, particularly when we don\u0027t specify what we think a good value would be otherwise. \n\nI think that because we require the x-service-token for this operation i don\u0027t think it\u0027s a backwards incompatible change.","commit_id":"b7903a40e6466a543b5d08d6187ae2d1c6b4a49f"}]}