)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"617e7f50dcaef0f976917e017f8dcb9dbe3d1f72","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lance Bragstad \u003clbragstad@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-22 16:13:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make AuthWithToken testable against uuid and fernet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We should make AuthWithTest something that is tested against both the uuid"},{"line_number":10,"context_line":"token provider and the fernet token provider. This helps us move towards making"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_f419ea7a","line":7,"updated":"2016-07-22 17:45:58.000000000","message":"This should be AuthWithTrust","commit_id":"aa4442615aa0f18c191377f3bc9f5f1dc8a43de2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"31617604eed41ebc13b573548a83a307ba97be3e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lance Bragstad \u003clbragstad@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-22 16:13:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make AuthWithToken testable against uuid and fernet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We should make AuthWithTest something that is tested against both the uuid"},{"line_number":10,"context_line":"token provider and the fernet token provider. This helps us move towards making"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_6cd04a54","line":7,"in_reply_to":"dada55a8_f419ea7a","updated":"2016-07-25 16:53:33.000000000","message":"Done","commit_id":"aa4442615aa0f18c191377f3bc9f5f1dc8a43de2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"617e7f50dcaef0f976917e017f8dcb9dbe3d1f72","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make AuthWithToken testable against uuid and fernet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We should make AuthWithTest something that is tested against both the uuid"},{"line_number":10,"context_line":"token provider and the fernet token provider. This helps us move towards making"},{"line_number":11,"context_line":"fernet the default token provider."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_342a627f","line":9,"updated":"2016-07-22 17:45:58.000000000","message":"This should be AuthWithTrust","commit_id":"aa4442615aa0f18c191377f3bc9f5f1dc8a43de2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"31617604eed41ebc13b573548a83a307ba97be3e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make AuthWithToken testable against uuid and fernet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We should make AuthWithTest something that is tested against both the uuid"},{"line_number":10,"context_line":"token provider and the fernet token provider. This helps us move towards making"},{"line_number":11,"context_line":"fernet the default token provider."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_4cd3c65f","line":9,"in_reply_to":"dada55a8_342a627f","updated":"2016-07-25 16:53:33.000000000","message":"Done","commit_id":"aa4442615aa0f18c191377f3bc9f5f1dc8a43de2"}],"keystone/tests/unit/test_auth.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6763ce2c77e1586f20df9eb8c331a78580d191ed","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"        super(FernetAuthWithTrust, self).setUp()"},{"line_number":1305,"context_line":""},{"line_number":1306,"context_line":"    def test_delete_tokens_for_user_invalidates_tokens_from_trust(self):"},{"line_number":1307,"context_line":"        msg \u003d \u0027The Fernet token provider does not support token persistence\u0027"},{"line_number":1308,"context_line":"        self.skipTest(msg)"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":"    def test_delete_trust_revokes_token(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_d46786e8","line":1307,"updated":"2016-07-22 17:47:56.000000000","message":"Add TODO here or rewrite this test to not rely on the persistence backend in the test.","commit_id":"aa4442615aa0f18c191377f3bc9f5f1dc8a43de2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"31617604eed41ebc13b573548a83a307ba97be3e","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"        super(FernetAuthWithTrust, self).setUp()"},{"line_number":1305,"context_line":""},{"line_number":1306,"context_line":"    def test_delete_tokens_for_user_invalidates_tokens_from_trust(self):"},{"line_number":1307,"context_line":"        msg \u003d \u0027The Fernet token provider does not support token persistence\u0027"},{"line_number":1308,"context_line":"        self.skipTest(msg)"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":"    def test_delete_trust_revokes_token(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_8ca81edd","line":1307,"in_reply_to":"dada55a8_d46786e8","updated":"2016-07-25 16:53:33.000000000","message":"Done","commit_id":"aa4442615aa0f18c191377f3bc9f5f1dc8a43de2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"31617604eed41ebc13b573548a83a307ba97be3e","unresolved":false,"context_lines":[{"line_number":1316,"context_line":"        trust_id \u003d new_trust[\u0027id\u0027]"},{"line_number":1317,"context_line":"        self.trust_controller.delete_trust(request, trust_id\u003dtrust_id)"},{"line_number":1318,"context_line":"        # FIXME(lbragstad): For some reason this returns a Forbidden"},{"line_number":1319,"context_line":"        # instead of a NotFound(?!)"},{"line_number":1320,"context_line":"        self.assertRaises("},{"line_number":1321,"context_line":"            exception.Forbidden,"},{"line_number":1322,"context_line":"            self.controller.validate_token,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_ecc43a93","line":1319,"updated":"2016-07-25 16:53:33.000000000","message":"This should be fixed to return the same error code that is returned when the UUID provider is used.","commit_id":"aa4442615aa0f18c191377f3bc9f5f1dc8a43de2"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"8b92223ab0e209c658d0b5f028657f03c301f451","unresolved":false,"context_lines":[{"line_number":1179,"context_line":"            self.controller.authenticate, self.make_request(), request_body)"},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"    def test_delete_trust_revokes_token(self):"},{"line_number":1182,"context_line":"        # NOTE(lbragstad): This test doens\u0027t really make much sense because we"},{"line_number":1183,"context_line":"        # can\u0027t validate trust-scoped tokens against the v2.0 API."},{"line_number":1184,"context_line":"        unscoped_token \u003d self.get_unscoped_token(self.trustor[\u0027name\u0027])"},{"line_number":1185,"context_line":"        new_trust \u003d self.create_trust(self.sample_data, self.trustor[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_3ae2d22f","line":1182,"range":{"start_line":1182,"start_character":10,"end_line":1182,"end_character":14},"updated":"2016-07-26 14:16:37.000000000","message":"maybe change from NOTE to FIXME?","commit_id":"1bc3df0a42bbdf6b125de32c04499f9e26112d51"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"76adc38985f290845a561e3b961d54509091fda3","unresolved":false,"context_lines":[{"line_number":1313,"context_line":"        self.skipTest(msg)"},{"line_number":1314,"context_line":""},{"line_number":1315,"context_line":"    def test_delete_trust_revokes_token(self):"},{"line_number":1316,"context_line":"        # NOTE(lbragstad): This test doens\u0027t really make much sense because we"},{"line_number":1317,"context_line":"        # can\u0027t validate trust-scoped tokens against the v2.0 API. This was"},{"line_number":1318,"context_line":"        # originally validating that UUID tokens were removed from the backend"},{"line_number":1319,"context_line":"        # when a trust was deleted. Fernet tokens aren\u0027t persisted in the"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_8c076717","line":1316,"updated":"2016-07-29 16:22:57.000000000","message":"Agree, but this is great test coverage of a nonsense use case :P","commit_id":"b77c5b789fae62aa7375296bf49985cf213e0a87"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"49334814c35ddf6201ffa00f38c1a2034380f213","unresolved":false,"context_lines":[{"line_number":1384,"context_line":"        self.assertEqual("},{"line_number":1385,"context_line":"            timeutils.parse_isotime(original_expiration),"},{"line_number":1386,"context_line":"            timeutils.parse_isotime(r[\u0027access\u0027][\u0027token\u0027][\u0027expires\u0027])"},{"line_number":1387,"context_line":"        )"},{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":"        mock_utcnow.return_value \u003d now + datetime.timedelta(seconds\u003d2)"},{"line_number":1390,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_be4d3140","line":1387,"updated":"2016-07-29 15:52:07.000000000","message":"IMHO this change looks unrelated to the patch goal.","commit_id":"b77c5b789fae62aa7375296bf49985cf213e0a87"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"49334814c35ddf6201ffa00f38c1a2034380f213","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"        self.assertEqual("},{"line_number":1408,"context_line":"            timeutils.parse_isotime(original_expiration),"},{"line_number":1409,"context_line":"            timeutils.parse_isotime(r[\u0027access\u0027][\u0027token\u0027][\u0027expires\u0027])"},{"line_number":1410,"context_line":"        )"},{"line_number":1411,"context_line":""},{"line_number":1412,"context_line":"    def test_maintain_uuid_token_expiration(self):"},{"line_number":1413,"context_line":"        self.config_fixture.config(group\u003d\u0027token\u0027, provider\u003d\u0027uuid\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_fe5329e0","line":1410,"updated":"2016-07-29 15:52:07.000000000","message":"same here","commit_id":"b77c5b789fae62aa7375296bf49985cf213e0a87"}]}