)]}'
{"keystone/assignment/controllers.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"9186dc7eedbec28f556d4c7d0670207f5d9d897f","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @controller.v2_deprecated"},{"line_number":95,"context_line":"    def create_role(self, request, role):"},{"line_number":96,"context_line":"        validation.lazy_validate(schema.role_create, role)"},{"line_number":97,"context_line":"        role \u003d self._normalize_dict(role)"},{"line_number":98,"context_line":"        self.assert_admin(request)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_f8ae1d80","line":96,"range":{"start_line":96,"start_character":40,"end_line":96,"end_character":51},"updated":"2016-07-22 08:38:00.000000000","message":"looks like v2 role has \u0027description\u0027 and \u0027id\u0027, does that matter?\n\nhttp://developer.openstack.org/api-ref/identity/v2-ext/index.html?expanded\u003dcreate-a-role-detail#os-kscrud-extension","commit_id":"79c341d3d480a067179c5278f5539d5b32273a3b"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"8800d127ed0a9c4af3402fe680d78022a44d2291","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @controller.v2_deprecated"},{"line_number":95,"context_line":"    def create_role(self, request, role):"},{"line_number":96,"context_line":"        validation.lazy_validate(schema.role_create, role)"},{"line_number":97,"context_line":"        role \u003d self._normalize_dict(role)"},{"line_number":98,"context_line":"        self.assert_admin(request)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_8bc05b2c","line":96,"range":{"start_line":96,"start_character":40,"end_line":96,"end_character":51},"in_reply_to":"dada55a8_f8ae1d80","updated":"2016-07-22 13:14:42.000000000","message":"I can add it to the schema for clarity","commit_id":"79c341d3d480a067179c5278f5539d5b32273a3b"}],"keystone/assignment/schema.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"2c28ec770cda101c318593771ff41de36a537aa1","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"_role_properties_v2 \u003d {"},{"line_number":18,"context_line":"    \u0027name\u0027: parameter_types.name,"},{"line_number":19,"context_line":"    \u0027id\u0027: parameter_types.id_string,"},{"line_number":20,"context_line":"    \u0027description\u0027: parameter_types.id_string"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_fdd52a1b","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":36},"updated":"2016-07-25 02:21:24.000000000","message":"better to have a testcase for this one","commit_id":"80b4ffaa9f85bcf429c28040c213dc0f00563453"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"2c28ec770cda101c318593771ff41de36a537aa1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"_role_properties_v2 \u003d {"},{"line_number":18,"context_line":"    \u0027name\u0027: parameter_types.name,"},{"line_number":19,"context_line":"    \u0027id\u0027: parameter_types.id_string,"},{"line_number":20,"context_line":"    \u0027description\u0027: parameter_types.id_string"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"role_create_v2 \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_5ddd5641","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":44},"updated":"2016-07-25 02:21:24.000000000","message":"same for this one.","commit_id":"80b4ffaa9f85bcf429c28040c213dc0f00563453"}],"keystone/tests/unit/test_v2_validation.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"92d949167466c738e728e45a896c12c27ff5459d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_0fd92984","line":1,"updated":"2016-07-22 07:37:22.000000000","message":"the only suggestion I have is creating a role with 2 attributes, name and bogus -- it should succeed.","commit_id":"79c341d3d480a067179c5278f5539d5b32273a3b"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"8800d127ed0a9c4af3402fe680d78022a44d2291","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_ab755f33","line":1,"in_reply_to":"dada55a8_0fd92984","updated":"2016-07-22 13:14:42.000000000","message":"sure","commit_id":"79c341d3d480a067179c5278f5539d5b32273a3b"}]}