)]}'
{"keystone/token/controllers.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dbd9af888eafb61906c54dfb46d27cb8fb96d260","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                raise exception.Unauthorized(e)"},{"line_number":368,"context_line":"        return tenant_id"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def _get_domain_id_from_auth(self, context, auth):"},{"line_number":371,"context_line":"        \"\"\"Extract domain information from v3 auth dict."},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        Returns a valid domain_id if it exists, or None if not specified."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FkgU%3D","line":370,"updated":"2013-06-27 16:07:06.000000000","message":"context isn\u0027t used here anymore, so remove it. Can do this in a separate patch.","commit_id":"3369aa9a79eab810986fac7b19f52acfd60deca5"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b57e8bdcce330f4493b258d8e4e9d64006520cd9","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                raise exception.Unauthorized(e)"},{"line_number":368,"context_line":"        return tenant_id"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def _get_domain_id_from_auth(self, context, auth):"},{"line_number":371,"context_line":"        \"\"\"Extract domain information from v3 auth dict."},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        Returns a valid domain_id if it exists, or None if not specified."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FkbM%3D","line":370,"in_reply_to":"AAAAPn%2F%2FkgU%3D","updated":"2013-06-27 16:31:47.000000000","message":"I tried to get them as I saw them -- if you can catch any remaining, i\u0027m more than eager to remove them","commit_id":"3369aa9a79eab810986fac7b19f52acfd60deca5"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dbd9af888eafb61906c54dfb46d27cb8fb96d260","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                raise exception.Unauthorized(e)"},{"line_number":387,"context_line":"        return domain_id"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def _get_project_ref(self, context, user_id, tenant_id):"},{"line_number":390,"context_line":"        \"\"\"Returns the tenant_ref for the user\u0027s tenant.\"\"\""},{"line_number":391,"context_line":"        tenant_ref \u003d None"},{"line_number":392,"context_line":"        if tenant_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FkgQ%3D","line":389,"updated":"2013-06-27 16:07:06.000000000","message":"remove context here, too.","commit_id":"3369aa9a79eab810986fac7b19f52acfd60deca5"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dbd9af888eafb61906c54dfb46d27cb8fb96d260","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                exception.Unauthorized(e)"},{"line_number":404,"context_line":"        return tenant_ref"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def _get_metadata_ref(self, context, user_id\u003dNone, tenant_id\u003dNone,"},{"line_number":407,"context_line":"                          domain_id\u003dNone, group_id\u003dNone):"},{"line_number":408,"context_line":"        \"\"\"Returns metadata_ref for a user or group in a tenant or domain.\"\"\""},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FkgE%3D","line":406,"updated":"2013-06-27 16:07:06.000000000","message":"remove context here, too.\n\nThis is a common comment, so just suggest go through this file and remove from private methods (e.g., at 420, 443)","commit_id":"3369aa9a79eab810986fac7b19f52acfd60deca5"}],"tests/test_auth.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dbd9af888eafb61906c54dfb46d27cb8fb96d260","unresolved":false,"context_lines":[{"line_number":533,"context_line":"        trust_data[\u0027impersonation\u0027] \u003d impersonation"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        self.new_trust \u003d self.trust_controller.create_trust("},{"line_number":536,"context_line":"            context, trust\u003dtrust_data)[\u0027trust\u0027]"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"    def build_v2_token_request(self, username, password):"},{"line_number":539,"context_line":"        body_dict \u003d _build_user_auth(username\u003dusername, password\u003dpassword)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FkfU%3D","line":536,"updated":"2013-06-27 16:07:06.000000000","message":"suggest revert this change since it\u0027s cleanup and not removing context.","commit_id":"3369aa9a79eab810986fac7b19f52acfd60deca5"}],"tests/test_backend.py":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"18bedb3bfa24784b9512c0a9bc15bef65e28aa56","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from keystone import exception"},{"line_number":25,"context_line":"from keystone.openstack.common import timeutils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import default_fixtures"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fkjg%3D","line":27,"updated":"2013-06-27 15:56:12.000000000","message":"This might hit a Flake 8 our of ABC order rule.","commit_id":"3369aa9a79eab810986fac7b19f52acfd60deca5"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dbd9af888eafb61906c54dfb46d27cb8fb96d260","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from keystone import exception"},{"line_number":25,"context_line":"from keystone.openstack.common import timeutils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import default_fixtures"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FkfM%3D","line":27,"in_reply_to":"AAAAPn%2F%2Fkjg%3D","updated":"2013-06-27 16:07:06.000000000","message":"Looks like the right order to me. This import is specific to testing.","commit_id":"3369aa9a79eab810986fac7b19f52acfd60deca5"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dbd9af888eafb61906c54dfb46d27cb8fb96d260","unresolved":false,"context_lines":[{"line_number":2572,"context_line":"        self.assertRaises(exception.PolicyNotFound,"},{"line_number":2573,"context_line":"                          self.policy_man.update_policy,"},{"line_number":2574,"context_line":"                          uuid.uuid4().hex,"},{"line_number":2575,"context_line":"                          dict())"},{"line_number":2576,"context_line":""},{"line_number":2577,"context_line":"    def test_delete_policy_404(self):"},{"line_number":2578,"context_line":"        self.assertRaises(exception.PolicyNotFound,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fke8%3D","line":2575,"updated":"2013-06-27 16:07:06.000000000","message":"suggest give a name to this unnamed dict.","commit_id":"3369aa9a79eab810986fac7b19f52acfd60deca5"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b57e8bdcce330f4493b258d8e4e9d64006520cd9","unresolved":false,"context_lines":[{"line_number":2572,"context_line":"        self.assertRaises(exception.PolicyNotFound,"},{"line_number":2573,"context_line":"                          self.policy_man.update_policy,"},{"line_number":2574,"context_line":"                          uuid.uuid4().hex,"},{"line_number":2575,"context_line":"                          dict())"},{"line_number":2576,"context_line":""},{"line_number":2577,"context_line":"    def test_delete_policy_404(self):"},{"line_number":2578,"context_line":"        self.assertRaises(exception.PolicyNotFound,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FkZs%3D","line":2575,"in_reply_to":"AAAAPn%2F%2Fke8%3D","updated":"2013-06-27 16:31:47.000000000","message":"Done","commit_id":"3369aa9a79eab810986fac7b19f52acfd60deca5"}]}
