)]}'
{"keystone/exception.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6e4b556edad326b27ff0def1b2fd36df216b30d9","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    amendment \u003d _(\u0027(Disable insecure_debug mode to suppress these details.)\u0027)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def __deepcopy__(self):"},{"line_number":186,"context_line":"        return self"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def _build_message(self, message, **kwargs):"},{"line_number":189,"context_line":"        \"\"\"Only returns detailed messages in insecure_debug mode.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_42045d14","line":186,"updated":"2016-07-28 14:04:00.000000000","message":"We could add a little context here in a comment. The docstring of the tests added for this summarize the problem well. I\u0027m wondering if we should do the same here?","commit_id":"fa3841c05bf6c228a3a9f18b26ce254bc5979250"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4da792e51ae3c64a296bc1dd474791b1139437db","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    amendment \u003d _(\u0027(Disable insecure_debug mode to suppress these details.)\u0027)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def __deepcopy__(self):"},{"line_number":186,"context_line":"        return self"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def _build_message(self, message, **kwargs):"},{"line_number":189,"context_line":"        \"\"\"Only returns detailed messages in insecure_debug mode.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_a2571901","line":186,"in_reply_to":"bacf61ea_42045d14","updated":"2016-07-28 14:04:24.000000000","message":"lol - it looks like pep8 agrees! \n\nhttp://logs.openstack.org/86/348086/2/check/gate-keystone-pep8-ubuntu-xenial/8b011a2/console.html#_2016-07-28_04_22_15_811709","commit_id":"fa3841c05bf6c228a3a9f18b26ce254bc5979250"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"cb46b60110cdffcf50add78814596c958d7783ab","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    amendment \u003d _(\u0027(Disable insecure_debug mode to suppress these details.)\u0027)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def __deepcopy__(self):"},{"line_number":186,"context_line":"        return self"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def _build_message(self, message, **kwargs):"},{"line_number":189,"context_line":"        \"\"\"Only returns detailed messages in insecure_debug mode.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_2413320f","line":186,"in_reply_to":"bacf61ea_a2571901","updated":"2016-07-28 15:22:49.000000000","message":"done","commit_id":"fa3841c05bf6c228a3a9f18b26ce254bc5979250"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c1c3347a676191c6da5c96da09a5c318840d3542","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        logged. This is because the code tries to use the `message_format` in"},{"line_number":205,"context_line":"        secure mode, but the required kwargs are not in the deep copy."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        The end result is not an error because when the KeyError is cause the"},{"line_number":208,"context_line":"        instance\u0027s ``message`` is used instead and this has the properly"},{"line_number":209,"context_line":"        translated message. The only indication that something is wonky is a"},{"line_number":210,"context_line":"        message in the warning log."}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_1c647a20","line":207,"updated":"2016-07-28 18:36:53.000000000","message":"caught*","commit_id":"2599f41f3007f78b9efb22a2211fba69902412eb"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"dfb2e12241467144ca893945010fcb3b331bd327","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        logged. This is because the code tries to use the `message_format` in"},{"line_number":205,"context_line":"        secure mode, but the required kwargs are not in the deep copy."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        The end result is not an error because when the KeyError is cause the"},{"line_number":208,"context_line":"        instance\u0027s ``message`` is used instead and this has the properly"},{"line_number":209,"context_line":"        translated message. The only indication that something is wonky is a"},{"line_number":210,"context_line":"        message in the warning log."}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_dce01bfd","line":207,"in_reply_to":"bacf61ea_1c647a20","updated":"2016-07-28 20:58:24.000000000","message":"Done","commit_id":"2599f41f3007f78b9efb22a2211fba69902412eb"}],"keystone/tests/unit/test_exception.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1af0f317dcfc75c5e7dcc961d6266c6434ade5ff","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from keystone import exception"},{"line_number":26,"context_line":"from keystone.i18n import _LE"},{"line_number":27,"context_line":"from keystone.tests import unit"},{"line_number":28,"context_line":"from keystone.tests.unit import utils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF \u003d keystone.conf.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_46b011de","side":"PARENT","line":28,"updated":"2016-07-28 01:50:49.000000000","message":"Looks like this isn\u0027t used anymore.","commit_id":"064d0f257d2f244539e4055eb12cf773b73fc021"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"ee49b6e9c5a09b86308f0fdf511f4371f043a391","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from keystone import exception"},{"line_number":26,"context_line":"from keystone.i18n import _LE"},{"line_number":27,"context_line":"from keystone.tests import unit"},{"line_number":28,"context_line":"from keystone.tests.unit import utils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF \u003d keystone.conf.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_cd41bd3b","side":"PARENT","line":28,"in_reply_to":"bacf61ea_46b011de","updated":"2016-07-28 04:12:08.000000000","message":"Done","commit_id":"064d0f257d2f244539e4055eb12cf773b73fc021"}]}