)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"e215dd89213477338ff929f89f47d863b32c0505","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added the driver interface \u0027base.EndpointPolicyDriverV8\u0027 as super class"},{"line_number":10,"context_line":"of the sql driver implementation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Removed unused methods from driver interface and added release notes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I198dcbda7591e0dafb1da3a72e3f32b258c0e299"},{"line_number":15,"context_line":"Closes-Bug: #1611102"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a89bdaa_d7460e4e","line":12,"updated":"2016-09-07 16:39:19.000000000","message":"(nit) This makes the patch look like 2-in-1 change. Since changes are related, it\u0027s tolerable.","commit_id":"97585c15a62eb081cce5489bf4b91f0ee0334fcb"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"910fcbc1c89f660613eb9b5b2d14b7fbe2749c91","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added the driver interface \u0027base.EndpointPolicyDriverV8\u0027 as super class"},{"line_number":10,"context_line":"of the sql driver implementation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Removed unused methods from driver interface and added release notes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I198dcbda7591e0dafb1da3a72e3f32b258c0e299"},{"line_number":15,"context_line":"Closes-Bug: #1611102"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a89bdaa_d3852fcf","line":12,"in_reply_to":"9a89bdaa_d7460e4e","updated":"2016-09-08 01:50:35.000000000","message":"the workflow I\u0027ve seen the most is that the release notes come in the same patch that makes the change described there","commit_id":"97585c15a62eb081cce5489bf4b91f0ee0334fcb"}],"keystone/endpoint_policy/backends/sql.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"377f3daa5950348512045dda2e304fb87269b79f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        return d"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class EndpointPolicy(base.EndpointPolicyDriverV8):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def create_policy_association(self, policy_id, endpoint_id\u003dNone,"},{"line_number":53,"context_line":"                                  service_id\u003dNone, region_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_e9c74343","line":50,"range":{"start_line":50,"start_character":21,"end_line":50,"end_character":25},"updated":"2016-08-09 04:51:38.000000000","message":"i think you\u0027re not importing base...\n\nfrom keystone.endpoint_policy.backends import base\n\nhttps://github.com/openstack/keystone/blob/master/keystone/endpoint_policy/backends/base.py","commit_id":"3b706eaa494e42a955f84aa2e97d10fae9f0cfd4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"5f87f8bc250306847406f9981846b2358bef7190","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        return d"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class EndpointPolicy(base.EndpointPolicyDriverV8):"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def create_policy_association(self, policy_id, endpoint_id\u003dNone,"},{"line_number":54,"context_line":"                                  service_id\u003dNone, region_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_de36ac4f","line":51,"range":{"start_line":51,"start_character":6,"end_line":51,"end_character":20},"updated":"2016-08-18 16:45:18.000000000","message":"Looks like this class is not implementing all of the base class methods, e.g. list_endpoints_for_policy(self, policy_id):","commit_id":"6bff01c70f2c65c5a73209d98ec91d77c0473c10"}],"releasenotes/notes/endpoint_policy_driver_unused_methods_removed-e1348cbec9b1110a.yaml":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"fcea846372825073b6f5a7027ebc72c2938eb9c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - We have removed unused methods ``list_endpoints_for_policy()``"},{"line_number":4,"context_line":"    and ``get_policy_for_endpoint()`` from the EndpointPolicy driver"},{"line_number":5,"context_line":"    interface."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a89bdaa_ac296a39","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":14},"updated":"2016-09-07 05:21:52.000000000","message":"I\u0027d rephrase as:\n\nThe methods ``list_endpoints_for_policy`` and ``get_policy_for_endpoint`` have been removed from the EndpointPolicy driver interface.\n\n\nI\u0027ve not seen the use of \u0027we\u0027 in release notes","commit_id":"eb9cf10d79a9dad7032ba2857b20fee18ebc06b6"},{"author":{"_account_id":18261,"name":"Harini","email":"harinipradeep27@gmail.com","username":"harini"},"change_message_id":"0771673e7c32484b75eef2174483bc9246b97fd9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - We have removed unused methods ``list_endpoints_for_policy()``"},{"line_number":4,"context_line":"    and ``get_policy_for_endpoint()`` from the EndpointPolicy driver"},{"line_number":5,"context_line":"    interface."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a89bdaa_cdae9e80","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":14},"in_reply_to":"9a89bdaa_ac296a39","updated":"2016-09-07 09:43:25.000000000","message":"Done","commit_id":"eb9cf10d79a9dad7032ba2857b20fee18ebc06b6"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"a04216d494b9d221711428fb2e60ae8280d2a7c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The  methods ``list_endpoints_for_policy()`` and "},{"line_number":4,"context_line":"    ``get_policy_for_endpoint()`` have been removed from the EndpointPolicy"},{"line_number":5,"context_line":"    driver interface."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a89bdaa_403335f6","line":3,"range":{"start_line":3,"start_character":52,"end_line":3,"end_character":53},"updated":"2016-09-07 09:45:43.000000000","message":"not sure that jenkins will let this through","commit_id":"97585c15a62eb081cce5489bf4b91f0ee0334fcb"}]}
