)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"46630487be306f645df23cc0b23cef94a2cd7888","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mikhail Nikolaenko \u003cmnikolaenko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-24 12:31:17 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Move fernet utils to backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8ab9e15effa05969e3980f64c0799c53fc77dc6a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ac06dbe_e11c936c","line":7,"updated":"2016-08-24 17:42:10.000000000","message":"This doesn\u0027t actually represent what this change is about. It\u0027s more about allowing alternate implemenations of the fernet key repository righyt?","commit_id":"cb264627dfc5e7aaa350f1917bd8025c06e750af"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"46630487be306f645df23cc0b23cef94a2cd7888","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mikhail Nikolaenko \u003cmnikolaenko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-24 12:31:17 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Move fernet utils to backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8ab9e15effa05969e3980f64c0799c53fc77dc6a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ac06dbe_c119977b","line":7,"updated":"2016-08-24 17:42:10.000000000","message":"You should add a description of why you are going this below. Do you have a need to create your own repository implementation?","commit_id":"cb264627dfc5e7aaa350f1917bd8025c06e750af"}],"keystone/common/fernet_key_store/__init__.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"46630487be306f645df23cc0b23cef94a2cd7888","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from keystone.common.fernet_key_store.core import *  # noqa"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_012a8f7e","line":13,"updated":"2016-08-24 17:42:10.000000000","message":"Don\u0027t import * here. Just import the things that you want to make available as a part of the API.","commit_id":"cb264627dfc5e7aaa350f1917bd8025c06e750af"}],"keystone/common/fernet_key_store/backends/base.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"46630487be306f645df23cc0b23cef94a2cd7888","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import abc"},{"line_number":14,"context_line":"import six"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from keystone import exception"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_21250bae","line":14,"updated":"2016-08-24 17:42:10.000000000","message":"six is a third party library and should be in it\u0027s own section\nhttp://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"cb264627dfc5e7aaa350f1917bd8025c06e750af"}],"keystone/common/fernet_key_store/core.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"46630487be306f645df23cc0b23cef94a2cd7888","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from keystone.common import dependency"},{"line_number":14,"context_line":"from keystone.common import manager"},{"line_number":15,"context_line":"from oslo_config import cfg"},{"line_number":16,"context_line":"from oslo_log import log"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_810f9f2d","line":14,"updated":"2016-08-24 17:42:10.000000000","message":"The imports are not in the correct order\nhttp://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"cb264627dfc5e7aaa350f1917bd8025c06e750af"}]}