)]}'
{"keystone/identity/shadow_backends/sql.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f151577aee0718d857d7152569ec72d1556df598","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def create_nonlocal_user(self, user_dict):"},{"line_number":92,"context_line":"        new_user_dict \u003d copy.deepcopy(user_dict)"},{"line_number":93,"context_line":"        # remove local_user attributes from new_user_dict"},{"line_number":94,"context_line":"        keys_to_delete \u003d \u0027domain_id\u0027, \u0027name\u0027, \u0027password\u0027"},{"line_number":95,"context_line":"        for key in keys_to_delete:"},{"line_number":96,"context_line":"            if key in new_user_dict:"},{"line_number":97,"context_line":"                del new_user_dict[key]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_1f55ad4f","line":94,"range":{"start_line":94,"start_character":25,"end_line":94,"end_character":56},"updated":"2016-08-20 02:40:37.000000000","message":"this works, but it should probably be an iterable, like a list","commit_id":"61985ed799dc706647f38025a4c84c72d646f317"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"b98071402ecce77aaa7b50a44224ea896033ece9","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def create_nonlocal_user(self, user_dict):"},{"line_number":92,"context_line":"        new_user_dict \u003d copy.deepcopy(user_dict)"},{"line_number":93,"context_line":"        # remove local_user attributes from new_user_dict"},{"line_number":94,"context_line":"        keys_to_delete \u003d \u0027domain_id\u0027, \u0027name\u0027, \u0027password\u0027"},{"line_number":95,"context_line":"        for key in keys_to_delete:"},{"line_number":96,"context_line":"            if key in new_user_dict:"},{"line_number":97,"context_line":"                del new_user_dict[key]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_2242123f","line":94,"range":{"start_line":94,"start_character":25,"end_line":94,"end_character":56},"in_reply_to":"1ac06dbe_1f55ad4f","updated":"2016-08-20 02:57:59.000000000","message":"Done","commit_id":"61985ed799dc706647f38025a4c84c72d646f317"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"d71c20fe86e7f77272d71b17edfb6c756eabad00","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @sql.handle_conflicts(conflict_type\u003d\u0027nonlocal_user\u0027)"},{"line_number":91,"context_line":"    def create_nonlocal_user(self, user_dict):"},{"line_number":92,"context_line":"        new_user_dict \u003d copy.deepcopy(user_dict)"},{"line_number":93,"context_line":"        # remove local_user attributes from new_user_dict"},{"line_number":94,"context_line":"        keys_to_delete \u003d [\u0027domain_id\u0027, \u0027name\u0027, \u0027password\u0027]"},{"line_number":95,"context_line":"        for key in keys_to_delete:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_10ba650a","line":92,"updated":"2016-08-22 21:49:55.000000000","message":"are you going to use \"user_dict\" afterwords? If not, a tiny improvement would be to delete the keys below before copying the dict.","commit_id":"70e6d58f461bd066a9f149be8ef096884b3ce6b0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"d71c20fe86e7f77272d71b17edfb6c756eabad00","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def create_nonlocal_user(self, user_dict):"},{"line_number":92,"context_line":"        new_user_dict \u003d copy.deepcopy(user_dict)"},{"line_number":93,"context_line":"        # remove local_user attributes from new_user_dict"},{"line_number":94,"context_line":"        keys_to_delete \u003d [\u0027domain_id\u0027, \u0027name\u0027, \u0027password\u0027]"},{"line_number":95,"context_line":"        for key in keys_to_delete:"},{"line_number":96,"context_line":"            if key in new_user_dict:"},{"line_number":97,"context_line":"                del new_user_dict[key]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_1019c579","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":22},"updated":"2016-08-22 21:49:55.000000000","message":"nit: just used once\n\nalternative:\n\n  for key in [\u0027domain_id\u0027, \u0027name\u0027, \u0027password\u0027]:\n    new_user_dict.pop(key, None)","commit_id":"70e6d58f461bd066a9f149be8ef096884b3ce6b0"}]}